[Bug build/31223] New: gdb/dwarf2/read.c: m_failed and m_reported not available unless CXX_STD_THREAD defined

[Bug build/31223] New: gdb/dwarf2/read.c: m_failed and m_reported not available unless CXX_STD_THREAD defined

[pexu at sourceware dot mail.kapsi.fi]

https://sourceware.org/bugzilla/show_bug.cgi?id=31223

            Bug ID: 31223
           Summary: gdb/dwarf2/read.c: m_failed and m_reported not
                    available unless CXX_STD_THREAD defined
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: pexu at sourceware dot mail.kapsi.fi
  Target Milestone: ---

Hi.

cooked_index_worker members m_failed and m_reported are currently only
available if CXX_STD_THREAD guard is defined and non-zero.

There are unguarded references to these members at gdb/dwarf2/read.c.  Given
the context, I wonder if these members should be always available.

m_failed: lines 4925 and 5047, 5050 and 5051.
m_reported: lines 5039 and 5041.

https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/dwarf2/read.c;h=e055371dc6a1b9d63920dcc72a9e63efcd8297bc

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/31223] gdb/dwarf2/read.c: m_failed and m_reported not available unless CXX_STD_THREAD defined

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31223

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Sorry about that, I'll take a look.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/31223] gdb/dwarf2/read.c: m_failed and m_reported not available unless CXX_STD_THREAD defined

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31223

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-01-09
             Status|UNCONFIRMED                 |NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/31223] gdb/dwarf2/read.c: m_failed and m_reported not available unless CXX_STD_THREAD defined

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31223

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8baaed84cbc1abf6797016f36c1d9842631c777e

commit 8baaed84cbc1abf6797016f36c1d9842631c777e
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Jan 9 13:21:12 2024 -0700

    Fix thread-less build

    A user pointed out that the recent background DWARF reader series
    broke the build when --disable-threading is in use.  This patch fixes
    the problem.  I am checking it in.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31223

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/31223] gdb/dwarf2/read.c: m_failed and m_reported not available unless CXX_STD_THREAD defined

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31223

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |15.1
             Status|NEW                         |RESOLVED

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.