[Bug gdb/31307] New: gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[Bug gdb/31307] New: gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[pexu at sourceware dot mail.kapsi.fi]

https://sourceware.org/bugzilla/show_bug.cgi?id=31307

            Bug ID: 31307
           Summary: gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on
                    MinGW
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: pexu at sourceware dot mail.kapsi.fi
  Target Milestone: ---

Hi.

Recent domain_search_flags patch [1] introduces a convenience constant
SEARCH_ALL that unfortunately clashes with SEARCH_ALL macro that is defined
<winioctl.h>.  

This header file is included indirectly when compiling gdb/mingw-hdep.c (via
gdb/serial.h:23 -> /mingw-w64/include/winsock2.h:23 ->
/mingw-w64/include/windows.h:97 -> /mingw-w64/include/winscard.h:11 ->
/mingw-w64/include/winioctl.h).

A quick (and dirty) workaround would be to add #define NOCRYPT prior serial.h
include.  However, in the long run, it might be more beneficial to move
<windows.h> et. al. to a shared header that sets up all feature removal macros.

[1]
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=25f31e1820dcec2f0c073c28cbf88646c7c2af97

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31307] gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31307

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
                 CC|                            |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31307] gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31307

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I don't mind renaming this, but FWIW I can't reproduce the
problem with my Fedora-hosted mingw cross.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31307] gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31307

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-01-29
     Ever confirmed|0                           |1

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
Aha, I was on the wrong branch, of course.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31307] gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31307

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2024-January/206260.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31307] gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31307

--- Comment #4 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f214edceb8cd97058c2682efb7b321d923e4ff02

commit f214edceb8cd97058c2682efb7b321d923e4ff02
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Jan 29 09:45:35 2024 -0700

    Rename SEARCH_ALL

    The constant SEARCH_ALL conflicts with a define in a Windows header.
    This patch renames the constant to SEARCH_ALL_DOMAINS to avoid the
    conflict.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31307

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31307] gdb/symtab.h: SEARCH_ALL clashes with <winioctl.h> on MinGW

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31307

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.