public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug dap/31341] New: Add "finish" result to local variables
@ 2024-02-05 20:30 tromey at sourceware dot org
2024-02-09 20:37 ` [Bug dap/31341] " tromey at sourceware dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: tromey at sourceware dot org @ 2024-02-05 20:30 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31341
Bug ID: 31341
Summary: Add "finish" result to local variables
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: dap
Assignee: unassigned at sourceware dot org
Reporter: tromey at sourceware dot org
Target Milestone: ---
Right now a "finish" result isn't shown anywhere.
However, upstream DAP mentioned in a bug that other adapters
put this result into the local variables:
https://github.com/microsoft/debug-adapter-protocol/issues/458#issuecomment-1927560756
gdb could do this as well.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug dap/31341] Add "finish" result to local variables 2024-02-05 20:30 [Bug dap/31341] New: Add "finish" result to local variables tromey at sourceware dot org @ 2024-02-09 20:37 ` tromey at sourceware dot org 2024-02-12 16:35 ` tromey at sourceware dot org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: tromey at sourceware dot org @ 2024-02-09 20:37 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31341 --- Comment #1 from Tom Tromey <tromey at sourceware dot org> --- To make this work I think we'll need to expose the 'finish' value on the stop event. This looks relatively straightforward in py-stopevent.c. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dap/31341] Add "finish" result to local variables 2024-02-05 20:30 [Bug dap/31341] New: Add "finish" result to local variables tromey at sourceware dot org 2024-02-09 20:37 ` [Bug dap/31341] " tromey at sourceware dot org @ 2024-02-12 16:35 ` tromey at sourceware dot org 2024-02-12 18:47 ` tromey at sourceware dot org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: tromey at sourceware dot org @ 2024-02-12 16:35 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31341 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at sourceware dot org |tromey at sourceware dot org -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dap/31341] Add "finish" result to local variables 2024-02-05 20:30 [Bug dap/31341] New: Add "finish" result to local variables tromey at sourceware dot org 2024-02-09 20:37 ` [Bug dap/31341] " tromey at sourceware dot org 2024-02-12 16:35 ` tromey at sourceware dot org @ 2024-02-12 18:47 ` tromey at sourceware dot org 2024-03-08 17:56 ` cvs-commit at gcc dot gnu.org 2024-03-08 17:57 ` tromey at sourceware dot org 4 siblings, 0 replies; 6+ messages in thread From: tromey at sourceware dot org @ 2024-02-12 18:47 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31341 --- Comment #2 from Tom Tromey <tromey at sourceware dot org> --- https://sourceware.org/pipermail/gdb-patches/2024-February/206539.html -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dap/31341] Add "finish" result to local variables 2024-02-05 20:30 [Bug dap/31341] New: Add "finish" result to local variables tromey at sourceware dot org ` (2 preceding siblings ...) 2024-02-12 18:47 ` tromey at sourceware dot org @ 2024-03-08 17:56 ` cvs-commit at gcc dot gnu.org 2024-03-08 17:57 ` tromey at sourceware dot org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2024-03-08 17:56 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31341 --- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2755241d02d7f129848adb6d76316b8116f346f8 commit 2755241d02d7f129848adb6d76316b8116f346f8 Author: Tom Tromey <tromey@adacore.com> Date: Mon Feb 12 10:12:26 2024 -0700 Add return value to DAP scope A bug report in the DAP specification repository pointed out that it is typical for DAP implementations to put a function's return value into the outermost scope. This patch changes gdb to follow this convention. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31341 Reviewed-By: Kévin Le Gouguec <legouguec@adacore.com> -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug dap/31341] Add "finish" result to local variables 2024-02-05 20:30 [Bug dap/31341] New: Add "finish" result to local variables tromey at sourceware dot org ` (3 preceding siblings ...) 2024-03-08 17:56 ` cvs-commit at gcc dot gnu.org @ 2024-03-08 17:57 ` tromey at sourceware dot org 4 siblings, 0 replies; 6+ messages in thread From: tromey at sourceware dot org @ 2024-03-08 17:57 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31341 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |15.1 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Tom Tromey <tromey at sourceware dot org> --- Fixed. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-08 17:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-02-05 20:30 [Bug dap/31341] New: Add "finish" result to local variables tromey at sourceware dot org 2024-02-09 20:37 ` [Bug dap/31341] " tromey at sourceware dot org 2024-02-12 16:35 ` tromey at sourceware dot org 2024-02-12 18:47 ` tromey at sourceware dot org 2024-03-08 17:56 ` cvs-commit at gcc dot gnu.org 2024-03-08 17:57 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).