public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset
@ 2024-02-09 18:57 tromey at sourceware dot org
2024-02-09 18:58 ` [Bug symtab/31361] " tromey at sourceware dot org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: tromey at sourceware dot org @ 2024-02-09 18:57 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31361
Bug ID: 31361
Summary: .debug_names uses wrong form for DW_IDX_die_offset
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: symtab
Assignee: unassigned at sourceware dot org
Reporter: tromey at sourceware dot org
Target Milestone: ---
I noticed today that DW_IDX_die_offset is documented
as having a reference form, but right now gdb emits
it as:
m_abbrev_table.append_unsigned_leb128 (DW_IDX_die_offset);
m_abbrev_table.append_unsigned_leb128 (DW_FORM_udata);
this should probably be DW_FORM_sec_offset
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org @ 2024-02-09 18:58 ` tromey at sourceware dot org 2024-02-09 18:58 ` tromey at sourceware dot org ` (5 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: tromey at sourceware dot org @ 2024-02-09 18:58 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31361 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27453 Referenced Bugs: https://sourceware.org/bugzilla/show_bug.cgi?id=27453 [Bug 27453] [meta] DWARF 5 support -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org 2024-02-09 18:58 ` [Bug symtab/31361] " tromey at sourceware dot org @ 2024-02-09 18:58 ` tromey at sourceware dot org 2024-02-10 0:18 ` tromey at sourceware dot org ` (4 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: tromey at sourceware dot org @ 2024-02-09 18:58 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31361 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |15.1 --- Comment #1 from Tom Tromey <tromey at sourceware dot org> --- Setting the target milestone here because this code is new and so we can fix it before it is visible in a release. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org 2024-02-09 18:58 ` [Bug symtab/31361] " tromey at sourceware dot org 2024-02-09 18:58 ` tromey at sourceware dot org @ 2024-02-10 0:18 ` tromey at sourceware dot org 2024-02-10 0:36 ` tromey at sourceware dot org ` (3 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: tromey at sourceware dot org @ 2024-02-10 0:18 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31361 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at sourceware dot org |tromey at sourceware dot org -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org ` (2 preceding siblings ...) 2024-02-10 0:18 ` tromey at sourceware dot org @ 2024-02-10 0:36 ` tromey at sourceware dot org 2024-02-23 16:08 ` tromey at sourceware dot org ` (2 subsequent siblings) 6 siblings, 0 replies; 8+ messages in thread From: tromey at sourceware dot org @ 2024-02-10 0:36 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31361 --- Comment #2 from Tom Tromey <tromey at sourceware dot org> --- DW_FORM_ref_addr is better I think. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org ` (3 preceding siblings ...) 2024-02-10 0:36 ` tromey at sourceware dot org @ 2024-02-23 16:08 ` tromey at sourceware dot org 2024-03-01 0:14 ` cvs-commit at gcc dot gnu.org 2024-03-01 0:15 ` tromey at sourceware dot org 6 siblings, 0 replies; 8+ messages in thread From: tromey at sourceware dot org @ 2024-02-23 16:08 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31361 --- Comment #3 from Tom Tromey <tromey at sourceware dot org> --- https://sourceware.org/pipermail/gdb-patches/2024-February/206505.html -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org ` (4 preceding siblings ...) 2024-02-23 16:08 ` tromey at sourceware dot org @ 2024-03-01 0:14 ` cvs-commit at gcc dot gnu.org 2024-03-01 0:15 ` tromey at sourceware dot org 6 siblings, 0 replies; 8+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2024-03-01 0:14 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31361 --- Comment #4 from Sourceware Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=932e5949a9f366d149b1b9093c49225502dee890 commit 932e5949a9f366d149b1b9093c49225502dee890 Author: Tom Tromey <tom@tromey.com> Date: Fri Feb 9 17:40:35 2024 -0700 Use DW_FORM_ref_addr for DIE offset in .debug_names Today I realized that while the .debug_names writer uses DW_FORM_udata for the DIE offset, DW_FORM_ref_addr would be more appropriate here. This patch makes this change. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31361 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org ` (5 preceding siblings ...) 2024-03-01 0:14 ` cvs-commit at gcc dot gnu.org @ 2024-03-01 0:15 ` tromey at sourceware dot org 6 siblings, 0 replies; 8+ messages in thread From: tromey at sourceware dot org @ 2024-03-01 0:15 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31361 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Tom Tromey <tromey at sourceware dot org> --- Fixed. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-03-01 0:15 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-02-09 18:57 [Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset tromey at sourceware dot org 2024-02-09 18:58 ` [Bug symtab/31361] " tromey at sourceware dot org 2024-02-09 18:58 ` tromey at sourceware dot org 2024-02-10 0:18 ` tromey at sourceware dot org 2024-02-10 0:36 ` tromey at sourceware dot org 2024-02-23 16:08 ` tromey at sourceware dot org 2024-03-01 0:14 ` cvs-commit at gcc dot gnu.org 2024-03-01 0:15 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).