public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug python/31391] Incorrect FinishBreakpoint test
Date: Mon, 26 Feb 2024 16:05:39 +0000 [thread overview]
Message-ID: <bug-31391-4717-ee0MhsDTG4@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31391-4717@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=31391
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vries at gcc dot gnu.org
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #0)
> py-finishbreakpoint.exp does this:
>
> gdb_test "python print (finishbp_default.hit_count)" "1.*" "check
> finishBP on default frame has been hit"
>
> It is trying to check the hit count of this breakpoint.
> However, the actual output is:
>
> python print (finishbp_default.hit_count)
> Traceback (most recent call last):
> File "<string>", line 1, in <module>
> RuntimeError: Breakpoint 3 is invalid.
> Error while executing Python code.
>
>
> ... which matches by mistake.
> This came up in a patch series I'm working on.
>
> I plan to kfail this but not close this bug; I think
> this probably is a real problem of some sort.
I think this may be the behaviour specified here (
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Breakpoints-In-Python.html
):
...
The optional temporary argument makes the breakpoint a temporary breakpoint.
Temporary breakpoints are deleted after they have been hit. Any further access
to the Python breakpoint after it has been hit will result in a runtime error
(as that breakpoint has now been automatically deleted).
...
So AFAIU, this happens:
- finish breakpoints 3 and 4 are set at the same location
- a continue hits both finish breakpoints
- the hit_count is not available in either breakpoint, as per the doc, because
both temporary breakpoints have been deleted.
- the return_value is available in both finish breakpoints, because it doesn't
rely on accessing the underlying python breakpoint
I think the test-case can be updated to accept the current behaviour, or we can
even remove the hit_count test.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2024-02-26 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 15:41 [Bug python/31391] New: " tromey at sourceware dot org
2024-02-18 10:23 ` [Bug python/31391] " ssbssa at sourceware dot org
2024-02-26 16:05 ` vries at gcc dot gnu.org [this message]
2024-02-27 8:22 ` vries at gcc dot gnu.org
2024-02-27 9:14 ` vries at gcc dot gnu.org
2024-02-27 9:14 ` [Bug testsuite/31391] " vries at gcc dot gnu.org
2024-02-27 15:18 ` cvs-commit at gcc dot gnu.org
2024-02-27 15:19 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-31391-4717-ee0MhsDTG4@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=gdb-prs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).