[Bug testsuite/31435] New: [gdb/testsuite] Runtest error running DAP tests

[Bug testsuite/31435] New: [gdb/testsuite] Runtest error running DAP tests

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

            Bug ID: 31435
           Summary: [gdb/testsuite] Runtest error running DAP tests
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

When running the following command:
...
$ ( cd build/gdb/testsuite ; make V=1 check
'RUNTESTFLAGS=gdb.dap/ada-arrays.exp gdb.dap/ada-nested.exp gdb.dap/attach.exp'
)
...
I run into:
...
                === gdb tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /data/vries/gdb/src/gdb/testsuite/config/unix.exp as
tool-and-target-specific interface file.
Running /data/vries/gdb/src/gdb/testsuite/gdb.dap/ada-nested.exp ...
Running /data/vries/gdb/src/gdb/testsuite/gdb.dap/attach.exp ...
Running /data/vries/gdb/src/gdb/testsuite/gdb.dap/ada-arrays.exp ...
child process exited abnormally
    while executing
"exec sh -c "exec > /dev/null 2>&1 && (kill -2 -$spid || kill -2 $spid)""
    (procedure "close_wait_program" line 20)
    invoked from within
"close_wait_program $shell_id $pid"
    (procedure "standard_close" line 23)
    invoked from within
"standard_close "unix""
    ("eval" body line 1)
    invoked from within
"eval ${try}_${proc} \"$dest\" $args"
    (procedure "call_remote" line 42)
    invoked from within
"call_remote "" close "$host""
    (procedure "remote_close" line 3)
    invoked from within
"remote_close target"
    (procedure "cleanup_target_hook" line 13)
    invoked from within
"cleanup_target_hook $current_target"
    ("foreach" body line 283)
    invoked from within
"foreach current_target $target_list {
    verbose "target is $current_target"
    set current_target_name $current_target
    set tlist [split $curren..."
    (file "/usr/share/dejagnu/runtest.exp" line 1619)
make[1]: *** [Makefile:226: do-check-single] Error 1
make[1]: Leaving directory '/data/vries/gdb/leap-15-4/build/gdb/testsuite'
make: *** [Makefile:161: check] Error 2
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Starts with:
...
commit b452b96c1e57db42d50a42eb2f09f7c57681d073
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Feb 23 13:51:58 2024 -0700

    Explicitly quit gdb from DAP server thread
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
                 CC|                            |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
This seems to require all 3 .exp files on the command
line to provoke the failure, which is pretty weird.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Lots of bad stuff in the test suite in this area.
kill_wait_spawned_process doesn't deal with the board_info entry.
Unclear that switch_gdb_spawn_id is using the right
name in that array.
Of course a lot of this is due to dejagnu lossage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2024-March/207294.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
The patch fixes the errors with the three test-cases, but there are further
errors with:
...
$ ( cd build/gdb/testsuite ; make V=1 check RUNTESTFLAGS="$(cd
src/gdb/testsuite; echo gdb.dap/*.exp)" )
....

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #5)
> The patch fixes the errors with the three test-cases, but there are further
> errors with:
> ...
> $ ( cd build/gdb/testsuite ; make V=1 check RUNTESTFLAGS="$(cd
> src/gdb/testsuite; echo gdb.dap/*.exp)" )
> ....

More minimally:
...
$ ( cd build/gdb/testsuite; make V=1 check 'RUNTESTFLAGS=gdb.dap/ada-arrays.exp
gdb.dap/ada-nested.exp gdb.dap/ada-scopes.exp gdb.dap/args-env.exp
gdb.dap/assign.exp gdb.dap/attach.exp gdb.dap/basic-dap.exp
gdb.dap/bt-nodebug.exp gdb.dap/catch-exception.exp gdb.dap/children.exp
gdb.dap/cond-bp.exp  gdb.dap/remote-dap.exp   ' )
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
Looks like gdbserver start/stop functions also have this problem.
One thing I don't understand is why this affects DAP tests
specifically and not other ones, or why my original patch
would have possibly provoked this.  It seems like a pre-existing
problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
Both these spots use "wait -nowait" but I wonder if it's just
better to use remote_wait with a timeout instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #9 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Tom Tromey from comment #8)
> Both these spots use "wait -nowait" but I wonder if it's just
> better to use remote_wait with a timeout instead.

Oh, never mind, remote_wait is written to only handle
a single spawnee.  dejagnu :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #10 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2024-March/207304.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

--- Comment #11 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2518ce94704e54597bec273cafb090693b2de098

commit 2518ce94704e54597bec273cafb090693b2de098
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Mar 14 11:35:25 2024 -0600

    Clear board_info entry after waiting for process

    When certain DAP tests are run in a certain order, dejagnu will throw
    an exception during shutdown.  After adding many logging statements, I
    tracked this down to kill_wait_spawned_process not clearing the
    'fileid' board_info entry, causing dejagnu to try to wait for the
    process a second time -- and fail.

    Tom de Vries then pointed out a second instance of this, which I
    tracked down to the same problem occurring when spawning gdbserver.

    This version of the patch fixes this by adding a new proc that can be
    used to clean up board_info after waiting for a process to exit.  I'm
    not sure why this problem hasn't affected the test suite in the past.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31435
    Approved-By: Andrew Burgess <aburgess@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31435] [gdb/testsuite] Runtest error running DAP tests

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31435

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.2
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.