[Bug gdb/31645] New: Mismatched include guards in gdb/arch/csky.h

[Bug gdb/31645] New: Mismatched include guards in gdb/arch/csky.h

[godlygeek at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31645

            Bug ID: 31645
           Summary: Mismatched include guards in gdb/arch/csky.h
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: godlygeek at gmail dot com
  Target Milestone: ---

Created attachment 15465
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15465&action=edit
Patch to fix include guard typo

`gdb/arch/csky.h` checks for duplicate inclusion by checking whether
`ARCH_CSKY_H` has already been defined, but defines `ARCH_CSKy_H` when first
included (with a lowercase `y` instead of uppercase).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31645] Mismatched include guards in gdb/arch/csky.h

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31645

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Thanks.  We don't really review patches in bugzilla;
could you git send-email it to the patch list?
https://sourceware.org/gdb/wiki/ContributionChecklist

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31645] Mismatched include guards in gdb/arch/csky.h

[godlygeek at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31645

--- Comment #2 from Matt Wozniski <godlygeek at gmail dot com> ---
If you won't accept patches on bugzilla, it should probably not suggest "Add an
attachment (proposed patch, testcase, etc.)" when filing a bug rpeort.

I've emailed the patch to the mailing list, though setting up `git send-email`
to work with gmail took me around 20 minutes to figure out, which seems pretty
excessive for a 1 character diff. Refusing to look at patches on the bug
tracker seems pretty hostile to drive-by contributions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31645] Mismatched include guards in gdb/arch/csky.h

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31645

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1992aeb29ee6f14b0db3801538363ca606a9e687

commit 1992aeb29ee6f14b0db3801538363ca606a9e687
Author: Matt Wozniski <godlygeek@gmail.com>
Date:   Tue Apr 16 17:20:20 2024 -0400

    Fix include guard typo

    Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31645
    Approved-By: Tom Tromey <tom@tromey.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31645] Mismatched include guards in gdb/arch/csky.h

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31645

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |15.1

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Matt Wozniski from comment #2)
> If you won't accept patches on bugzilla, it should probably not suggest "Add
> an attachment (proposed patch, testcase, etc.)" when filing a bug rpeort.
> 
> I've emailed the patch to the mailing list, though setting up `git
> send-email` to work with gmail took me around 20 minutes to figure out,
> which seems pretty excessive for a 1 character diff. Refusing to look at
> patches on the bug tracker seems pretty hostile to drive-by contributions.

Yeah, but it's also a cultural thing that's hard to change.
Thank you for the patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.