public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/31700] New: Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc
@ 2024-05-04  0:34 thiago.bauermann at linaro dot org
  2024-05-04  0:35 ` [Bug testsuite/31700] " thiago.bauermann at linaro dot org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: thiago.bauermann at linaro dot org @ 2024-05-04  0:34 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=31700

            Bug ID: 31700
           Summary: Recent change in gdb.base/relativedebug.exp disables
                    it in systems with statically linked libc
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: thiago.bauermann at linaro dot org
  Target Milestone: ---

Pedro pointed out¹ that commit f5ef12c3f1af ("gdb/testsuite: Add
libc_has_debug_info require helper") "[will] disable the testcase on systems
that link with their libc statically (even if has debug info), or systems that
name their libc something else."

¹
https://inbox.sourceware.org/gdb-patches/b0409c48-7f9c-4430-91d9-dc7cfa86a9c7@palves.net/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug testsuite/31700] Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc
  2024-05-04  0:34 [Bug testsuite/31700] New: Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc thiago.bauermann at linaro dot org
@ 2024-05-04  0:35 ` thiago.bauermann at linaro dot org
  2024-05-04  1:11 ` brobecker at gnat dot com
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: thiago.bauermann at linaro dot org @ 2024-05-04  0:35 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=31700

--- Comment #1 from Thiago Jung Bauermann <thiago.bauermann at linaro dot org> ---
I posted a patch restoring the original test behaviour here:

https://inbox.sourceware.org/gdb-patches/20240430015325.89780-1-thiago.bauermann@linaro.org/

Another alternative would be to revert commit f5ef12c3f1af. I would be ok with
that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug testsuite/31700] Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc
  2024-05-04  0:34 [Bug testsuite/31700] New: Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc thiago.bauermann at linaro dot org
  2024-05-04  0:35 ` [Bug testsuite/31700] " thiago.bauermann at linaro dot org
@ 2024-05-04  1:11 ` brobecker at gnat dot com
  2024-05-23  3:58 ` cvs-commit at gcc dot gnu.org
  2024-05-23 14:06 ` tromey at sourceware dot org
  3 siblings, 0 replies; 5+ messages in thread
From: brobecker at gnat dot com @ 2024-05-04  1:11 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=31700

Joel Brobecker <brobecker at gnat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.1
                 CC|                            |brobecker at gnat dot com

--- Comment #2 from Joel Brobecker <brobecker at gnat dot com> ---
I'm setting the 15.1 target milestone, because this one is a regression that
seems to be in good tracks to be fixed quickly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug testsuite/31700] Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc
  2024-05-04  0:34 [Bug testsuite/31700] New: Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc thiago.bauermann at linaro dot org
  2024-05-04  0:35 ` [Bug testsuite/31700] " thiago.bauermann at linaro dot org
  2024-05-04  1:11 ` brobecker at gnat dot com
@ 2024-05-23  3:58 ` cvs-commit at gcc dot gnu.org
  2024-05-23 14:06 ` tromey at sourceware dot org
  3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-05-23  3:58 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=31700

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thiago Bauermann
<bauermann@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=100318bcfda243f04cda3c29e8873c5710a1688a

commit 100318bcfda243f04cda3c29e8873c5710a1688a
Author: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Date:   Mon Apr 29 22:53:25 2024 -0300

    gdb/testsuite: Restore libc_has_debug_info's less strict behaviour

    The code that was factored out from gdb.base/relativedebug.exp assumed that
    libc has debug info and only determined that it doesn't if it saw a
specific
    message from GDB to that effect.  In the process of factoring it into a
    require predicate, I made it stricter by trying to make a specific
    determination of whether or not debug info is available.

    Pedro noticed that "It'll disable the testcase on systems that link with
    their libc statically (even if has debug info), or systems that name their
    libc something else."  Which is something I hadn't considered.

    This patch returns libc_has_debug_info to the original behaviour.

    Also, remove a verbose message that is redundant with the $message
    variable.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31700
    Approved-By: Tom Tromey <tom@tromey.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug testsuite/31700] Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc
  2024-05-04  0:34 [Bug testsuite/31700] New: Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc thiago.bauermann at linaro dot org
                   ` (2 preceding siblings ...)
  2024-05-23  3:58 ` cvs-commit at gcc dot gnu.org
@ 2024-05-23 14:06 ` tromey at sourceware dot org
  3 siblings, 0 replies; 5+ messages in thread
From: tromey at sourceware dot org @ 2024-05-23 14:06 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=31700

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
IIUC this is fixed now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-05-23 14:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-04  0:34 [Bug testsuite/31700] New: Recent change in gdb.base/relativedebug.exp disables it in systems with statically linked libc thiago.bauermann at linaro dot org
2024-05-04  0:35 ` [Bug testsuite/31700] " thiago.bauermann at linaro dot org
2024-05-04  1:11 ` brobecker at gnat dot com
2024-05-23  3:58 ` cvs-commit at gcc dot gnu.org
2024-05-23 14:06 ` tromey at sourceware dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).