[Bug cli/8798] Don't prompt for continue if logging and logging redirection is on

[Bug cli/8798] Don't prompt for continue if logging and logging redirection is on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=8798

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I stumbled across this today.

Here's a simple way to reproduce:

define p5
printf "1\n2\n3\n4\n5\n6\n7\n"
end
set height 5
set logging overwrite on
set logging redirect on
set logging file /tmp/LOG
set logging on
p5

In redirect mode, the logger should probably temporarily disable
the pager.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/8798] Don't prompt for continue if logging and logging redirection is on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=8798

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
I have a patch.  It looked pretty clean to have a can_page
method on ui_file, then to change the pager to check this.
The key thing was to have the default be false, and then
have stdio_file check again stdout.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/8798] Don't prompt for continue if logging and logging redirection is on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=8798

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2021-December/184648.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/8798] Don't prompt for continue if logging and logging redirection is on

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=8798

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=84b334970bb5892a1f50a3d8e9a569263a502224

commit 84b334970bb5892a1f50a3d8e9a569263a502224
Author: Tom Tromey <tom@tromey.com>
Date:   Mon Dec 27 10:53:16 2021 -0700

    Fix logging redirection bug with pager

    I noticed yesterday that if gdb output is redirected to a file, the
    pager will still be active.  This is irritating, because the output
    isn't actually visible -- just the pager prompt.  Looking in bugzilla,
    I found that this had been filed 17 years ago, as PR cli/8798.

    This patch fixes the bug.  It changes the pagination code to query the
    particular ui-file to see if paging is allowable.  The ui-file
    implementations are changed so that only the stdout implementation and
    a tee (where one sub-file is stdout) can page.

    Regression tested on x86-64 Fedora 34.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=8798

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/8798] Don't prompt for continue if logging and logging redirection is on

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=8798

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |12.1
         Resolution|---                         |FIXED

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.