Questions about code reviews and static analysis tools for TU Delft research

Questions about code reviews and static analysis tools for TU Delft research

[Radjino Bholanath]

Hi everyone,

I'm doing research on code reviews and static analysis tools at the SERG group (http://swerl.tudelft.nl/bin/view/Main/WebHome) of the Delft University of Technology. Currently, we want to give an overview of the usage of code review and static analysis tools in open source projects. Therefore, I would be very happy to know a little bit more about how code reviews are used in GDB and if (and maybe how) static analysis tools are used. I have a couple of questions for anyone willing to answer:

1. Do all developers (contributors and core developers) have to submit a code review for every change? I’m asking because many projects only review changes made by contributors.

2. Which code review tools are used?

3. Are static analyzers used? If they are used:
  a. Is passing the checks of the static analyzers necessary for a change to be accepted?
  b. Which static analyzers are used?

Thanks,

Radjino

Re: Questions about code reviews and static analysis tools for TU Delft research

[Joel Brobecker]

> 1. Do all developers (contributors and core developers) have to submit
> a code review for every change? I’m asking because many projects only
> review changes made by contributors.

Changes considered obvious do not need to be reviewed.

Nominated maintainers have the right to push a change without prior
review, but most submit the change and give others some time to comment
on it before doing the push.

In all cases, whether it be an immediate push without review or not,
the patch is always posted in the gdb-patches mailing-list.

> 2. Which code review tools are used?

There is no code-review tool used. Patches are reviewed by answer
the email that was used to submit the patch.

There is a patch tracking tool used by some maintainers.

> 3. Are static analyzers used? If they are used:
>   a. Is passing the checks of the static analyzers necessary for a change to be accepted?
>   b. Which static analyzers are used?

No static analysis tool used by the project per se. We had some
reports from the past sent to us; and, when appropriate, we made
some adjustments based on those reports.

-- 
Joel

RE: Questions about code reviews and static analysis tools for TU Delft research

[Radjino Bholanath]

Thanks for answering Joel, I appreciate it.

- Radjino
________________________________________
From: Joel Brobecker [brobecker@adacore.com]
Sent: Wednesday, February 25, 2015 8:57 AM
To: Radjino Bholanath
Cc: gdb@sourceware.org
Subject: Re: Questions about code reviews and static analysis tools for TU Delft research

Changes considered obvious do not need to be reviewed.

...

No static analysis tool used by the project per se. We had some
reports from the past sent to us; and, when appropriate, we made
some adjustments based on those reports.

--
Joel