* Re: Ugly little hack for snapshot problem
@ 2003-08-15 21:37 Michael Elizabeth Chastain
0 siblings, 0 replies; 3+ messages in thread
From: Michael Elizabeth Chastain @ 2003-08-15 21:37 UTC (permalink / raw)
To: drow; +Cc: ac131313, gdb
> GDB and binutils own src-release.
Well then. I'm gonna patch the top level MAINTAINERS file in
accordance with its very liberal commit policy:
Please feel free to add, edit, delete this file.
Please do not make ChangeLog entries.
Patch for top-level MAINTAINERS coming up.
Michael C
^ permalink raw reply [flat|nested] 3+ messages in thread
* Ugly little hack for snapshot problem
@ 2003-08-15 21:20 Michael Elizabeth Chastain
2003-08-15 21:28 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Michael Elizabeth Chastain @ 2003-08-15 21:20 UTC (permalink / raw)
To: ac131313, gdb
First the problem:
http://sources.redhat.com/gdb/bugs/708
Can't build 5.3 branch (and probably trunk).
Here's a synopsis of the analysis:
src-release walks the tree and configures all the subdirs and
makes info files in them.
src-release walks the tree and does 'distclean' to remove
config.status and other files.
The problem is that src/dejagnu/Makefile.am is coded in an unusual
way. src/dejagnu has subdirectories, and the subdirectories are
configured normally, but Makefile.am does *not* list all the
subdirectories!
... So 'configure' configures in dejagnu/example/calc, but
'make distclean' never goes there, and the tarball gets some
extra crap in it, specifically dejagnu/example/calc/config.status.
Then the user tries to build from the tarball and gets an error that
dejagnu/example/calc has already been configured and the build chokes.
In the past, I've had two ideas for fixing this. One is to make a
simple local modification in sourceware dejagnu. In fact, Andrew C did
this before, and it worked for two years, and then Nick C imported a new
dejagnu from Savannah and our local change got erased.
The second idea is to fix dejagnu upstream and then import a new
dejagnu. I started on this but never finished it.
Now I've got a third idea. It's simple:
src-release walks the tree and configures all the subdirs ...
src-release walks the tree and makes 'distclean ...'
+ src-release calls 'rm -f dejagnu/example/calc/config.status'
Advantages:
It's very easily seen to be correct.
It's very easily seen not to touch anything except src-release.
It patches src-release, not dejagnu, so it doesn't get wiped
by a dejagnu import.
I can stick a comment in there so that if dejagnu evers gets fixed,
and we import a new dejagnu, the kludge can go away soon after that.
Disadvantages:
It's ugly.
The top-level MAINTAINERS file does not say who owns 'src-release'.
Like the cliche says: "if it's stupid, and it works, it isn't stupid."
How about it?
Michael C
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Ugly little hack for snapshot problem
2003-08-15 21:20 Michael Elizabeth Chastain
@ 2003-08-15 21:28 ` Daniel Jacobowitz
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2003-08-15 21:28 UTC (permalink / raw)
To: Michael Elizabeth Chastain; +Cc: ac131313, gdb
On Fri, Aug 15, 2003 at 05:20:31PM -0400, Michael Elizabeth Chastain wrote:
> Now I've got a third idea. It's simple:
>
> src-release walks the tree and configures all the subdirs ...
> src-release walks the tree and makes 'distclean ...'
> + src-release calls 'rm -f dejagnu/example/calc/config.status'
>
> Advantages:
>
> It's very easily seen to be correct.
> It's very easily seen not to touch anything except src-release.
> It patches src-release, not dejagnu, so it doesn't get wiped
> by a dejagnu import.
> I can stick a comment in there so that if dejagnu evers gets fixed,
> and we import a new dejagnu, the kludge can go away soon after that.
Sounds fine. Could use it for intl too.
> Disadvantages:
>
> It's ugly.
> The top-level MAINTAINERS file does not say who owns 'src-release'.
>
> Like the cliche says: "if it's stupid, and it works, it isn't stupid."
>
> How about it?
GDB and binutils own src-release. As far as I'm concerned, it's
reasonable; let's see what others say.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-08-15 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-15 21:37 Ugly little hack for snapshot problem Michael Elizabeth Chastain
-- strict thread matches above, loose matches on Subject: below --
2003-08-15 21:20 Michael Elizabeth Chastain
2003-08-15 21:28 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).