* NAT_FILE always required?
@ 2004-09-26 19:00 Mark Kettenis
2004-09-27 14:17 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2004-09-26 19:00 UTC (permalink / raw)
To: gdb
It looks as if I'm ready to get rid of NAT_FILE for *BSD/amd64.
Except there's this funny bit of code in configure.in:
if test "${nativefile}" = ""; then
< Makefile \
sed -e '/^NATDEPFILES[[ ]]*=.*\\$/,/[[^\\]]$/s/^/# /' \
-e '/^NATDEPFILES[[ ]]*=/s/^/# /' \
| sed -e '/^\(NATDEPFILES[[ ]]*[[+]]=[[ ]]*\)/s//# \1/' \
> Makefile.tem
mv -f Makefile.tem Makefile
fi
This code comments out the definition of NATDEPFILES if NAT_FILE isn't
there. What's the purpose of this code? Can anybody see a reason why
this code can't be deleted?
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: NAT_FILE always required?
2004-09-26 19:00 NAT_FILE always required? Mark Kettenis
@ 2004-09-27 14:17 ` Andrew Cagney
2004-09-27 17:15 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2004-09-27 14:17 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb
> It looks as if I'm ready to get rid of NAT_FILE for *BSD/amd64.
> Except there's this funny bit of code in configure.in:
>
> if test "${nativefile}" = ""; then
> < Makefile \
> sed -e '/^NATDEPFILES[[ ]]*=.*\\$/,/[[^\\]]$/s/^/# /' \
> -e '/^NATDEPFILES[[ ]]*=/s/^/# /' \
> | sed -e '/^\(NATDEPFILES[[ ]]*[[+]]=[[ ]]*\)/s//# \1/' \
> > Makefile.tem
> mv -f Makefile.tem Makefile
> fi
>
> This code comments out the definition of NATDEPFILES if NAT_FILE isn't
> there. What's the purpose of this code?
As you imply -> it was assuming that nativefile=="" implied no native
support. Grubbing around, there was code like:
if host==target
native=`sed magic ...`
so native= for cross targets was empty and the above would have disabled
native support. The predicate was moved between 5.2 and 5.3 and my
fuzzy memory is because:
- it never really worked
- (possibly) it was realized that "one day soon" GDB would support both
native and true cross debuggers in a single binary
> Can anybody see a reason why
> this code can't be deleted?
As far as I can tell, ever since 5.3 nativefile!="" has held, and hence
the code was dead.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: NAT_FILE always required?
2004-09-27 14:17 ` Andrew Cagney
@ 2004-09-27 17:15 ` Mark Kettenis
0 siblings, 0 replies; 3+ messages in thread
From: Mark Kettenis @ 2004-09-27 17:15 UTC (permalink / raw)
To: cagney; +Cc: gdb
Date: Mon, 27 Sep 2004 10:16:27 -0400
From: Andrew Cagney <cagney@gnu.org>
> Can anybody see a reason why
> this code can't be deleted?
As far as I can tell, ever since 5.3 nativefile!="" has held, and hence
the code was dead.
Great! I'll rip it out.
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-27 17:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-26 19:00 NAT_FILE always required? Mark Kettenis
2004-09-27 14:17 ` Andrew Cagney
2004-09-27 17:15 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).