* [PATCH] arm: GDB disassembles ARM VFP 'fadds' instruction wrongly.
@ 2005-07-06 23:16 Khem Raj
2005-07-06 23:30 ` Daniel Jacobowitz
0 siblings, 1 reply; 2+ messages in thread
From: Khem Raj @ 2005-07-06 23:16 UTC (permalink / raw)
To: 'gdb@sources.redhat.com'
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
Hello,
Like binutils, the following patch fixes the opcode disassembly for
'fadds' ARM VFP instruction.
currently
fadds s14, s14, s15
will be disassembled as
fadds s14, s14, s14 by gdb.
Is it ok ?
Thanks
-Khem
Changelog Entry:
2005-07-06 Khem Raj <kraj@mvista.com>
* arm-dis.c (opcode32 arm_opcodes): Fix ARM VFP fadds instruction
disassembly pattern.
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 893 bytes --]
? diff
Index: arm-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/arm-dis.c,v
retrieving revision 1.48
diff -u -p -r1.48 arm-dis.c
--- arm-dis.c 8 Jun 2005 17:27:40 -0000 1.48
+++ arm-dis.c 6 Jul 2005 23:12:22 -0000
@@ -460,7 +460,7 @@ static const struct opcode32 arm_opcodes
{FPU_VFP_EXT_V1, 0x0eb00bc0, 0x0fff0ff0, "fabsd%c\t%1z, %0z"},
{FPU_VFP_EXT_V1xD, 0x0eb00ac0, 0x0fbf0fd0, "fabss%c\t%1y, %0y"},
{FPU_VFP_EXT_V1, 0x0e300b00, 0x0ff00ff0, "faddd%c\t%1z, %2z, %0z"},
- {FPU_VFP_EXT_V1xD, 0x0e300a00, 0x0fb00f50, "fadds%c\t%1y, %2y, %1y"},
+ {FPU_VFP_EXT_V1xD, 0x0e300a00, 0x0fb00f50, "fadds%c\t%1y, %2y, %0y"},
{FPU_VFP_EXT_V1, 0x0eb40b40, 0x0fff0f70, "fcmp%7'ed%c\t%1z, %0z"},
{FPU_VFP_EXT_V1xD, 0x0eb40a40, 0x0fbf0f50, "fcmp%7'es%c\t%1y, %0y"},
{FPU_VFP_EXT_V1, 0x0eb50b40, 0x0fff0f70, "fcmp%7'ezd%c\t%1z"},
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: GDB disassembles ARM VFP 'fadds' instruction wrongly.
2005-07-06 23:16 [PATCH] arm: GDB disassembles ARM VFP 'fadds' instruction wrongly Khem Raj
@ 2005-07-06 23:30 ` Daniel Jacobowitz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2005-07-06 23:30 UTC (permalink / raw)
To: Khem Raj; +Cc: 'gdb@sources.redhat.com'
On Wed, Jul 06, 2005 at 04:16:51PM -0700, Khem Raj wrote:
> Hello,
>
> Like binutils, the following patch fixes the opcode disassembly for
> 'fadds' ARM VFP instruction.
Binutils and GDB share a CVS repository; you don't need to send the
patch separately for GDB.
--
Daniel Jacobowitz
CodeSourcery, LLC
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-06 23:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-06 23:16 [PATCH] arm: GDB disassembles ARM VFP 'fadds' instruction wrongly Khem Raj
2005-07-06 23:30 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).