public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Michael Snyder <msnyder@specifix.com>
Cc: gdb@sources.redhat.com,  Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: Questionable breakpoint stepping code
Date: Tue, 27 Nov 2007 13:50:00 -0000	[thread overview]
Message-ID: <200711271650.16182.vladimir@codesourcery.com> (raw)
In-Reply-To: <1196104576.2501.55.camel@localhost.localdomain>


> On Mon, 2007-11-26 at 22:16 +0300, Vladimir Prus wrote:
> 
> > > As for your last question, no, I don't believe we approve
> > > of ifdefs...
> > 
> > Well, the question, then is -- how do we make this code work
> > correctly even if the instruction at PC is not 4 bytes in size?
> > Calling disassembler seems a plausible approach.

On Monday 26 November 2007 22:16:16 Michael Snyder wrote:

> Good suggestion.

On Monday 26 November 2007 22:24:07 Daniel Jacobowitz wrote:

> Don't Do It.  Just call error, I suggest.  Skipping an instruction
> can lead to bizarre failures later.

Ok, I'm now not quite sure what to do. I personally prefer calling 'error' --
is this going to be acceptable?

- Volodya


  reply	other threads:[~2007-11-27 13:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-23 14:06 Vladimir Prus
2007-11-26 19:01 ` Michael Snyder
2007-11-26 19:16   ` Vladimir Prus
2007-11-26 19:24     ` Daniel Jacobowitz
2007-11-26 19:28     ` Michael Snyder
2007-11-27 13:50       ` Vladimir Prus [this message]
2007-11-27 13:54         ` Daniel Jacobowitz
2007-11-27 19:33           ` Joel Brobecker
2007-11-29 12:35             ` Vladimir Prus
2007-11-30  1:14               ` Joel Brobecker
2007-11-30 11:48                 ` Vladimir Prus
2007-12-13 16:09                   ` Vladimir Prus
2008-01-17  1:13                     ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711271650.16182.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=dan@codesourcery.com \
    --cc=gdb@sources.redhat.com \
    --cc=msnyder@specifix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).