From: Jim Blandy <jimb@codesourcery.com>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: Michael Snyder <msnyder@specifix.com>, gdb@sources.redhat.com
Subject: Re: Questionable breakpoint stepping code
Date: Thu, 17 Jan 2008 01:13:00 -0000 [thread overview]
Message-ID: <m33asx1cge.fsf@codesourcery.com> (raw)
In-Reply-To: <E1J2qbz-00077Y-3r@zigzag.lvk.cs.msu.su> (Vladimir Prus's message of "Thu, 13 Dec 2007 19:08:34 +0300")
Vladimir Prus <ghost at cs.msu.su> writes:
> I wonder if you've missed the below email. Can you
> tell what you think?
Hi, Vlad. This change looks fine to me; please commit.
>
> Thanks,
> Volodya
>
>> On Friday 30 November 2007 04:14:13 Joel Brobecker wrote:
>>> > > I have been away for a week and I still a bit overwhelmed by my email
>>> > > backlog that caused me to miss the patch. But if Volodya sends me the
>>> > > patch again, I'll give it a whirl.
>>> >
>>> > Thanks Joel!
>>> > Here's the patch.
>>>
>>> Thanks. I don't know why, but somehow, the patch didn't apply cleanly
>>> to HEAD, so I applied it manually. The results were identical after
>>> applying and I double-checked that the error never triggered.
>>
>> Thanks. Michael, do you have any objections to me checking that
>> patch in (included before for convenience).
>>
>> - Volodya
>>
>>
>> * infrun.c (handle_inferior_event): If
>> we failed to remove breakpoints, error,
>> don't try to increment PC by hand.
>> ---
>> gdb/infrun.c | 19 +------------------
>> 1 files changed, 1 insertions(+), 18 deletions(-)
>>
>> diff --git a/gdb/infrun.c b/gdb/infrun.c
>> index ad1de6b..b92d0de 100644
>> --- a/gdb/infrun.c
>> +++ b/gdb/infrun.c
>> @@ -1745,24 +1745,7 @@ handle_inferior_event (struct
>> execution_control_state *ecs)
>> process until the child exits (well, okay, not
>> then either :-) or execs. */
>> if (remove_status != 0)
>> - {
>> - /* FIXME! This is obviously non-portable! */
>> - write_pc_pid (stop_pc + 4, ecs->ptid);
>> - /* We need to restart all the threads now,
>> - * unles we're running in scheduler-locked mode.
>> - * Use currently_stepping to determine whether to
>> - * step or continue.
>> - */
>> - /* FIXME MVS: is there any reason not to call resume()? */
>> - if (scheduler_mode == schedlock_on)
>> - target_resume (ecs->ptid,
>> - currently_stepping (ecs), TARGET_SIGNAL_0);
>> - else
>> - target_resume (RESUME_ALL,
>> - currently_stepping (ecs), TARGET_SIGNAL_0);
>> - prepare_to_wait (ecs);
>> - return;
>> - }
>> + error (_("Cannot step over breakpoint hit in wrong thread"));
>> else
>> { /* Single step */
>> if (!ptid_equal (inferior_ptid, ecs->ptid))
prev parent reply other threads:[~2008-01-17 1:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 14:06 Vladimir Prus
2007-11-26 19:01 ` Michael Snyder
2007-11-26 19:16 ` Vladimir Prus
2007-11-26 19:24 ` Daniel Jacobowitz
2007-11-26 19:28 ` Michael Snyder
2007-11-27 13:50 ` Vladimir Prus
2007-11-27 13:54 ` Daniel Jacobowitz
2007-11-27 19:33 ` Joel Brobecker
2007-11-29 12:35 ` Vladimir Prus
2007-11-30 1:14 ` Joel Brobecker
2007-11-30 11:48 ` Vladimir Prus
2007-12-13 16:09 ` Vladimir Prus
2008-01-17 1:13 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33asx1cge.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=msnyder@specifix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).