Re: sourceware.org gitweb gives some wrong results

Re: sourceware.org gitweb gives some wrong results

[Jim Meyering]

Jan Kratochvil wrote:
> Hi Jim,
>
> http://sourceware.org/git/?p=gdb.git;a=summary
> -> head master
> http://sourceware.org/git/?p=gdb.git;a=tree;h=refs/heads/master;hb=master
> -> gdb/
> http://sourceware.org/git/?p=gdb.git;a=tree;f=gdb;h=b2bc1d8ff2d63dad7f98166d07ea4851a8e33b9e;hb=master
> -> NEWS blob
> http://sourceware.org/git/?p=gdb.git;a=blob;f=gdb/NEWS;h=696de32204d3cb449595343c41c073266ab79747;hb=master
>  = OK, "*** Changes since GDB 7.4"
> -> NEWS raw
> http://sourceware.org/git/?p=gdb.git;a=blob_plain;f=gdb/NEWS;hb=master
>  = wrong, "*** Changes since GDB 6.8"
>    ^^^^^
>    !!!!!
>
> in my copy it works fine:
> http://git.jankratochvil.net/?p=gdb.git;a=blob_plain;f=gdb/NEWS;hb=master
>  = OK, "*** Changes since GDB 7.4"
>
> I wanted to give a reference to mail and I had to use my gitweb for it.

Hi Jan,

[Cc'ing the list, in the unlikely event that anyone is using cvs/master:
 it has not been modified since Dec 2008]

Part of the problem is that the reference, "master", is ambiguous:

    sourceware$ git show-ref master
    22ff147254a15c977ca7eccc83567ba74587b8a3 refs/heads/cvs/master
    4959fdc11a310d335e57a69f597b64e1c155cefa refs/heads/hjl/x32/master
    f4a023ee8a2015d98fd3aeb50a5ccde2f201ec46 refs/heads/master

What you're getting is the first one: refs/heads/cvs/master:

    $ git show refs/heads/cvs/master:gdb/NEWS |sed 4q|tail -1
    *** Changes since GDB 6.8

What you want is the last one:

    $ git show refs/heads/master:gdb/NEWS |sed 4q|tail -1
    *** Changes since GDB 7.4

One way to fix this is to rename cvs/master and hjl/x32/master
so that there is no longer any ambiguity.

It's not impossible that this would be fixed by upgrading sourceware.org's
gitweb (currently at 1.7.3.4, it seems; while the latest is 1.7.9)
You can manually specify the full ref spec, too, but
you shouldn't have to resort to that:

  http://sourceware.org/git/?p=gdb.git;a=blob_plain;f=gdb/NEWS;hb=refs/heads/master

If you want to go for the rename, HJ can rename his branch
however he sees fit, but I'd have to rename the cvs/master one,
since it's also in the cvs-to-git source mirror, while HJ's branch
is present only in the public destination mirror.  I'll have to
rename cvs/master both in the private source, and in the public dest.

I propose to do both renames, like this:

    git branch -m cvs/master cvs/old-master
    git branch -m hjl/x32/master hjl/x32-master

Re: sourceware.org gitweb gives some wrong results

[Andreas Schwab]

Jim Meyering <jim@meyering.net> writes:

> Part of the problem is that the reference, "master", is ambiguous:

No, it isn't.  master can never refer to refs/heads/cvs/master.  See
git-rev-parse(1) for the precise rules for refname lookup.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: sourceware.org gitweb gives some wrong results

[Jan Kratochvil]

On Sat, 24 Mar 2012 12:26:10 +0100, Andreas Schwab wrote:
> Jim Meyering <jim@meyering.net> writes:
> 
> > Part of the problem is that the reference, "master", is ambiguous:
> 
> No, it isn't.  master can never refer to refs/heads/cvs/master.  See
> git-rev-parse(1) for the precise rules for refname lookup.

It is a gitweb bug.  I have verified it on latest gitweb and filed:
	https://code.google.com/p/git-core/issues/detail?id=10

Till it gets fixed the workaround would be simple.


Regards,
Jan