Problematic .gdb_index warning regexps in testsuite

Problematic .gdb_index warning regexps in testsuite

[Doug Evans]

Hi.

While grepping for gdb_index in the testsuite I found this:

gdb.base/annota1.exp:    -re "\r\n\032\032post-prompt\r\nStarting program: $binexp \(\r\nwarning: Skipping \[^\r\n\]+ .gdb_index section in \[^\r\n\]+\)?\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)+\r\n\r\n\032\032starting\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)*\r\n\r\n\032\032breakpoint 1\r\n\r\nBreakpoint 1, \r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n.*annota1.c\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n$main_line\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source.*$srcfile:$main_line:.*:beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped.*$gdb_prompt$" {
gdb.base/async-shell.exp:set gdbindex_warning_re "warning: Skipping \[^\r\n\]+ \\.gdb_index section \[^\r\n\]*"
lib/mi-support.exp:set gdbindex_warning_re "&\"warning: Skipping \[^\r\n\]+ \.gdb_index section in \[^\"\]+\"\r\n"

I think we don't want to go down this path.
This will just proliferate, and make tests unnecessarily bulkier
(harder to maintain) than they should be.

I don't have a patch.
Just thought I'd point it out.

Re: Problematic .gdb_index warning regexps in testsuite

[Jan Kratochvil]

On Thu, 19 Apr 2012 17:11:45 +0200, Doug Evans wrote:
> I think we don't want to go down this path.
> This will just proliferate, and make tests unnecessarily bulkier
> (harder to maintain) than they should be.

This would make FSF GDB HEAD testsuite incompatible with existing systems
featuring (older) .gdb_index, such as RHEL-6.y/CentOS-6.y/ScientificLinux-6.y.
I believe it is enough systems to consider it somehow with FSF GDB HEAD.

Sure there could be also made some lib/gdb.exp:
	set warning obsolete gdb-index off
which could also be unified with renaming of current uncommited
	set auto-load local-gdbinit-warning off
	->
	set warning obsolete local-gdbinit off
or something like that.


Thanks,
Jan

Re: Problematic .gdb_index warning regexps in testsuite

[Jan Kratochvil]

On Fri, 20 Apr 2012 12:11:59 +0200, Jan Kratochvil wrote:
> This would make FSF GDB HEAD testsuite incompatible with existing systems
> featuring (older) .gdb_index, such as RHEL-6.y/CentOS-6.y/ScientificLinux-6.y.

Excluding ScientificLinux-6.2 , they do not seem to use .gdb_index like
RHEL-6.2 does.


Jan

Re: Problematic .gdb_index warning regexps in testsuite

[Gary Benson]

On Thu, 19 Apr 2012 17:11:45 +0200, Doug Evans wrote:
> I think we don't want to go down this path.  This will just
> proliferate, and make tests unnecessarily bulkier (harder to
> maintain) than they should be.

It wasn't very nice, I agree.

Jan Kratochvil wrote:
> Sure there could be also made some lib/gdb.exp:
> 	set warning obsolete gdb-index off
> which could also be unified with renaming of current uncommited
> 	set auto-load local-gdbinit-warning off
> 	->
> 	set warning obsolete local-gdbinit off
> or something like that.

I can make a patch to add a "set warning obsolete gdb-index off" if
you like.  Just let me know...

Cheers,
Gary

-- 
http://gbenson.net/