From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, gdb@sourceware.org, joel@rtems.org
Subject: Re: [PATCH] sim: mips/ppc/riscv: re-add AC_CANONICAL_SYSTEM [PR sim/29439]
Date: Fri, 3 Mar 2023 22:27:58 +0100 [thread overview]
Message-ID: <20230303212758.jeukghx7kmxhn6cx@lug-owl.de> (raw)
In-Reply-To: <20221023171147.12371-1-vapier@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 3022 bytes --]
On Sun, 2022-10-23 22:56:47 +0545, Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> wrote:
> These configure scripts check $target and change behavior. They
> shouldn't be doing that, but until we can rework the sim to change
> behavior based on the input ELF, restore AC_CANONICAL_SYSTEM to
> these so that $target is correctly populated.
>
> This was lost in the d3562f83a7b8a1ae6e333cd5561419d3da18fcb4
> ("sim: unify toolchain probing logic") refactor as the logic was
> hoisted up to the common code. But the fact the vars weren't
> passed down to the sub-configure scripts was missed.
>
> Bug: https://sourceware.org/PR29439
This fix seems to have a side effect:
.../configure --prefix=/tmp/gdb-mipsisa64sb1-elf --target=mipsisa64sb1-elf
make V=1 all-gdb
[...]
[all 2023-03-03 21:07:56] /usr/lib/gcc-snapshot/bin/gcc -DHAVE_CONFIG_H -DWITH_TARGET_WORD_BITSIZE=64 -DWITH_TARGET_WORD_MSB=63 -DWITH_FLOATING_POINT=HARD_FLOATING_POINT -DWITH_TARGET_FLOATING_POINT_BITSIZE=64 -DWITH_HW=1 -DHAVE_DV_SOCKSER -DDEFAULT_INLINE=0 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wno-error=maybe-uninitialized -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wpointer-sign -Wold-style-declaration -Werror -I. -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips -I../common -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../common -I../../include -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../include -I../../bfd -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../bfd -I../../opcodes -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../opcodes -I../.. -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../gnulib/import -I../../gnulib/import -DTARGET_ENABLE_FR=1 -DMIPS_MACH_DEFAULT=bfd_mach_mips_sb1 -g -O2 -c -o semantics.o -MT semantics.o -MMD -MP -MF .deps/semantics.Tpo semantics.c
[all 2023-03-03 21:07:56] sb1.igen: In function 'semantic_PABSDIFC_fmt_MDMX':
[all 2023-03-03 21:07:56] sb1.igen:178:21: error: unknown conversion type character 'v' in format [-Werror=format=]
[all 2023-03-03 21:07:56] 178 | check_mdmx (SD_, instruction_0);
[all 2023-03-03 21:07:56] | ^~~~~~~~~~~~~~
[all 2023-03-03 21:07:56] sb1.igen:178:21: error: format '%ld' expects argument of type 'long int', but argument 9 has type 'unsigned int' [-Werror=format=]
[all 2023-03-03 21:07:56] 178 | check_mdmx (SD_, instruction_0);
[all 2023-03-03 21:07:56] | ^~~~~~~~~~~~~~
[all 2023-03-03 21:07:56] sb1.igen:178:21: error: too many arguments for format [-Werror=format-extra-args]
[all 2023-03-03 21:08:05] cc1: all warnings being treated as errors
Sorry for taking so long to report it.
MfG, JBG
--
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-03-03 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 19:58 mips jmr3904 simulator broken Joel Sherrill
2022-10-23 17:11 ` [PATCH] sim: mips/ppc/riscv: re-add AC_CANONICAL_SYSTEM [PR sim/29439] Mike Frysinger
2023-03-03 21:27 ` Jan-Benedict Glaw [this message]
2023-10-15 10:37 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303212758.jeukghx7kmxhn6cx@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=joel@rtems.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).