public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,
	GDB <gdb@sourceware.org>
Subject: Re: exec-file-mismatch and native-gdbserver testing
Date: Fri, 08 May 2020 23:25:07 +0200	[thread overview]
Message-ID: <395e655e716ba5ebd90060cd467e438037f0eeb2.camel@skynet.be> (raw)
In-Reply-To: <DM5PR11MB169052BE856A0E9F5CB8D65ADEA20@DM5PR11MB1690.namprd11.prod.outlook.com>

On Fri, 2020-05-08 at 10:30 +0000, Metzger, Markus T wrote:
> Hello Philippe,
> 
> > > > In exec.c:validate_exec_file (), we check the filenames and, if they differ,
> > print
> > > a warning and re-load the symbol file.
> > > > Should validate_exec_file () check more than just the filenames?
> > > You mean: if the filenames differs, gdb could compare the contents of files and
> > if
> > > equal,
> > > not ask the question, considering there is no mismatch ?
> > 
> > It could compare build-ids, for example.
> > 
> > If there are no build-ids, it may fall back to comparing file contents as you
> > suggested.
> 
> Does that sound OK to you?
> 
> Thanks,
> Markus.
Hello Markus,

If build ids of 2 files are equal, then effectively, validate_exec_file
can consider the existing file is still ok.
I had however no time to dig on that, and see if such build ids can be
easily extracted/retrieved in validate_exec_file.

I had no time to dig more on that, sorry

Philippe



  reply	other threads:[~2020-05-08 21:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 14:02 Metzger, Markus T
2020-04-08 20:54 ` Philippe Waroquiers
2020-04-09  6:30   ` Metzger, Markus T
2020-05-08 10:30     ` Metzger, Markus T
2020-05-08 21:25       ` Philippe Waroquiers [this message]
2020-05-16 20:10 ` Pedro Alves
2020-05-17  5:24   ` Philippe Waroquiers
2020-05-17 17:47     ` Pedro Alves
2020-05-17 18:15       ` Philippe Waroquiers
2020-05-17 19:50         ` Pedro Alves
2020-05-17 20:11           ` Philippe Waroquiers
2020-05-17 21:19             ` Pedro Alves
2020-05-17 21:43               ` Philippe Waroquiers
2020-05-17 21:58                 ` Pedro Alves
2020-05-18 10:35                   ` Philippe Waroquiers
2020-05-18 14:05                     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=395e655e716ba5ebd90060cd467e438037f0eeb2.camel@skynet.be \
    --to=philippe.waroquiers@skynet.be \
    --cc=gdb@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).