public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: gdb@sources.redhat.com
Subject: Re: msym->info is wack
Date: Fri, 22 Aug 2003 14:51:00 -0000	[thread overview]
Message-ID: <3F462DF5.1020706@redhat.com> (raw)
In-Reply-To: <200308212330.h7LNUSua001161@duracef.shout.net>

> Hi Andrew,
> 
> mec> === ARM-TDEP.C, M68HC11-TDEP.C, MIPS-TDEP.C, SH-TDEP.C
> mec> 
> mec> These *-tdep.c files use msym->info as a place to store flag bits.
> mec> So, first, they are converting 'void *' to 'long' and back again.
> 
> ac> Begs the question, is the field needed -> can bfd provide the info directly?
> 
> I don't know.
> 
> My point of view is "incremental improvement from status quo".  From
> that point of view, changing "set flag bit in void *" to "set flag bit
> in minsym->tdep_flags" is an improvement.  It makes it easier, not
> harder, to change the tdep code later, if desired.

I can see that.  It's also important to take a look around at what is 
really happening.  Otherwize the small incremental improvements miss the 
mark.

Thinking about it, only 1 or 2 of those bazillion marked up minimal 
symbols will ever get used.  So why is the code even marking them up - 
leave it to run time.  It will make the minimal symbol smaller, it will 
speed up the load (although I suspect that on both counts the 
measurement isn't there).

Andrew


  reply	other threads:[~2003-08-22 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-21 23:30 Michael Elizabeth Chastain
2003-08-22 14:51 ` Andrew Cagney [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-08-20 23:28 Michael Elizabeth Chastain
2003-08-21 22:50 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F462DF5.1020706@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).