From: Stan Shebs <stanshebs@earthlink.net>
To: gdb@sourceware.org
Subject: Re: [Discussion] what about change the arguments of create_breakpoint to a struct?
Date: Fri, 03 Aug 2012 01:21:00 -0000 [thread overview]
Message-ID: <501B274D.3050605@earthlink.net> (raw)
In-Reply-To: <CANFwon1VCJY7v7Y6XJ8d8XebiYGO=e0vupxY2r6WRc6qDoi3wQ@mail.gmail.com>
On 8/1/12 10:39 PM, Hui Zhu wrote:
> Hi guys,
>
> create_breakpoint have 15 argument. I am not sure its number will
> increase or not. But this number is increasing recently.
> I thought it make code work about breakpoint not very easy.
>
> So I suggest change the arguments of create_breakpoint to a struct.
> What do you think about it?
>
Yeah, I've thought about that a couple times too. The arguments from
arg to wanted_type seem like a logical group, basically the
proto-breakpoint properties. It occurs to me that there is some
conceptual overlap with uploaded tracepoints and breakpoints, which also
work with a package of properties that may or may not correspond to an
actual breakpoint, so maybe we can cover all of those cases with a
generic breakpoint_properties struct that is raw data with no
constraints imposed on it.
And as Tom said, you'll need to coordinate with Keith.
Stan
stan@codesourcery.com
prev parent reply other threads:[~2012-08-03 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 5:39 Hui Zhu
2012-08-02 9:17 ` Pedro Alves
2012-08-02 21:00 ` Tom Tromey
2012-08-03 1:21 ` Stan Shebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501B274D.3050605@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).