public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom de Vries <tdevries@suse.de>
Cc: schwab@linux-m68k.org, brobecker@adacore.com, tom@tromey.com,
	bernd.edlinger@hotmail.de, gdb@sourceware.org
Subject: Re: [ANNOUNCEMENT] GDB 11 release branch created!
Date: Mon, 05 Jul 2021 15:33:03 +0300	[thread overview]
Message-ID: <83h7h9gcu8.fsf@gnu.org> (raw)
In-Reply-To: <78ca1c45-beb3-966f-e995-912bc1e115c1@suse.de> (message from Tom de Vries on Mon, 5 Jul 2021 12:36:00 +0200)

> Cc: gdb@sourceware.org
> From: Tom de Vries <tdevries@suse.de>
> Date: Mon, 5 Jul 2021 12:36:00 +0200
> 
> > The tarball contains the file gdb/doc/GDBvn.texi which is a generated
> > file depending on the configuration.  This breaks building with
> > --with-system-readline.
> 
> I managed to reproduce this.
> 
> The steps are:
> - download (or create using src-release.sh) a snapshot
> - unpack it, into say src
> - cd src; find -name "*.info*" | xargs rm -f
> - mkdir build; cd build ; ../src/configure --with-system-readline
> - cd build; make all-gdb
> 
> For make output, see below.
> 
> This can be fixed/worked around by doing:
> ...
> $ rm -f gdb/doc/GDBvn.texi
> ...
> as Andreas did here (
> https://build.opensuse.org/package/rdiff/home:AndreasSchwab/gdb?linkrev=base&rev=143
> ).
> 
> My guess is that this is a regression since:
> ...
> commit ab954e4a53cab8c33728e6708695abc1616c90b1
> Author: Bernd Edlinger <bernd.edlinger@hotmail.de>
> Date:   Wed Nov 25 18:52:49 2020 +0100
> 
>     Fix building gdb release from tar file without makeinfo
> 
>     Add GDBvn.texi and version.subst to the release tar file,
>     so the gdb.info does not need makeinfo.
> 
>     This avoids the need for makeinfo to be available.
> ...
> 
> Interestingly, there are previous commits related to GDBvn.texi where
> the submission emails show the same problem (
> https://sourceware.org/pipermail/gdb-patches/2011-January/078980.html ),
> and the final conclusion of that discussion (
> https://sourceware.org/pipermail/gdb-patches/2011-January/079001.html ) is:
> ...
> So, unless anyone else objects, removing GDBvn.texi from the
> distributed files is the solution.

But that would again bring the problem that inclusion was intended to
fix, no?

Wouldn't it be better to modify the configure script so that
READLINE_TEXI_INCFLAG always includes "-I ${READLINE_DIR}"?  Or did I
misunderstand the reason why makeinfo doesn't find the Readline
manual?

Thanks.

  reply	other threads:[~2021-07-05 12:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-03 17:52 Joel Brobecker
2021-07-04  9:06 ` Andreas Schwab
2021-07-05 10:36   ` Tom de Vries
2021-07-05 12:33     ` Eli Zaretskii [this message]
2021-07-05 13:36       ` Tom de Vries
2021-07-05 15:34         ` Eli Zaretskii
2021-07-06 14:58           ` Tom de Vries
2021-07-06 15:50             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h7h9gcu8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bernd.edlinger@hotmail.de \
    --cc=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).