public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom de Vries <tdevries@suse.de>
Cc: brobecker@adacore.com, tom@tromey.com, bernd.edlinger@hotmail.de,
	gdb@sourceware.org
Subject: Re: [ANNOUNCEMENT] GDB 11 release branch created!
Date: Tue, 06 Jul 2021 18:50:26 +0300	[thread overview]
Message-ID: <83h7h7fnlp.fsf@gnu.org> (raw)
In-Reply-To: <8731b5b6-814f-8559-d72e-b8c86e2ee6d7@suse.de> (message from Tom de Vries on Tue, 6 Jul 2021 16:58:28 +0200)

> Cc: brobecker@adacore.com, tom@tromey.com, bernd.edlinger@hotmail.de,
>  gdb@sourceware.org
> From: Tom de Vries <tdevries@suse.de>
> Date: Tue, 6 Jul 2021 16:58:28 +0200
> 
> > Therefore, I tried to propose a band-aid:
> > have the readline/readline/doc directory be _always_ on the makeinfo's
> > include path, so that if someone reconfigures GDB like in the
> > reproducer, they still get a successful build, albeit with a couple of
> > sections in the manual they don't need.
> 
> AFAIU, the problem is not that users get a couple of sections in the
> manual they don't need.  The problem is that the users get the incorrect
> version of a section of the manual.

I think this is a minor problem.  How different could be the Readline
we have in the tarball vs the one installed on the user's system?
Readline is a relatively stable package, so changes are likely minor.

> I did this:
> ...
> -  READLINE_TEXI_INCFLAG=
> +  READLINE_TEXI_INCFLAG='-I $(READLINE_DIR)'
> ...
> in src/gdb/configure and managed to finish the build.

So my recommendation is to go with this solution on the release
branch.  I will try to think about a cleaner fix on master.

> I'd say the easiest way to fix the problem is to revert the commit that
> introduced the problem.

I wouldn't recommend that.  In fact, I do have Texinfo installed, but
I nevertheless am always slightly annoyed by the fact that building
GDB always rebuilds the Info manual for some reason.  I hope that
commit solved this.

Joel, it's your call.

      reply	other threads:[~2021-07-06 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-03 17:52 Joel Brobecker
2021-07-04  9:06 ` Andreas Schwab
2021-07-05 10:36   ` Tom de Vries
2021-07-05 12:33     ` Eli Zaretskii
2021-07-05 13:36       ` Tom de Vries
2021-07-05 15:34         ` Eli Zaretskii
2021-07-06 14:58           ` Tom de Vries
2021-07-06 15:50             ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h7h7fnlp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bernd.edlinger@hotmail.de \
    --cc=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).