From: "Arsen Arsenović" <arsen@aarsen.me>
To: Enze Li <enze.li@hotmail.com>
Cc: Gdb <gdb@sourceware.org>
Subject: Re 2da39de "fbsd-nat: Pacify gcc with no functional changes"
Date: Tue, 26 Sep 2023 01:39:48 +0200 [thread overview]
Message-ID: <86o7hpx1eo.fsf@aarsen.me> (raw)
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
Hi,
This patch seems to have broken building GDB on
x86_64-portbld-freebsd13.1 for me. In the following hunk...
@@ -2094,6 +2092,9 @@ fbsd_nat_target::detach (inferior *inf, int from_tty)
}
}
}
+#else
+ /* pacify gcc */
+ wptid = (void) null_ptid;
#endif
sig = 0;
break;
... in the #else branch, there's a cast which I can't discern the
purpose of. The type of wptid is the same as the type of null_ptid, and
a cast to void as an rvalue doesn't make sense. Dropping the cast
results in the build working again (and no warnings).
Did you mean for this line to be 'wptid = null_ptid'?
TIA, have a lovely night :-)
--
Arsen Arsenović
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]
next reply other threads:[~2023-09-25 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 23:39 Arsen Arsenović [this message]
2023-09-26 11:10 ` Enze Li
2023-09-26 12:35 ` Arsen Arsenović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7hpx1eo.fsf@aarsen.me \
--to=arsen@aarsen.me \
--cc=enze.li@hotmail.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).