public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Enze Li <enze.li@hotmail.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: Gdb <gdb@sourceware.org>
Subject: Re: Re 2da39de "fbsd-nat: Pacify gcc with no functional changes"
Date: Tue, 26 Sep 2023 19:10:54 +0800	[thread overview]
Message-ID: <OS3P286MB2152E0774FC8FFADA18A796FF0C3A@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <86o7hpx1eo.fsf@aarsen.me> ("Arsen =?utf-8?Q?Arsenovi=C4=87?= =?utf-8?Q?=22's?= message of "Tue, 26 Sep 2023 01:39:48 +0200")

Hi Arsen,

Thanks for your feedback, I'll fix this soon.

Thanks,
Enze

On Tue, Sep 26 2023 at 01:39:48 AM +0200, Arsen Arsenović wrote:

> Hi,
>
> This patch seems to have broken building GDB on
> x86_64-portbld-freebsd13.1 for me.  In the following hunk...
>
>   @@ -2094,6 +2092,9 @@ fbsd_nat_target::detach (inferior *inf, int from_tty)
>                             }
>                         }
>                     }
>   +#else
>   +                 /* pacify gcc  */
>   +                 wptid = (void) null_ptid;
>    #endif
>                     sig = 0;
>                     break;
>
> ... in the #else branch, there's a cast which I can't discern the
> purpose of.  The type of wptid is the same as the type of null_ptid, and
> a cast to void as an rvalue doesn't make sense.  Dropping the cast
> results in the build working again (and no warnings).
>
> Did you mean for this line to be 'wptid = null_ptid'?
>
> TIA, have a lovely night :-)

  reply	other threads:[~2023-09-26  3:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 23:39 Arsen Arsenović
2023-09-26 11:10 ` Enze Li [this message]
2023-09-26 12:35   ` Arsen Arsenović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS3P286MB2152E0774FC8FFADA18A796FF0C3A@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
    --to=enze.li@hotmail.com \
    --cc=arsen@aarsen.me \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).