From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ilya Malakhov <ilmalakhovthefirst@gmail.com>
Cc: GDB <gdb@sourceware.org>
Subject: Re: Invalid use of $zlibdir within GDB_AC_CHECK_BFD
Date: Thu, 09 Apr 2015 11:47:00 -0000 [thread overview]
Message-ID: <CAMe9rOqPFNmea_BoNok-gJ4X6uSg47_jd0GsV=d8YV-OFYRNjg@mail.gmail.com> (raw)
In-Reply-To: <CAK1sNPC8GUwc4HUvb+WUm85OYKe+G2AmDduzAB-0St5hdKXJNA@mail.gmail.com>
On Thu, Apr 9, 2015 at 1:14 AM, Ilya Malakhov
<ilmalakhovthefirst@gmail.com> wrote:
> Hi,
>
> The use of $zlibdir when setting LDFLAGS within GDB_AC_CHECK_BFD in
> gdb/acinclude.m4 seems to be incorrect unless gdb is configured
> `--with-system
> -zlib'. At configure time it becomes (see config/zlib.m4)
>
> -L$(top_builddir)/../zlib
>
> with $(top_builddir) being a make(!) variable. This makes a number of
> gdb/configure
> tests fail unless a user has got an installed system zlib for the host of
> GDB. As a result,
> one may quite unexpectedly obtain GDB without ELF support.
>
I checked in this patch to fix it.
--
H.J.
---
From 5a2d4533e2b9cc9c069d47071013cb30f1e0fc7e Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 9 Apr 2015 04:43:57 -0700
Subject: [PATCH] Replace $zlibdir with $ZLIBDIR in LDFLAGS
* acinclude.m4: (GDB_AC_CHECK_BFD): Set ZLIBDIR with $zlibdir.
Replace $zlibdir with $ZLIBDIR in LDFLAGS.
* configure: Regenerated.
---
gdb/ChangeLog | 6 ++++++
gdb/acinclude.m4 | 3 ++-
gdb/configure | 6 ++++--
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 73a32a9..84d437f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2015-04-09 H.J. Lu <hongjiu.lu@intel.com>
+
+ * acinclude.m4: (GDB_AC_CHECK_BFD): Set ZLIBDIR with $zlibdir.
+ Replace $zlibdir with $ZLIBDIR in LDFLAGS.
+ * configure: Regenerated.
+
2015-04-09 Pedro Alves <palves@redhat.com>
* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add strtok_r.
diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4
index 98ae85f..845e65f 100644
--- a/gdb/acinclude.m4
+++ b/gdb/acinclude.m4
@@ -465,7 +465,8 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
# points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We
# always want our bfd.
CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
- LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS"
+ ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
+ LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
LIBS="-lbfd -liberty -lz $intl $LIBS"
AC_CACHE_CHECK([$1], [$2],
diff --git a/gdb/configure b/gdb/configure
index f835157..2baf6dd 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -13526,7 +13526,8 @@ esac
# points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We
# always want our bfd.
CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
- LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS"
+ ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
+ LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
LIBS="-lbfd -liberty -lz $intl $LIBS"
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for ELF support in BFD" >&5
@@ -13636,7 +13637,8 @@ fi
# points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We
# always want our bfd.
CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
- LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS"
+ ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
+ LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
LIBS="-lbfd -liberty -lz $intl $LIBS"
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for Mach-O
support in BFD" >&5
--
next parent reply other threads:[~2015-04-09 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAK1sNPC8GUwc4HUvb+WUm85OYKe+G2AmDduzAB-0St5hdKXJNA@mail.gmail.com>
2015-04-09 11:47 ` H.J. Lu [this message]
2015-04-09 8:49 Ilya Malakhov
-- strict thread matches above, loose matches on Subject: below --
2015-04-09 8:32 Ilya Malakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqPFNmea_BoNok-gJ4X6uSg47_jd0GsV=d8YV-OFYRNjg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gdb@sourceware.org \
--cc=ilmalakhovthefirst@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).