From: Christophe Lyon <christophe.lyon@linaro.org>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Christophe Lyon via Gdb <gdb@sourceware.org>
Subject: Re: [PATCH] contrib: Add autoregen.py
Date: Tue, 30 Apr 2024 14:45:49 +0200 [thread overview]
Message-ID: <CAPS5khapipszZACBb3ftJQYZot0qaQ_cA9CL-2wU+NvdUw-x3g@mail.gmail.com> (raw)
In-Reply-To: <8e024d9b-3066-42af-b665-9a48a5f2c801@simark.ca>
Hi,
On Fri, 19 Apr 2024 at 19:51, Simon Marchi <simark@simark.ca> wrote:
>
>
>
> On 2024-04-19 12:23, Tom Tromey wrote:
> >>>>>> Christophe Lyon via Gdb <gdb@sourceware.org> writes:
> >
> >> This script is a copy of the current script used by Sourceware's
> >> autoregen buildbots.
> >
> >> It is intended as a helper to regenerate files managed by autotools
> >> (autoconf, automake, aclocal, ....), as well as the toplevel
> >> Makefile.in which is created by autogen.
> >
> >> Other files can be updated when using maintainer-mode, but this is not
> >> covered by this script.
> >
> > Thanks for working on this.
> >
> >> +# these directories are known to be re-generatable with a simple autoreconf
> >> +# without special -I flags
> >
> > Can other directories be updated to this same standard? If not, why
> > not? I'm somewhat uncomfortable with the number of special cases in
> > this script.
> >
> > I was hoping it would be more like:
> >
> > top level -> autogen + autoconf
> > anywhere else with configure.{ac,in} -> autoreconf
> >
> > Tom
>
> I wrote the initial version of the autoreconf support in this script,
> originally it only had gdb, gdbserver and gdbsupport. But Christophe
> later added all the directories that currently work with a simple
> autoreconf. At this point, I think it would make sense to flip the
> logic and list only the directories that don't work with a simple
> autoreconf, and then work on reducing that list to 0.
>
I've recently added a patch to the 'master' copy of this script which
now defaults to using autoreconf, it is much simpler.
And Simon just sent a couple of GCC patches to fix incorrectly generated files,
which should enable us to use autoreconf in more places.
Thanks,
Christophe
> Simon
next prev parent reply other threads:[~2024-04-30 12:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 9:09 Christophe Lyon
2024-04-19 16:23 ` Tom Tromey
2024-04-19 17:51 ` Simon Marchi
2024-04-30 12:45 ` Christophe Lyon [this message]
2024-04-30 17:17 ` Tom Tromey
2024-04-30 18:00 ` Simon Marchi
2024-04-30 22:12 ` Tom Tromey
2024-04-19 22:59 ` Sam James
2024-04-30 12:50 ` Christophe Lyon
2024-04-30 17:59 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPS5khapipszZACBb3ftJQYZot0qaQ_cA9CL-2wU+NvdUw-x3g@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=gdb@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).