[PATCH] change bug url to https in gdb --help

[PATCH] change bug url to https in gdb --help

[Jonny Grant]

[-- Attachment #1: Type: text/plain, Size: 27 bytes --]

Please find attached
Jonny

[-- Attachment #2: 0001-Change-bug-url-to-https.patch --]
[-- Type: text/x-patch, Size: 826 bytes --]

From df0231a81311bc8cfe7240942e482e0518633d0f Mon Sep 17 00:00:00 2001
From: Jonathan Grant <jg@jguk.org>
Date: Wed, 27 May 2020 23:17:02 +0100
Subject: [PATCH] Change bug url to https

Signed-off-by: Jonathan Grant <jg@jguk.org>
---
 gdb/configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/configure.ac b/gdb/configure.ac
index 9dac11469f..62750804fa 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -430,7 +430,7 @@ AC_ARG_ENABLE([codesign],
 AC_SUBST([CODESIGN_CERT])
 
 ACX_PKGVERSION([GDB])
-ACX_BUGURL([http://www.gnu.org/software/gdb/bugs/])
+ACX_BUGURL([https://www.gnu.org/software/gdb/bugs/])
 AC_DEFINE_UNQUOTED([PKGVERSION], ["$PKGVERSION"], [Additional package description])
 AC_DEFINE_UNQUOTED([REPORT_BUGS_TO], ["$REPORT_BUGS_TO"], [Bug reporting address])
 
-- 
2.17.1

Re: [PATCH] change bug url to https in gdb --help

[Christian Biesinger]

Thanks for the patch! This looks good to me, though I can't officially
approve patches. But could you send patches to
gdb-patches@sourceware.org?

Also, it would be great if you could set up git-send-email for sending
patches, as that makes it easier to comment on them (it sends them
inline in the email)

Finally, patches require a changelog entry, please add one:
https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog

Thanks again,
Christian

On Wed, May 27, 2020 at 5:20 PM Jonny Grant <jg@jguk.org> wrote:
>
> Please find attached
> Jonny

Re: [PATCH] change bug url to https in gdb --help

[Jonny Grant]

Many thanks Christian

Will send to gdb-patches now with the ChangeLog.

Unfortunately my Ubuntu LTS git is stuck on 2.17.1 without the git-send-email command for the moment. I'll paste in an 
email to allow better comments.


Regards, Jonny

On 28/05/2020 20:05, Christian Biesinger wrote:
> Thanks for the patch! This looks good to me, though I can't officially
> approve patches. But could you send patches to
> gdb-patches@sourceware.org?
> 
> Also, it would be great if you could set up git-send-email for sending
> patches, as that makes it easier to comment on them (it sends them
> inline in the email)
> 
> Finally, patches require a changelog entry, please add one:
> https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog
> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
> 
> Thanks again,
> Christian
> 
> On Wed, May 27, 2020 at 5:20 PM Jonny Grant <jg@jguk.org> wrote:
>>
>> Please find attached
>> Jonny

Re: [PATCH] change bug url to https in gdb --help

[Simon Marchi]

On 2020-05-29 7:45 p.m., Jonny Grant wrote:
> Many thanks Christian
> 
> Will send to gdb-patches now with the ChangeLog.
> 
> Unfortunately my Ubuntu LTS git is stuck on 2.17.1 without the git-send-email command for the moment. I'll paste in an 
> email to allow better comments.

It's been available for ages, it's not a matter of old git.  It's just that it's
packaged separately:

https://packages.ubuntu.com/bionic/git-email

The packages.ubuntu.com interface (derived from packages.debian.org) is handy to
find which package provides a given file.  For example to find that the git-email
package provides the git-send-email file:

https://packages.ubuntu.com/search?suite=bionic&arch=amd64&mode=exactfilename&searchon=contents&keywords=git-send-email

Alternatively, the `apt-file` package gives you the same functionality locally.

Simon

Re: [PATCH] change bug url to https in gdb --help

[Jonny Grant]

On 30/05/2020 16:26, Simon Marchi wrote:
> On 2020-05-29 7:45 p.m., Jonny Grant wrote:
>> Many thanks Christian
>>
>> Will send to gdb-patches now with the ChangeLog.
>>
>> Unfortunately my Ubuntu LTS git is stuck on 2.17.1 without the git-send-email command for the moment. I'll paste in an
>> email to allow better comments.
> 
> It's been available for ages, it's not a matter of old git.  It's just that it's
> packaged separately:
> 
> https://packages.ubuntu.com/bionic/git-email
> 
> The packages.ubuntu.com interface (derived from packages.debian.org) is handy to
> find which package provides a given file.  For example to find that the git-email
> package provides the git-send-email file:
> 
> https://packages.ubuntu.com/search?suite=bionic&arch=amd64&mode=exactfilename&searchon=contents&keywords=git-send-email
> 
> Alternatively, the `apt-file` package gives you the same functionality locally.
> 
> Simon
> 

Many thanks. I've installed the package and will use git send-email next time
Jonny

Re: [PATCH] change bug url to https in gdb --help

[Jonny Grant]

On 28/05/2020 20:05, Christian Biesinger wrote:
> Thanks for the patch! This looks good to me, though I can't officially
> approve patches. But could you send patches to
> gdb-patches@sourceware.org?
> 
> Also, it would be great if you could set up git-send-email for sending
> patches, as that makes it easier to comment on them (it sends them
> inline in the email)
> 
> Finally, patches require a changelog entry, please add one:
> https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog

Hi Christian

Thank you for the links.

There's a small typo on that ContributionChecklist wiki. Signed up, but can't edit the page.

"of they will be rejected during mailing list moderation"
^ should be "or"

Regards, Jonny

Re: [PATCH] change bug url to https in gdb --help

[Christian Biesinger]

On Tue, Jun 9, 2020 at 7:20 AM Jonny Grant <jg@jguk.org> wrote:
> On 28/05/2020 20:05, Christian Biesinger wrote:
> > Thanks for the patch! This looks good to me, though I can't officially
> > approve patches. But could you send patches to
> > gdb-patches@sourceware.org?
> >
> > Also, it would be great if you could set up git-send-email for sending
> > patches, as that makes it easier to comment on them (it sends them
> > inline in the email)
> >
> > Finally, patches require a changelog entry, please add one:
> > https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog
>
> Hi Christian
>
> Thank you for the links.
>
> There's a small typo on that ContributionChecklist wiki. Signed up, but can't edit the page.
>
> "of they will be rejected during mailing list moderation"
> ^ should be "or"

Thanks, I fixed the typo, although I am not sure that sentence is
right -- I don't think gdb-patches is moderated?

Christian

Re: [PATCH] change bug url to https in gdb --help

[Jonny Grant]

On 30/05/2020 16:26, Simon Marchi wrote:
> On 2020-05-29 7:45 p.m., Jonny Grant wrote:
>> Many thanks Christian
>>
>> Will send to gdb-patches now with the ChangeLog.
>>
>> Unfortunately my Ubuntu LTS git is stuck on 2.17.1 without the git-send-email command for the moment. I'll paste in an 
>> email to allow better comments.
> 
> It's been available for ages, it's not a matter of old git.  It's just that it's
> packaged separately:
> 
> https://packages.ubuntu.com/bionic/git-email
> 
> The packages.ubuntu.com interface (derived from packages.debian.org) is handy to
> find which package provides a given file.  For example to find that the git-email
> package provides the git-send-email file:
> 
> https://packages.ubuntu.com/search?suite=bionic&arch=amd64&mode=exactfilename&searchon=contents&keywords=git-send-email
> 
> Alternatively, the `apt-file` package gives you the same functionality locally.
> 
> Simon

Spent some time trying to get git send-email set up with gmail SMTP, but ran out of time, and didn't want to put my password in a file on on command line.  In the end I just followed the guide https://www.kernel.org/doc/html/latest/process/email-clients.html#thunderbird-gui

I've sent through to gdb-patches, fingers-crossed
Jonny

Re: [PATCH] change bug url to https in gdb --help

[Simon Marchi]

On 2020-06-09 2:24 p.m., Christian Biesinger via Gdb wrote:
> On Tue, Jun 9, 2020 at 7:20 AM Jonny Grant <jg@jguk.org> wrote:
>> On 28/05/2020 20:05, Christian Biesinger wrote:
>>> Thanks for the patch! This looks good to me, though I can't officially
>>> approve patches. But could you send patches to
>>> gdb-patches@sourceware.org?
>>>
>>> Also, it would be great if you could set up git-send-email for sending
>>> patches, as that makes it easier to comment on them (it sends them
>>> inline in the email)
>>>
>>> Finally, patches require a changelog entry, please add one:
>>> https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog
>>
>> Hi Christian
>>
>> Thank you for the links.
>>
>> There's a small typo on that ContributionChecklist wiki. Signed up, but can't edit the page.
>>
>> "of they will be rejected during mailing list moderation"
>> ^ should be "or"
> 
> Thanks, I fixed the typo, although I am not sure that sentence is
> right -- I don't think gdb-patches is moderated?

That doesn't sound right... feel free to just remove that part of the sentence.

Simon

Re: [PATCH] change bug url to https in gdb --help

[Pedro Alves]

On 6/11/20 3:27 AM, Simon Marchi wrote:
> On 2020-06-09 2:24 p.m., Christian Biesinger via Gdb wrote:
>> On Tue, Jun 9, 2020 at 7:20 AM Jonny Grant <jg@jguk.org> wrote:
>>> On 28/05/2020 20:05, Christian Biesinger wrote:
>>>> Thanks for the patch! This looks good to me, though I can't officially
>>>> approve patches. But could you send patches to
>>>> gdb-patches@sourceware.org?
>>>>
>>>> Also, it would be great if you could set up git-send-email for sending
>>>> patches, as that makes it easier to comment on them (it sends them
>>>> inline in the email)
>>>>
>>>> Finally, patches require a changelog entry, please add one:
>>>> https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog
>>>
>>> Hi Christian
>>>
>>> Thank you for the links.
>>>
>>> There's a small typo on that ContributionChecklist wiki. Signed up, but can't edit the page.
>>>
>>> "of they will be rejected during mailing list moderation"
>>> ^ should be "or"
>>
>> Thanks, I fixed the typo, although I am not sure that sentence is
>> right -- I don't think gdb-patches is moderated?
> 
> That doesn't sound right... feel free to just remove that part of the sentence.

Just replace moderation with review and it will make sense.

Thanks,
Pedro Alves

Re: [PATCH] change bug url to https in gdb --help

[Christian Biesinger]

On Thu, Jun 11, 2020 at 10:57 AM Pedro Alves <palves@redhat.com> wrote:
>
> On 6/11/20 3:27 AM, Simon Marchi wrote:
> > On 2020-06-09 2:24 p.m., Christian Biesinger via Gdb wrote:
> >> On Tue, Jun 9, 2020 at 7:20 AM Jonny Grant <jg@jguk.org> wrote:
> >>> On 28/05/2020 20:05, Christian Biesinger wrote:
> >>>> Thanks for the patch! This looks good to me, though I can't officially
> >>>> approve patches. But could you send patches to
> >>>> gdb-patches@sourceware.org?
> >>>>
> >>>> Also, it would be great if you could set up git-send-email for sending
> >>>> patches, as that makes it easier to comment on them (it sends them
> >>>> inline in the email)
> >>>>
> >>>> Finally, patches require a changelog entry, please add one:
> >>>> https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog
> >>>
> >>> Hi Christian
> >>>
> >>> Thank you for the links.
> >>>
> >>> There's a small typo on that ContributionChecklist wiki. Signed up, but can't edit the page.
> >>>
> >>> "of they will be rejected during mailing list moderation"
> >>> ^ should be "or"
> >>
> >> Thanks, I fixed the typo, although I am not sure that sentence is
> >> right -- I don't think gdb-patches is moderated?
> >
> > That doesn't sound right... feel free to just remove that part of the sentence.
>
> Just replace moderation with review and it will make sense.

Good point, done.

Christian