From: Simon Marchi <simark@simark.ca>
To: "H.J. Lu" <hjl.tools@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Joel Brobecker <brobecker@adacore.com>
Cc: GDB <gdb@sourceware.org>,
"H.J. Lu via Binutils" <binutils@sourceware.org>
Subject: Re: Does "git bisect" work for anyone?
Date: Tue, 6 Oct 2020 17:29:34 -0400 [thread overview]
Message-ID: <a244784d-8802-2f12-4539-5b949ce8ac12@simark.ca> (raw)
In-Reply-To: <CAMe9rOovQrXdsGiSDC3yq4c6m8HGrouxrzYevq1ZDJP2WrL4FQ@mail.gmail.com>
On 2020-10-03 9:57 a.m., H.J. Lu via Gdb wrote:
> On Fri, Oct 2, 2020 at 11:27 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Okt 02 2020, H.J. Lu via Binutils wrote:
>>
>>> On master branch, I got
>>>
>>> $ git checkout d0e70c4189d5d6a6e63b85c1d3c10c74852173b4
>>> Previous HEAD position was 5a805384b83 asan: readelf buffer overflow and abort
>>> HEAD is now at d0e70c4189d Automatic date update in version.in
>>> $ git bisect good
>>> $ git checkout fe07b5721a64a84e36ec63e15638b87655faf1bf
>>> Previous HEAD position was d0e70c4189d Automatic date update in version.in
>>> HEAD is now at fe07b5721a6 gdb/testsuite: Update test pattern in
>>> ptype-on-functions.exp
>>> $ git bisect bad
>>> Some good revs are not ancestors of the bad rev.
>>
>> Git told you the reason.
>>
>> $ git rev-list d0e70c4189d5d6a6e63b85c1d3c10c74852173b4..fe07b5721a64a84e36ec63e15638b87655faf1bf | wc -l
>> 0
>
> How did this happen? Joel, shouldn't git commit hook check non-empty
> forward and backward git rev-list outputs to support git bisect?
What does that mean? How can you have both forward and backward
rev-list non-empty?
It's just that you got the revs backwards. By default, "good" must be
older than "bad". If that's confusing, because you are investigating
when a fix was introduced (and therefore, your "bad" is older than your
"good"), you can change the terms to use something else than "good" and
"bad". For example:
$ git bisect start --term-old my_bad --term-new my_good
$ git bisect my_bad fe07b5721a64a84e36ec63e15638b87655faf1bf
$ git bisect my_good d0e70c4189d5d6a6e63b85c1d3c10c74852173b4
Bisecting: 115 revisions left to test after this (roughly 7 steps)
[e148b73013109517c4d179aa9ae5a50b6d1dd5b5] libctf: drop error-prone ctf_strerror
Simon
prev parent reply other threads:[~2020-10-06 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 22:25 H.J. Lu
2020-10-03 6:27 ` Andreas Schwab
2020-10-03 13:57 ` H.J. Lu
2020-10-06 21:29 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a244784d-8802-2f12-4539-5b949ce8ac12@simark.ca \
--to=simark@simark.ca \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).