From: Andreas Schwab <schwab@linux-m68k.org>
To: "H.J. Lu via Binutils" <binutils@sourceware.org>
Cc: GDB <gdb@sourceware.org>, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: Does "git bisect" work for anyone?
Date: Sat, 03 Oct 2020 08:27:54 +0200 [thread overview]
Message-ID: <87imbrhlhx.fsf@linux-m68k.org> (raw)
In-Reply-To: <CAMe9rOp0UfUtqb=n0SzT4AKxOFhihpGPEBpPfGOHDUxsZKU2zw@mail.gmail.com> (H. J. Lu via Binutils's message of "Fri, 2 Oct 2020 15:25:14 -0700")
On Okt 02 2020, H.J. Lu via Binutils wrote:
> On master branch, I got
>
> $ git checkout d0e70c4189d5d6a6e63b85c1d3c10c74852173b4
> Previous HEAD position was 5a805384b83 asan: readelf buffer overflow and abort
> HEAD is now at d0e70c4189d Automatic date update in version.in
> $ git bisect good
> $ git checkout fe07b5721a64a84e36ec63e15638b87655faf1bf
> Previous HEAD position was d0e70c4189d Automatic date update in version.in
> HEAD is now at fe07b5721a6 gdb/testsuite: Update test pattern in
> ptype-on-functions.exp
> $ git bisect bad
> Some good revs are not ancestors of the bad rev.
Git told you the reason.
$ git rev-list d0e70c4189d5d6a6e63b85c1d3c10c74852173b4..fe07b5721a64a84e36ec63e15638b87655faf1bf | wc -l
0
$ git rev-list fe07b5721a64a84e36ec63e15638b87655faf1bf..d0e70c4189d5d6a6e63b85c1d3c10c74852173b4 | wc -l
232
> git bisect cannot work properly in this case.
> Maybe you mistook good and bad revs?
If you want to find the commit where an issue is fixed, you need to mark
the commits that don't have the issue as bad and the the ones that have
the issue as good.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2020-10-03 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 22:25 H.J. Lu
2020-10-03 6:27 ` Andreas Schwab [this message]
2020-10-03 13:57 ` H.J. Lu
2020-10-06 21:29 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbrhlhx.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=binutils@sourceware.org \
--cc=gdb@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).