From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb@sourceware.org
Subject: Re: Running selftests in GDB
Date: Sun, 4 Oct 2020 18:56:06 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2010041851220.333514@eddie.linux-mips.org> (raw)
In-Reply-To: <83pn5ydkxq.fsf@gnu.org>
On Sun, 4 Oct 2020, Eli Zaretskii wrote:
> > > Answering myself: after reconfiguring with --enable-unit-tests, one
> > > should make sure gdb/init.c is regenerated. It looks like it won't be
> > > regenerated, unless you touch one of the source files mentioned in
> > > COMMON_SFILES by gdb/Makefile.
> >
> > It looks like a dependency needs to be added to gdb/Makefile.in for
> > gdb/init.c on whatever is changed with `--enable-unit-tests' that affects
> > the file; can you run a diff on the object tree configured with and
> > without the option to figure out what has changed that affects gdb/init.c?
>
> AFAIR, the object tree didn't change, but SELFTESTS_OBS don't appear
> in CONFIG_OBS. When you reconfigure, SELFTESTS_OBS gets added to
> CONFIG_OBS, but there's nothing to trigger init.c regeneration.
Well, it couldn't have been that the object tree didn't change then, as
the addition of SELFTESTS_OBS to CONFIG_OBS is clearly a change. :) It
looks to me like gdb/Makefile should be a dependency of gdb/init.c then
(or stamp-init really).
Maciej
next prev parent reply other threads:[~2020-10-04 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 9:33 Eli Zaretskii
2020-09-28 16:53 ` Eli Zaretskii
2020-10-04 15:52 ` Maciej W. Rozycki
2020-10-04 16:18 ` Eli Zaretskii
2020-10-04 17:56 ` Maciej W. Rozycki [this message]
2020-10-04 18:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2010041851220.333514@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=eliz@gnu.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).