public inbox for glibc-bugs-regex@sourceware.org
help / color / mirror / Atom feed
* [Bug regex/605] New: regex goes uselessly through slow paths
@ 2004-12-10 16:54 bonzini at gnu dot org
2004-12-10 16:55 ` [Bug regex/605] " bonzini at gnu dot org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: bonzini at gnu dot org @ 2004-12-10 16:54 UTC (permalink / raw)
To: glibc-bugs-regex
An improvement of 10-30% in the speed of the matcher (LC_ALL=C or other
single-byte character sets) can be achieved by avoiding that OP_PERIOD goes
through the slow multibyte paths. This is done by the attached patch.
While this patch only affects SBCS (i.e. scripts, which are starting to use
LC_ALL=C to avoid bugs due to the collation rules of some languages), in
principle UTF-8 optimization could be fixed to be optimizable as well. The
slowness of prune_impossible_nodes, alas, makes this impractical yet.
--
Summary: regex goes uselessly through slow paths
Product: glibc
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: regex
AssignedTo: bonzini at gnu dot org
ReportedBy: bonzini at gnu dot org
CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
bugs at sources dot redhat dot com
OtherBugsDependingO 500
nThis:
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
@ 2004-12-10 16:55 ` bonzini at gnu dot org
2004-12-20 10:21 ` bonzini at gnu dot org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bonzini at gnu dot org @ 2004-12-10 16:55 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From bonzini at gnu dot org 2004-12-10 16:55 -------
Created an attachment (id=307)
--> (http://sources.redhat.com/bugzilla/attachment.cgi?id=307&action=view)
updated patch
The original patch was posted at
http://sources.redhat.com/ml/libc-alpha/2004-12/msg00026.html and was
referenced as "patch 1" there.
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
2004-12-10 16:55 ` [Bug regex/605] " bonzini at gnu dot org
@ 2004-12-20 10:21 ` bonzini at gnu dot org
2004-12-20 10:23 ` bonzini at gnu dot org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bonzini at gnu dot org @ 2004-12-20 10:21 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From bonzini at gnu dot org 2004-12-20 10:21 -------
I'm putting pending patches at P1, just as a convention.
--
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P1
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
2004-12-10 16:55 ` [Bug regex/605] " bonzini at gnu dot org
2004-12-20 10:21 ` bonzini at gnu dot org
@ 2004-12-20 10:23 ` bonzini at gnu dot org
2004-12-27 16:40 ` drepper at redhat dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bonzini at gnu dot org @ 2004-12-20 10:23 UTC (permalink / raw)
To: glibc-bugs-regex
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
` (2 preceding siblings ...)
2004-12-20 10:23 ` bonzini at gnu dot org
@ 2004-12-27 16:40 ` drepper at redhat dot com
2004-12-28 16:33 ` bonzini at gnu dot org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: drepper at redhat dot com @ 2004-12-27 16:40 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From drepper at redhat dot com 2004-12-27 16:40 -------
I need a ChangeLog entry for this updated patch.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |WAITING
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
` (3 preceding siblings ...)
2004-12-27 16:40 ` drepper at redhat dot com
@ 2004-12-28 16:33 ` bonzini at gnu dot org
2004-12-28 16:34 ` bonzini at gnu dot org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bonzini at gnu dot org @ 2004-12-28 16:33 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From bonzini at gnu dot org 2004-12-28 16:33 -------
Here it is. The only changes were in the context.
2004-12-28 Paolo Bonzini <bonzini@gnu.org>
* lib/regcomp.c (parse_bracket_exp): Do not modify DFA nodes
that were already created.
* lib/regex_internal.c (re_dfa_add_node): Set accept_mb field
in the token if needed.
(create_ci_newstate, create_cd_newstate): Set accept_mb field
from the tokens' field.
* lib/regex_internal.h (re_token_t): Add accept_mb field.
(ACCEPT_MB_NODE): Removed.
* lib/regexec.c (proceed_next_node, transit_states_mb,
build_sifted_states, check_arrival_add_next_nodes): Use
accept_mb instead of ACCEPT_MB_NODE.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |ASSIGNED
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
` (4 preceding siblings ...)
2004-12-28 16:33 ` bonzini at gnu dot org
@ 2004-12-28 16:34 ` bonzini at gnu dot org
2005-01-21 14:01 ` bonzini at gnu dot org
2005-01-26 22:28 ` drepper at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: bonzini at gnu dot org @ 2004-12-28 16:34 UTC (permalink / raw)
To: glibc-bugs-regex
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |611
nThis| |
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
` (5 preceding siblings ...)
2004-12-28 16:34 ` bonzini at gnu dot org
@ 2005-01-21 14:01 ` bonzini at gnu dot org
2005-01-26 22:28 ` drepper at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: bonzini at gnu dot org @ 2005-01-21 14:01 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From bonzini at gnu dot org 2005-01-21 14:01 -------
ping
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug regex/605] regex goes uselessly through slow paths
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
` (6 preceding siblings ...)
2005-01-21 14:01 ` bonzini at gnu dot org
@ 2005-01-26 22:28 ` drepper at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: drepper at redhat dot com @ 2005-01-26 22:28 UTC (permalink / raw)
To: glibc-bugs-regex
------- Additional Comments From drepper at redhat dot com 2005-01-26 22:27 -------
Applied to cvs now.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://sources.redhat.com/bugzilla/show_bug.cgi?id=605
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2005-01-26 22:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-10 16:54 [Bug regex/605] New: regex goes uselessly through slow paths bonzini at gnu dot org
2004-12-10 16:55 ` [Bug regex/605] " bonzini at gnu dot org
2004-12-20 10:21 ` bonzini at gnu dot org
2004-12-20 10:23 ` bonzini at gnu dot org
2004-12-27 16:40 ` drepper at redhat dot com
2004-12-28 16:33 ` bonzini at gnu dot org
2004-12-28 16:34 ` bonzini at gnu dot org
2005-01-21 14:01 ` bonzini at gnu dot org
2005-01-26 22:28 ` drepper at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).