public inbox for glibc-bugs-regex@sourceware.org help / color / mirror / Atom feed
From: "svdb+sources dot redhat dot com-bugs at stack dot nl" <sourceware-bugzilla@sources.redhat.com> To: glibc-bugs-regex@sources.redhat.com Subject: [Bug regex/860] New: bad guard in find_recover_state do-while loop Date: Tue, 19 Apr 2005 01:03:00 -0000 [thread overview] Message-ID: <20050419010238.860.svdb+sources.redhat.com-bugs@stack.nl> (raw) While compiling the regex code with extra warnings on, from outside libc, quite a lot of warnings were reported. While these warnings were very justified, most of the underlying problems would not cause the actual code to behave in a non- intended way. But one is very much a bug: In find_recover_state, err is compared to REG_NOERROR, while it is *err which should be compared instead. Because of this the do-while loop will always terminate after one iteration. I was working on getting rid of all the warnings in the regex code, which was taking quite a bit of time, as I needed to make sure I'm fixing the actual problems, and not (just) the symptoms. But then I noticed that the GNU coding guidelines stopped just short of saying "Listening to warnings to find a few bugs is not worth the effort.", which would explain the mess I'm encountering. I am willing to continue my work and submit a big patch with fixes that will clean up this code somewhat, but before I continue, I'd like to know whether such a patch will actually stand a chance of getting accepted. -- Summary: bad guard in find_recover_state do-while loop Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: regex AssignedTo: gotom at debian dot or dot jp ReportedBy: svdb+sources dot redhat dot com-bugs at stack dot nl CC: glibc-bugs-regex at sources dot redhat dot com,glibc- bugs at sources dot redhat dot com http://sources.redhat.com/bugzilla/show_bug.cgi?id=860 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
next reply other threads:[~2005-04-19 1:03 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2005-04-19 1:03 svdb+sources dot redhat dot com-bugs at stack dot nl [this message] 2005-04-19 6:57 ` [Bug regex/860] " paolo dot bonzini at lu dot unisi dot ch 2005-09-27 5:50 ` drepper at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20050419010238.860.svdb+sources.redhat.com-bugs@stack.nl \ --to=sourceware-bugzilla@sources.redhat.com \ --cc=glibc-bugs-regex@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).