[Bug regex/1281] New: support 64-bit hosts when regex code when used outside glibc

[Bug regex/1281] New: support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

On 64-bit hosts (where size_t is 64 bits and int is 32 bits), the
old glibc regex code mishandles strings longer than 2**31 bytes.
The attached patch fixes this when the regex code is used in gnulib
(i.e., outside glibc).

This patch should not affect the use of the regex code inside
glibc.  No doubt this problem also needs to be handled for glibc
as well, but the result will be an incompatible change to the
glibc ABI, and the old ABI will have to be supported too.  That
can be the the subject for another patch.

-- 
           Summary: support 64-bit hosts when regex code when used outside
                    glibc
           Product: glibc
           Version: 2.3.5
            Status: NEW
          Severity: normal
          Priority: P2
         Component: regex
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: eggert at gnu dot org
                CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
                    bugs at sources dot redhat dot com
 BugsThisDependsOn: 1220


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

------- Additional Comments From eggert at gnu dot org  2005-08-31 22:43 -------
Created an attachment (id=636)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=636&action=view)
add support for 64-bit hosts when code is used outside glibc


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |1282
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |1284
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[bonzini at gnu dot org]

------- Additional Comments From bonzini at gnu dot org  2005-09-01 07:05 -------
I'd rather be consistent and name the Idx type re_idx_t.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |1285
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |1287
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

------- Additional Comments From eggert at gnu dot org  2005-09-01 22:19 -------
For internal use (in regex_internal.h), I initially started with the
name re_idx_t as you suggested.  But this caused a lot of code
reindenting, since I had to replace "int" by "re_idx_t" in a lot of
places.  Also, the code got more verbose.  Using "Idx" instead of "re_idx_t"
solved that problem.

However, if the consensus is to call it re_idx_t I'd be happy to
produce a new patch that uses the name.

I should mention that this type name is not visible to the user in the
proposed patch.  I was reluctant to introduce the name re_idx_t into
regex.h, because I thought that the user should see just the new
interface, which uses size_t for sizes and offset.  However, if you'd
prefer to make re_idx_t public I can also do that easily.


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[eggert at gnu dot org]

------- Additional Comments From eggert at gnu dot org  2005-09-01 22:20 -------
Also please see the patch in bug 1287, which fixes a glitch introduced
in patch 1281.  The glitch affects only code compiled outside glibc,
and only when compiled with _REGEX_LARGE_OFFSETS defined.

I should also mention that I checked that the 1281 patch introduced zero
changes to the regex code when compiled outside glibc, unless you define
the new _REGEX_LARGE_OFFSETS feature-test macro.  I checked this by inspecting
the assembly-language code generated both before and after the change.


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[drepper at redhat dot com]

-- 
Bug 1281 depends on bug 1220, which changed state.

Bug 1220 Summary: regex uses old-style definitions that cause g++ to fail
http://sourceware.org/bugzilla/show_bug.cgi?id=1220

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

http://sourceware.org/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2005-09-06 23:47 -------
This is complete crap.

First, I'm not applying any patch which changes the ABI.  Whether a macro has to
be defined to do it or not.

Second, there is no reason to extend all these types.  4G of something (when
used as index) is quite enough.  We don't use _smaller_ types on 32-bit machines
because it would just make the code slower.

For your "64-bit port" you have to indentify the few places where more than 4G
(or 2G for signed values) really makes sense and not this senseless replacing of
types.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[bruno at clisp dot org]

-- 
Bug 1281 depends on bug 1220, which changed state.

Bug 1220 Summary: regex uses old-style definitions that cause g++ to fail
http://sourceware.org/bugzilla/show_bug.cgi?id=1220

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |

http://sourceware.org/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[drepper at redhat dot com]

-- 
Bug 1281 depends on bug 1220, which changed state.

Bug 1220 Summary: regex uses old-style definitions that cause g++ to fail
http://sourceware.org/bugzilla/show_bug.cgi?id=1220

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |INVALID

http://sourceware.org/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2006-04-25 18:20 -------
No reply in 6+ months.  Closing.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug regex/1281] support 64-bit hosts when regex code when used outside glibc

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2006-04-25 22:54 -------
OK, actually closing now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |WONTFIX


http://sourceware.org/bugzilla/show_bug.cgi?id=1281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.