public inbox for glibc-bugs-regex@sourceware.org
help / color / mirror / Atom feed
* [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc
@ 2005-07-07  8:28 eggert at gnu dot org
  2005-07-07  8:30 ` [Bug regex/1054] " eggert at gnu dot org
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: eggert at gnu dot org @ 2005-07-07  8:28 UTC (permalink / raw)
  To: glibc-bugs-regex

I just now adapted coreutils to bundle the new regular expression implementation
of libc instead of the old one that it was using.  But I ran into a problem when
I built this implementation under Debian GNU/Linux 3.1 r0a.  The problem is that
Debian's include files (which are from glibc) #define __mempcpy for efficiency,
and this clashes with the #define in regex_internal.h.  I will attach the patch I
used to work around the problem; it uses an ifndef to avoid the redefinition.
It might not hurt to put similar wrappers around the other symbols thus defined,
I suppose.

This patch is currently installed in gnulib, and I'm filing this bug report to
have it propagated into libc proper.  Thanks.

-- 
           Summary: regex_internal.h redefines __mempcpy when used outside
                    libc
           Product: glibc
           Version: 2.3.5
            Status: NEW
          Severity: normal
          Priority: P2
         Component: regex
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: eggert at gnu dot org
                CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
                    bugs at sources dot redhat dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1054

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug regex/1054] regex_internal.h redefines __mempcpy when used outside libc
  2005-07-07  8:28 [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc eggert at gnu dot org
@ 2005-07-07  8:30 ` eggert at gnu dot org
  2005-09-06 16:35 ` drepper at redhat dot com
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: eggert at gnu dot org @ 2005-07-07  8:30 UTC (permalink / raw)
  To: glibc-bugs-regex


------- Additional Comments From eggert at gnu dot org  2005-07-07 08:30 -------
Created an attachment (id=546)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=546&action=view)
regex_internal.h patch for porting to Debian GNU/Linux 3.1 r0a

This patch is needed when compiling regex_internal.h outside of libc.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1054

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug regex/1054] regex_internal.h redefines __mempcpy when used outside libc
  2005-07-07  8:28 [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc eggert at gnu dot org
  2005-07-07  8:30 ` [Bug regex/1054] " eggert at gnu dot org
@ 2005-09-06 16:35 ` drepper at redhat dot com
  2005-09-06 16:49 ` paolo dot bonzini at lu dot unisi dot ch
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: drepper at redhat dot com @ 2005-09-06 16:35 UTC (permalink / raw)
  To: glibc-bugs-regex


------- Additional Comments From drepper at redhat dot com  2005-09-06 16:35 -------
This is all wrong.  I have no interest to waste my time on unsupported paltforms
just because some people think supporting worthless platforms is useful.  If you
want to do it, do it all by yourself.  I'm willing to accept a patch which
removes all of those !_LIBC handling (especially in headers) as much as possible
and add

#ifndef _LIBC
# include "regex-no-glibc.h"
#endif

This file would not be present in glibc and you can define all the crap you want
in it for gnulib.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=1054

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug regex/1054] regex_internal.h redefines __mempcpy when used outside libc
  2005-07-07  8:28 [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc eggert at gnu dot org
  2005-07-07  8:30 ` [Bug regex/1054] " eggert at gnu dot org
  2005-09-06 16:35 ` drepper at redhat dot com
@ 2005-09-06 16:49 ` paolo dot bonzini at lu dot unisi dot ch
  2005-09-22 18:39 ` drepper at redhat dot com
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paolo dot bonzini at lu dot unisi dot ch @ 2005-09-06 16:49 UTC (permalink / raw)
  To: glibc-bugs-regex


------- Additional Comments From paolo dot bonzini at lu dot unisi dot ch  2005-09-06 16:49 -------
Subject: Re:  regex_internal.h redefines __mempcpy when used
 outside libc

drepper at redhat dot com wrote:

>------- Additional Comments From drepper at redhat dot com  2005-09-06 16:35 -------
>This is all wrong.  I have no interest to waste my time on unsupported paltforms
>just because some people think supporting worthless platforms is useful.  If you
>want to do it, do it all by yourself.  I'm willing to accept a patch which
>removes all of those !_LIBC handling (especially in headers) as much as possible
>and add
>  
>
Uli, it's glibc that defines __mempcpy as part of the string inlines 
stuff.  It's not an unsupported platform, it's just 
--with-included-regex on a glibc system.

Paolo


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=1054

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug regex/1054] regex_internal.h redefines __mempcpy when used outside libc
  2005-07-07  8:28 [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc eggert at gnu dot org
                   ` (2 preceding siblings ...)
  2005-09-06 16:49 ` paolo dot bonzini at lu dot unisi dot ch
@ 2005-09-22 18:39 ` drepper at redhat dot com
  2006-04-25 18:17 ` drepper at redhat dot com
  2006-08-24  6:54 ` drepper at redhat dot com
  5 siblings, 0 replies; 7+ messages in thread
From: drepper at redhat dot com @ 2005-09-22 18:39 UTC (permalink / raw)
  To: glibc-bugs-regex


------- Additional Comments From drepper at redhat dot com  2005-09-22 18:39 -------
> Uli, it's glibc that defines __mempcpy as part of the string inlines 
> stuff.  It's not an unsupported platform, it's just 
> --with-included-regex on a glibc system.

What are you talking about?  The patch is not needed for compiling glibc. 
Period.  Therefore any such horrible workaround does not belong in glibc.  All
this configuration handling which is of no interest to glibc should be kept
elsewhere which is what I said in my comment.

Either send a patch which moves all this nonsense into a separate file (which is
not part of glibc) or live with the current code.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=1054

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug regex/1054] regex_internal.h redefines __mempcpy when used outside libc
  2005-07-07  8:28 [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc eggert at gnu dot org
                   ` (3 preceding siblings ...)
  2005-09-22 18:39 ` drepper at redhat dot com
@ 2006-04-25 18:17 ` drepper at redhat dot com
  2006-08-24  6:54 ` drepper at redhat dot com
  5 siblings, 0 replies; 7+ messages in thread
From: drepper at redhat dot com @ 2006-04-25 18:17 UTC (permalink / raw)
  To: glibc-bugs-regex


------- Additional Comments From drepper at redhat dot com  2006-04-25 18:16 -------
No reply in 6+ months.  Closing.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=1054

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug regex/1054] regex_internal.h redefines __mempcpy when used outside libc
  2005-07-07  8:28 [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc eggert at gnu dot org
                   ` (4 preceding siblings ...)
  2006-04-25 18:17 ` drepper at redhat dot com
@ 2006-08-24  6:54 ` drepper at redhat dot com
  5 siblings, 0 replies; 7+ messages in thread
From: drepper at redhat dot com @ 2006-08-24  6:54 UTC (permalink / raw)
  To: glibc-bugs-regex


------- Additional Comments From drepper at redhat dot com  2006-08-24 06:54 -------
ACtually closing.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |WONTFIX


http://sourceware.org/bugzilla/show_bug.cgi?id=1054

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2006-08-24  6:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-07  8:28 [Bug regex/1054] New: regex_internal.h redefines __mempcpy when used outside libc eggert at gnu dot org
2005-07-07  8:30 ` [Bug regex/1054] " eggert at gnu dot org
2005-09-06 16:35 ` drepper at redhat dot com
2005-09-06 16:49 ` paolo dot bonzini at lu dot unisi dot ch
2005-09-22 18:39 ` drepper at redhat dot com
2006-04-25 18:17 ` drepper at redhat dot com
2006-08-24  6:54 ` drepper at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).