[Bug regex/18495] New: regcomp wctype namespace

[Bug regex/18495] New: regcomp wctype namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18495

            Bug ID: 18495
           Summary: regcomp wctype namespace
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: regex
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

regcomp brings in references to various wctype functions that aren't in all the
standards including regcomp:

[initial] regcomp -> [libc.a(regex.o)] iswalnum
[initial] regcomp -> [libc.a(regex.o)] iswlower
[initial] regcomp -> [libc.a(regex.o)] towlower
[initial] regcomp -> [libc.a(regex.o)] towupper

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug regex/18495] regcomp wctype namespace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18495

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  9dd6b7799a0b04034f2d2266845c64a309b015a3 (commit)
      from  a330baa05bf827b67a6391721fa3ab2f72f1f4dc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9dd6b7799a0b04034f2d2266845c64a309b015a3

commit 9dd6b7799a0b04034f2d2266845c64a309b015a3
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Jun 5 20:04:47 2015 +0000

    Fix regex wctype namespace (bug 18495).

    regcomp brings in references to various wctype functions that aren't
    in all the standards including regcomp.  This patch fixes this in the
    usual way by using the __* versions of these functions (which already
    exist, but some didn't have libc_hidden_proto / libc_hidden_def
    before).

    Tested for x86_64 and x86 (testsuite, and that installed stripped
    shared libraries are unchanged by the patch).  (Other wide character
    function references from the regex code mean that this patch by itself
    doesn't fix any XFAILed linknamespace test failures; further patches
    will be needed for that.)

        [BZ #18495]
        * wctype/wcfuncs.c (__iswalnum): Use libc_hidden_def.
        (__iswlower): Likewise.
        * include/wctype.h (__iswalnum): Declare.  Use libc_hidden_proto.
        (__iswlower): Likewise.
        * posix/regcomp.c (re_compile_fastmap_iter): Call __towlower
        instead of towlower.
        * posix/regex_internal.c (build_wcs_upper_buffer): Call __iswlower
        instead of iswlower.  Call __towupper instead of towupper.
        * posix/regex_internal.h (IS_WIDE_WORD_CHAR): Call __iswalnum
        instead of iswalnum.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog              |   14 ++++++++++++++
 NEWS                   |    2 +-
 include/wctype.h       |    4 ++++
 posix/regcomp.c        |    4 ++--
 posix/regex_internal.c |    8 ++++----
 posix/regex_internal.h |    2 +-
 wctype/wcfuncs.c       |    2 ++
 7 files changed, 28 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug regex/18495] regcomp wctype namespace

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18495

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.