[Bug libc/13134] New: posix_spawn() invokes sh on unknown executable image types

[Bug libc/13134] New: posix_spawn() invokes sh on unknown executable image types

[shea at shealevy dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13134

             Bug #: 13134
           Summary: posix_spawn() invokes sh on unknown executable image
                    types
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper.fsp@gmail.com
        ReportedBy: shea@shealevy.com
    Classification: Unclassified


The current glibc implementation of posix_spawn() invokes /bin/sh if execve
sets errno to ENOEXEC. This is not specified by the POSIX.2004 definition
(http://pubs.opengroup.org/onlinepubs/009695399/functions/posix_spawn.html), is
different from the behavior of the sample implementation in the POSIX.2004
rationale section
(http://pubs.opengroup.org/onlinepubs/009604599/xrat/xsh_chap03.html), and
seems to have the same security risks that system() and popen() do in
set{u,g}id executables. In particular, the Rationale section says "The
effective behavior of a successful invocation of posix_spawn() is as if the
operation were implemented with POSIX operations as follows:", which as I've
said is followed by an implementation that behaves differently than the glibc
posix_spawn(). This appears to be non-compliant behavior.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13134] posix_spawn() invokes sh on unknown executable image types

[shea at shealevy dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13134

Shea Levy <shea at shealevy dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shea at shealevy dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13134] posix_spawn() invokes sh on unknown executable image types

[bugdal at aerifal dot cx]

http://sourceware.org/bugzilla/show_bug.cgi?id=13134

Rich Felker <bugdal at aerifal dot cx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugdal at aerifal dot cx

--- Comment #1 from Rich Felker <bugdal at aerifal dot cx> 2011-08-26 06:12:58 UTC ---
Confirmed. My cynical prediction is that this bug will be ignored either for
"compatibility reasons" or because of the fact that someone obviously went to a
bit of trouble to write that completely wrong code for shell invocation that
doesn't even belong in spawni.c. Please prove me wrong...

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13134] posix_spawn() invokes sh on unknown executable image types

[shea at shealevy dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13134

--- Comment #2 from Shea Levy <shea at shealevy dot com> 2011-08-26 08:35:19 UTC ---
Created attachment 5915
  --> http://sourceware.org/bugzilla/attachment.cgi?id=5915
Trivial fix

This patch removes the non-compliant behaviour.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13134] posix_spawn() invokes sh on unknown executable image types

[drepper.fsp at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13134

Ulrich Drepper <drepper.fsp at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Ulrich Drepper <drepper.fsp at gmail dot com> 2011-09-06 00:26:50 UTC ---
You really don't know what binary compatibility means, right?  git contains a
change.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13134] posix_spawn() invokes sh on unknown executable image types

[shea at shealevy dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13134

--- Comment #4 from Shea Levy <shea at shealevy dot com> 2011-09-06 00:38:09 UTC ---
(In reply to comment #3)
> You really don't know what binary compatibility means, right?  git contains a
> change.

Sorry, my fix was far too naive. I shouldn't have submitted that patch at all
if I wasn't going to take the time to get it right.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13134] posix_spawn() invokes sh on unknown executable image types

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13134

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/13134] posix_spawn() invokes sh on unknown executable image types

[bruno at clisp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=13134

Bruno Haible <bruno at clisp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bruno at clisp dot org

--- Comment #5 from Bruno Haible <bruno at clisp dot org> ---
The change from 2011 had no effect on the Hurd.
The Hurd case has been fixed now, by Samuel Thibault:
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=13adfa34aff03fd9f1c1612b537a0d736ddb6c2b

-- 
You are receiving this mail because:
You are on the CC list for the bug.