[Bug libc/13324] New: sys/mount.h on linux defines poorly-namespaced macro BLOCK_SIZE

[Bug libc/13324] New: sys/mount.h on linux defines poorly-namespaced macro BLOCK_SIZE

[pelzlpj at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13324

             Bug #: 13324
           Summary: sys/mount.h on linux defines poorly-namespaced macro
                    BLOCK_SIZE
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper.fsp@gmail.com
        ReportedBy: pelzlpj@gmail.com
    Classification: Unclassified


sysdeps/unix/sysv/linux/sys/mount.h includes the following macro definitions:

    #define BLOCK_SIZE      1024
    #define BLOCK_SIZE_BITS 10

Both of these names, especially BLOCK_SIZE, are quite likely to be found in a
wide variety of code bases.  They are too generic to be safely defined in a
libc header.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13324] sys/mount.h on linux defines poorly-namespaced macro BLOCK_SIZE

[bugdal at aerifal dot cx]

http://sourceware.org/bugzilla/show_bug.cgi?id=13324

Rich Felker <bugdal at aerifal dot cx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugdal at aerifal dot cx

--- Comment #1 from Rich Felker <bugdal at aerifal dot cx> 2011-10-20 03:00:26 UTC ---
In fairness, sys/mount.h is not a standard libc header, and few programs except
"mount" have any business including it in the first place... If you want this
addressed I think you'd better describe the real world situation you're
encountering (what sort of program is including sys/mount.h, for what purpose,
and whether it's including it just in one specific module that uses it or in
all modules perhaps implicitly through nested includes, etc.). My prediction
though is that this one will be RESOLVED/INVALID in a hurry...

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13324] sys/mount.h on linux defines poorly-namespaced macro BLOCK_SIZE

[drepper.fsp at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13324

Ulrich Drepper <drepper.fsp at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #2 from Ulrich Drepper <drepper.fsp at gmail dot com> 2011-10-23 20:59:44 UTC ---
(In reply to comment #0)
> Both of these names, especially BLOCK_SIZE, are quite likely to be found in a
> wide variety of code bases.  They are too generic to be safely defined in a
> libc header.

Even if I would agree, there is no reason to break existing programs.  The API
must be stable.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13324] sys/mount.h on linux defines poorly-namespaced macro BLOCK_SIZE

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13324

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.