public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/13336] New: Add missing buffer termination in readlinkat() unit test
@ 2011-10-24 14:56 thomas.jarosch at intra2net dot com
  2011-10-29 16:12 ` [Bug libc/13336] " drepper.fsp at gmail dot com
  2014-06-27 11:49 ` fweimer at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: thomas.jarosch at intra2net dot com @ 2011-10-24 14:56 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13336

             Bug #: 13336
           Summary: Add missing buffer termination in readlinkat() unit
                    test
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper.fsp@gmail.com
        ReportedBy: thomas.jarosch@intra2net.com
    Classification: Unclassified


Created attachment 6028
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6028
Patch to fix the issue

>From the patch:

Add missing buffer termination in readlinkat() unit test

readlinkat() never zero terminates the buffer.

Also make sure we don't overflow the buffer if readlinkat() returns
the full size of the buffer by reducing the supplied size.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libc/13336] Add missing buffer termination in readlinkat() unit test
  2011-10-24 14:56 [Bug libc/13336] New: Add missing buffer termination in readlinkat() unit test thomas.jarosch at intra2net dot com
@ 2011-10-29 16:12 ` drepper.fsp at gmail dot com
  2014-06-27 11:49 ` fweimer at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: drepper.fsp at gmail dot com @ 2011-10-29 16:12 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13336

Ulrich Drepper <drepper.fsp at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Ulrich Drepper <drepper.fsp at gmail dot com> 2011-10-29 16:11:47 UTC ---
Completely unnecessary and actually wrong.  The length is tested first and then
strncmp is used.  The test deliberately doesn't depend on NUL termination.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libc/13336] Add missing buffer termination in readlinkat() unit test
  2011-10-24 14:56 [Bug libc/13336] New: Add missing buffer termination in readlinkat() unit test thomas.jarosch at intra2net dot com
  2011-10-29 16:12 ` [Bug libc/13336] " drepper.fsp at gmail dot com
@ 2014-06-27 11:49 ` fweimer at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: fweimer at redhat dot com @ 2014-06-27 11:49 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13336

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-27 11:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-24 14:56 [Bug libc/13336] New: Add missing buffer termination in readlinkat() unit test thomas.jarosch at intra2net dot com
2011-10-29 16:12 ` [Bug libc/13336] " drepper.fsp at gmail dot com
2014-06-27 11:49 ` fweimer at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).