[Bug libc/13695] New: glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[Bug libc/13695] New: glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[asharif.tools at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

             Bug #: 13695
           Summary: glibc doesn't build properly with
                    -frecord-gcc-switches in CFLAGS
           Product: glibc
           Version: 2.11
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper.fsp@gmail.com
        ReportedBy: asharif.tools@gmail.com
    Classification: Unclassified


Reproduction:

1. Build a toolchain with CFLAGS="-frecord-gcc-switches".
2. Try building an executable with gold as the linker. It will fail.

See: http://sources.redhat.com/ml/binutils/2011-11/msg00238.html

The reason is the following:

"""The glibc/csu/Makefile runs this code through a sed script that
deletes everything between HEADER_ENDS and _init_PROLOG_BEGINS, which
loses the ".text" directive, and the code for call_gmon_start ends up
placed in the .GCC.command.line section."""

taken from this ML thread:

http://sources.redhat.com/ml/binutils/2012-02/msg00109.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[tschwinge at sourceware dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

Thomas Schwinge <tschwinge at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |tschwinge at sourceware dot
                   |                            |org

--- Comment #1 from Thomas Schwinge <tschwinge at sourceware dot org> 2012-02-15 19:52:16 UTC ---
First, 2.11 is very old, and not really actively supported.

Please, next time provide more information.  Which architecture are you
on, for example?

Is this still an issue with the current Git master branch?  We're
currently in the process of getting rid of the ``sed magic'' you're
mentioning; see recent libc-alpha emails with subject lines mentioning
crti/crtn, and similar.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[asharif.tools at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

--- Comment #2 from asharif.tools at gmail dot com 2012-02-16 02:33:58 UTC ---
Some more information:

1. CTARGET=i686-pc-linux-gnu
2. CHOST=x86_64-pc-linux-gnu

I am building a cross-toolchain with:

1. binutils-2.21.1
2. gcc-4.6.2
3. glibc-2.11

I try a more recent glibc and will report back here. The email on binutils ML
is fairly recent but I am not sure what glibc version was tried by Karlsen in
this message: http://sources.redhat.com/ml/binutils/2011-11/msg00237.html.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[asharif.tools at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

--- Comment #3 from asharif.tools at gmail dot com 2012-02-16 04:27:51 UTC ---
Created attachment 6216
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6216
This patch fixes the problem for glibc-2.11.

The same code exists in the latest glibc .git repository as of
fb59b3a4f54777652dc877a1df0fcc009b741d87, so I have reason to believe that this
bug still exists.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[asharif.tools at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

--- Comment #4 from asharif.tools at gmail dot com 2012-02-16 04:29:12 UTC ---
I have not been able to build the latest glibc ToT, but by just inspecting the
csu Makefile, I have reason to believe that this bug still exists in ToT.
Please take a look at the patch and let me know if it's acceptable (I have
verified that 2.11 works with this patch and -frecord-gcc-switches in the
CFLAGS).

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[tschwinge at sourceware dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

Thomas Schwinge <tschwinge at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|drepper.fsp at gmail dot    |tschwinge at sourceware dot
                   |com                         |org

--- Comment #5 from Thomas Schwinge <tschwinge at sourceware dot org> 2012-02-16 11:45:07 UTC ---
What does ToT mean?


Why/how does building the Git master branch fail for you?  Please always
provide specific error messages, etc.


Yes, the code is still there, but it is not used anymore -- in the very
recent Git master branch -- for most configurations (including yours),
and is scheduled for removal soon; see
<http://sourceware.org/ml/libc-alpha/2012-02/msg00153.html>.


In <http://sourceware.org/ml/binutils/2012-02/msg00114.html> I eventually
found a proper analysis of what is going wrong in the
-frecord-gcc-switches case: there is a non-text section before the text
section (dummy function) begins, but the ``.text'' statement will be
snipped away with the dummy function.  Your appears to be fine as a
band-aid, but I don't think the maintainers will want to apply it -- as
this issue will disappear/already has disappeared with the new crti/crtn
setup.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[vapier at gentoo dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |toolchain at gentoo dot org

--- Comment #6 from Mike Frysinger <vapier at gentoo dot org> 2012-02-17 17:34:16 UTC ---
ToT is "tip of tree"

i guess this issue is obsolete now that the crt handling has been rewritten and
arches are all migrating to that:
http://sourceware.org/ml/libc-alpha/2012-02/msg00088.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[jsm28 at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13695

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Joseph Myers <jsm28 at gcc dot gnu.org> 2012-02-21 00:51:41 UTC ---
The old initfini mechanism has now been removed, so this problem can no longer
occur on git master.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13695] glibc doesn't build properly with -frecord-gcc-switches in CFLAGS

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13695

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.