[Bug libc/13740] New: lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[Bug libc/13740] New: lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[freeordie.k at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13740

             Bug #: 13740
           Summary: lio_listio: when pass aiocb with a invalid
                    aio_lio_opcode, __error_code is not set
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: unassigned@sourceware.org
        ReportedBy: freeordie.k@gmail.com
                CC: drepper.fsp@gmail.com
    Classification: Unclassified


when pass aiocb with a invalid aio_lio_opcode, the values gets passed down to
the AIO layer.

It checks aio_lio_opcode in sysdeps/pthread/aio_misc.c, when aio_lio_opcode is 
not valid, it set aiocb.__return_value but doesn't set __error_code.

Line 584:
          else
            {
              /* This is an invalid opcode.  */
              aiocbp->aiocb.__return_value = -1;
              __set_errno (EINVAL);
            }

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13740] lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13740

Carlos O'Donell <carlos at systemhalted dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at systemhalted dot
                   |                            |org

--- Comment #1 from Carlos O'Donell <carlos at systemhalted dot org> 2012-02-24 14:06:49 UTC ---
Kai,

Would you mind writing a small test case that shows the behaviour?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13740] lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13740

Carlos O'Donell <carlos at systemhalted dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13740] lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[freeordie.k at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13740

--- Comment #2 from Kai Kang <freeordie.k at gmail dot com> 2012-02-28 08:36:09 UTC ---
Created attachment 6254
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6254
Test struct aiocb with invalid aio_lio_opcode for lio_list()

Output:
ret is -1, error_code is 22, return code is -1

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13740] lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[freeordie.k at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13740

--- Comment #3 from Kai Kang <freeordie.k at gmail dot com> 2012-02-28 08:38:19 UTC ---
(In reply to comment #1)
> Kai,
> 
> Would you mind writing a small test case that shows the behaviour?

Carlos,

I simply test case from POSIX, but I not sure that is you requires.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13740] lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13740

--- Comment #4 from Carlos O'Donell <carlos at systemhalted dot org> 2012-02-28 16:16:02 UTC ---
Kai,

I'm looking for a test case that shows that glibc does not return an error code
on invalid input. In your example the input is invalid, and the return is
correct EINVAL=22.

The test case should return 0 if it passes e.g. You passed in an invalid value
and got back the correct error code.

The test case should return 1 if it fails e.g. you passed in an invalid value
and got back no error code or the wrong error code.

Does that help clarify what I'm looking for?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13740] lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13740

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug librt/13740] lio_listio: when pass aiocb with a invalid aio_lio_opcode, __error_code is not set

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=13740

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libc                        |librt

-- 
You are receiving this mail because:
You are on the CC list for the bug.