public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug admin/13746] New: auto-annotate bugzilla from git commits
@ 2012-02-24 18:01 roland at gnu dot org
  2012-06-21 17:16 ` [Bug admin/13746] " hjl.tools at gmail dot com
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: roland at gnu dot org @ 2012-02-24 18:01 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

             Bug #: 13746
           Summary: auto-annotate bugzilla from git commits
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: admin
        AssignedTo: unassigned@sourceware.org
        ReportedBy: roland@gnu.org
                CC: carlos@systemhalted.org, roland@gnu.org
    Classification: Unclassified


We used to have this under CVS, based on the [BZ #nnn] convention in ChangeLog
entries.  We should have it again for git.


Jim Meyering is the general expert in sourceware git setup, and may have
suggestions.  He is responsible for the current post-receive hook that
sends email, but that appears to be just a copy of a stock contrib script
distributed with git.

I looked at all the other projects' hooks/post-receive files and there
doesn't appear to be any that did anything interesting other than use the
same email-sending script we have now.

The old CVS setup was controlled by these lines in CVSROOT/loginfo:

# -T foo        distinguisher for tmp files
# -G glibc      bugzilla "product" field
# -m user@dom   email recipient
# -D domain     email domain sent from
# -U url        cvsweb url
# -C glibc      cvsweb ?cvsroot=<argument>
# -s %{sVv}     magic args
DEFAULT (/usr/sourceware/bin/log_accum_bugzillafied -T glibc -G glibc -C glibc
-D sourceware.org -U "http://sourceware.org/cgi-bin/cvsweb.cgi/"; -m
glibc-cvs@sourceware.org -s %{sVv})

That script can be seen at:
   
http://sourceware.org/cgi-bin/cvsweb.cgi/infra/bin/log_accum_bugzillafied?rev=1.3&content-type=text/x-cvsweb-markup&cvsroot=sourceware

Ian Taylor was the last person to touch it, but I don't know who is the
best person to ask about any details.  It appears to work by a combination
of looking at the local database backing bugzilla, and sending formulaic
email to <sourceware-bugzilla@sourceware.org> to make the posts.

I don't really even know any more who to talk to about the bugzilla setup
itself.  So I guess the best place for someone to start here would be to
ping both Jim and overseers@sourceware.org about where to go next.

For stock solutions, a quick search found http://www.theoldmonk.net/gitzilla/
but I have no idea whether that's compatible with the sourceware bugzilla
installation or if the maintainers of sourceware bugzilla would want it
installed, or if it can be easily configured to work with the conventions
we use.

https://wiki.mozilla.org/Bugzilla:Addons#Integration_with_Source_Code_Management_utilities
points to a different thing, but via a link to a blog entry on a server
that says (in French) that the server is dead.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
@ 2012-06-21 17:16 ` hjl.tools at gmail dot com
  2013-03-20 12:25 ` jsm28 at gcc dot gnu.org
                   ` (21 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: hjl.tools at gmail dot com @ 2012-06-21 17:16 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-06-21 17:16:24 UTC ---
http://www.theoldmonk.net/gitzilla/

says

Requirements

To install and run GitZilla, you need:

        Python (tested with 2.6.4, should work with >=2.5)
        pybugz (tested with 0.8.0)

Of course, to make it useful you also need a Bugzilla installation somewhere
(not required to be on the same machine). GitZilla has been tested with
Bugzilla 3.0.11 and should work with any Bugzilla version supported by pybugz.

The excellent pybugz can be obtained from http://github.com/ColdWind/pybugz/
and http://github.com/ColdWind/pybugz/downloads/

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
  2012-06-21 17:16 ` [Bug admin/13746] " hjl.tools at gmail dot com
@ 2013-03-20 12:25 ` jsm28 at gcc dot gnu.org
  2013-03-20 14:51 ` carlos at redhat dot com
                   ` (20 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-03-20 12:25 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> 2013-03-20 12:25:01 UTC ---
Carlos, after the sourceware upgrade this should be unblocked (sourceware now
has new-enough Python).

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
  2012-06-21 17:16 ` [Bug admin/13746] " hjl.tools at gmail dot com
  2013-03-20 12:25 ` jsm28 at gcc dot gnu.org
@ 2013-03-20 14:51 ` carlos at redhat dot com
  2013-03-21 22:58 ` carlos at redhat dot com
                   ` (19 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: carlos at redhat dot com @ 2013-03-20 14:51 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> 2013-03-20 14:51:20 UTC ---
I'm talking to overseers about enabling gitzilla integration so we can get
commits into BZs.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (2 preceding siblings ...)
  2013-03-20 14:51 ` carlos at redhat dot com
@ 2013-03-21 22:58 ` carlos at redhat dot com
  2013-08-12  9:04 ` tromey at redhat dot com
                   ` (18 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: carlos at redhat dot com @ 2013-03-21 22:58 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> 2013-03-21 22:57:42 UTC ---
I hasn't been ruled out, but I have to see what we can do to convince overseers
to let glibc prototype the use of gitzilla. It would be useful to all other
sourceware projects using git. This isn't going to be solved shortly.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (3 preceding siblings ...)
  2013-03-21 22:58 ` carlos at redhat dot com
@ 2013-08-12  9:04 ` tromey at redhat dot com
  2013-10-15 13:38 ` tromey at redhat dot com
                   ` (17 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tromey at redhat dot com @ 2013-08-12  9:04 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at redhat dot com

--- Comment #5 from Tom Tromey <tromey at redhat dot com> ---
It looked simple to me to hack up log_accum_bugzillafied
and the post-receive script.  I'm testing that combo now
as part of bug #14768.  There's no reason it wouldn't work
for glibc as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (4 preceding siblings ...)
  2013-08-12  9:04 ` tromey at redhat dot com
@ 2013-10-15 13:38 ` tromey at redhat dot com
  2013-10-15 13:50 ` carlos at redhat dot com
                   ` (16 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tromey at redhat dot com @ 2013-10-15 13:38 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #6 from Tom Tromey <tromey at redhat dot com> ---
(In reply to Tom Tromey from comment #5)
> It looked simple to me to hack up log_accum_bugzillafied
> and the post-receive script.  I'm testing that combo now
> as part of bug #14768.  There's no reason it wouldn't work
> for glibc as well.

I think this works pretty well now.
To enable it, on sourceware:

* Replace glibc.git/hooks/post-receive with a symlink to
  /usr/share/doc/git-core/contrib/hooks/post-receive-email
  This is derived from the same script currently used by glibc.

* Add some configury to glibc.git/config following the instructions
  in the new post-receive.  For glibc I think it is enough to add
  this to the [hooks] section:

   bugzillaproduct = glibc

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (5 preceding siblings ...)
  2013-10-15 13:38 ` tromey at redhat dot com
@ 2013-10-15 13:50 ` carlos at redhat dot com
  2013-10-15 14:00 ` tromey at redhat dot com
                   ` (15 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: carlos at redhat dot com @ 2013-10-15 13:50 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #7 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Tom Tromey from comment #6)
> (In reply to Tom Tromey from comment #5)
> > It looked simple to me to hack up log_accum_bugzillafied
> > and the post-receive script.  I'm testing that combo now
> > as part of bug #14768.  There's no reason it wouldn't work
> > for glibc as well.
> 
> I think this works pretty well now.
> To enable it, on sourceware:
> 
> * Replace glibc.git/hooks/post-receive with a symlink to
>   /usr/share/doc/git-core/contrib/hooks/post-receive-email
>   This is derived from the same script currently used by glibc.
> 
> * Add some configury to glibc.git/config following the instructions
>   in the new post-receive.  For glibc I think it is enough to add
>   this to the [hooks] section:
> 
>    bugzillaproduct = glibc

Do you know this because you just enabled it for gdb and it works?

If it works for gdb I'd love to just turn it on for glibc.

Do I just ask overseers for help?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (6 preceding siblings ...)
  2013-10-15 13:50 ` carlos at redhat dot com
@ 2013-10-15 14:00 ` tromey at redhat dot com
  2013-10-15 15:01 ` carlos at redhat dot com
                   ` (14 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tromey at redhat dot com @ 2013-10-15 14:00 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #8 from Tom Tromey <tromey at redhat dot com> ---
(In reply to Carlos O'Donell from comment #7)

> 
> Do you know this because you just enabled it for gdb and it works?

I wrote it for the gdb/binutils git conversion and spent last week
trying it out.
It's possible that it still has bugs of course, but I think it is
reasonably well-debugged.

> If it works for gdb I'd love to just turn it on for glibc.
> 
> Do I just ask overseers for help?

I can do it if you like.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (7 preceding siblings ...)
  2013-10-15 14:00 ` tromey at redhat dot com
@ 2013-10-15 15:01 ` carlos at redhat dot com
  2013-10-15 15:27 ` joseph at codesourcery dot com
                   ` (13 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: carlos at redhat dot com @ 2013-10-15 15:01 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #9 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Tom Tromey from comment #8)
> (In reply to Carlos O'Donell from comment #7)
> 
> > 
> > Do you know this because you just enabled it for gdb and it works?
> 
> I wrote it for the gdb/binutils git conversion and spent last week
> trying it out.
> It's possible that it still has bugs of course, but I think it is
> reasonably well-debugged.
> 
> > If it works for gdb I'd love to just turn it on for glibc.
> > 
> > Do I just ask overseers for help?
> 
> I can do it if you like.

Please do. Between Roland, H.J. Lu, Joseph, and myself that's enough consensus
to enable this for glibc. We're happy to work out any kinks.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (8 preceding siblings ...)
  2013-10-15 15:01 ` carlos at redhat dot com
@ 2013-10-15 15:27 ` joseph at codesourcery dot com
  2013-10-15 15:35 ` tromey at redhat dot com
                   ` (12 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: joseph at codesourcery dot com @ 2013-10-15 15:27 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #10 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Tue, 15 Oct 2013, tromey at redhat dot com wrote:

> * Replace glibc.git/hooks/post-receive with a symlink to
>   /usr/share/doc/git-core/contrib/hooks/post-receive-email
>   This is derived from the same script currently used by glibc.

I don't see such a file on sourceware.  There are lots of 
post-receive-email files - which do you mean?

For glibc-cvs mails we show the complete diffs of the commit, but I don't 
think we want the full diffs (which can be very large) to show in Bugzilla 
comments.  Can it be configured to show less information in Bugzilla than 
in glibc-cvs?

How does this hook identify relevant bugs?  In ChangeLog entries in glibc 
we use [BZ #N]; conventions in git logs are less defined, but "bug N", 
"bug #N" and "BZ #N" are common.  We would in any case need to inform 
libc-alpha of the patterns to use in git logs, and update the contribution 
/ commit checklists accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (9 preceding siblings ...)
  2013-10-15 15:27 ` joseph at codesourcery dot com
@ 2013-10-15 15:35 ` tromey at redhat dot com
  2013-10-18 15:56 ` tromey at redhat dot com
                   ` (11 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tromey at redhat dot com @ 2013-10-15 15:35 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #11 from Tom Tromey <tromey at redhat dot com> ---
(In reply to joseph@codesourcery.com from comment #10)
> On Tue, 15 Oct 2013, tromey at redhat dot com wrote:
> 
> > * Replace glibc.git/hooks/post-receive with a symlink to
> >   /usr/share/doc/git-core/contrib/hooks/post-receive-email
> >   This is derived from the same script currently used by glibc.
> 
> I don't see such a file on sourceware.  There are lots of 
> post-receive-email files - which do you mean?

Sorry, I copied the wrong file name.
It is really /sourceware/infra/bin/post-receive-email

> For glibc-cvs mails we show the complete diffs of the commit, but I don't 
> think we want the full diffs (which can be very large) to show in Bugzilla 
> comments.  Can it be configured to show less information in Bugzilla than 
> in glibc-cvs?

Yes, from the comments in the file:

# hooks.bugzillashowrev
#   Like hooks.showrev, but only used for the bugzilla notification.
#   Defaults to hooks.showrev.

You'll want to test this, though, since I don't think I ended up using
this feature for src.git.

> How does this hook identify relevant bugs?  In ChangeLog entries in glibc 
> we use [BZ #N]; conventions in git logs are less defined, but "bug N", 
> "bug #N" and "BZ #N" are common.  We would in any case need to inform 
> libc-alpha of the patterns to use in git logs, and update the contribution 
> / commit checklists accordingly.

It does exactly what log_accum_bugzilla used to do, which is:

while ($log_txt =~
m/[^Aa](?:bug|PR|BZ)\s+\#?\s*(?:[a-z+-]+\/)?(?:\/)?(\d+)(.*)$/si) {
  $bug_id = $1;
  $log_txt = $2;

Somewhat unreadable I suppose.  I didn't edit the regexp when I
pulled out the bugzilla bits into a new script.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (10 preceding siblings ...)
  2013-10-15 15:35 ` tromey at redhat dot com
@ 2013-10-18 15:56 ` tromey at redhat dot com
  2013-10-18 16:27 ` carlos at redhat dot com
                   ` (10 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tromey at redhat dot com @ 2013-10-18 15:56 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at sourceware dot org   |tromey at redhat dot com

--- Comment #12 from Tom Tromey <tromey at redhat dot com> ---
I installed this with the settings:

    bugzillashowrev = "t=%s; printf
'https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=%%s' $t; echo; echo; git
rev-list -1 --pretty $t"
    bugzillaproduct = glibc

This means the full patch should not show up in bugzilla.

Please give it a try and let me know if something is broken.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (11 preceding siblings ...)
  2013-10-18 15:56 ` tromey at redhat dot com
@ 2013-10-18 16:27 ` carlos at redhat dot com
  2013-10-20  8:45 ` schwab@linux-m68k.org
                   ` (9 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: carlos at redhat dot com @ 2013-10-18 16:27 UTC (permalink / raw)
  To: glibc-bugs

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 3636 bytes --]

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #13 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Tom Tromey from comment #12)
> I installed this with the settings:
> 
> 	bugzillashowrev = "t=%s; printf
> 'https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=%%s' $t; echo; echo;
> git rev-list -1 --pretty $t"
> 	bugzillaproduct = glibc
> 
> This means the full patch should not show up in bugzilla.
> 
> Please give it a try and let me know if something is broken.

Tom,

Thank you very much for your work in getting this setup!

Cheers,
Carlos.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From glibc-bugs-return-19871-listarch-glibc-bugs=sources.redhat.com@sourceware.org Fri Oct 18 16:41:38 2013
Return-Path: <glibc-bugs-return-19871-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-glibc-bugs@sources.redhat.com
Received: (qmail 10862 invoked by alias); 18 Oct 2013 16:41:38 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Delivered-To: mailing list glibc-bugs@sourceware.org
Received: (qmail 10804 invoked by uid 48); 18 Oct 2013 16:41:33 -0000
From: "opengeometry at yahoo dot ca" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/16059] wordexp(3) -- A[0]='a b' gives error
Date: Fri, 18 Oct 2013 16:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: opengeometry at yahoo dot ca
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created
Message-ID: <bug-16059-131-1LZvOCQ8CU@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-16059-131@http.sourceware.org/bugzilla/>
References: <bug-16059-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg00230.txt.bz2
Content-length: 974

https://sourceware.org/bugzilla/show_bug.cgi?id\x16059

William Park <opengeometry at yahoo dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7241|0                           |1
        is obsolete|                            |

--- Comment #3 from William Park <opengeometry at yahoo dot ca> ---
Created attachment 7242
  --> https://sourceware.org/bugzilla/attachment.cgi?idr42&actioníit
Don't split on whitespace inside quoted string in glob pattern

wordexp(3) stops on whitespace when scanning for glob pattern, even if it
occurs inside quoted string (single or double).  So, this patch suppresses
splitting on whitespaces when inside quote for glob pattern.

PS.  Perhaps we should add WRDE_NOGLOB flag to prevent globbing, just like
WRDE_NOCMD for command substitution.

--
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (12 preceding siblings ...)
  2013-10-18 16:27 ` carlos at redhat dot com
@ 2013-10-20  8:45 ` schwab@linux-m68k.org
  2013-10-24  8:21 ` schwab@linux-m68k.org
                   ` (8 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: schwab@linux-m68k.org @ 2013-10-20  8:45 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #14 from Andreas Schwab <schwab@linux-m68k.org> ---
The mails are not properly encoded, see
<http://sourceware.org/ml/glibc-bugs/2013-10/msg00238.html>.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (13 preceding siblings ...)
  2013-10-20  8:45 ` schwab@linux-m68k.org
@ 2013-10-24  8:21 ` schwab@linux-m68k.org
  2013-10-24 15:33 ` joseph at codesourcery dot com
                   ` (7 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: schwab@linux-m68k.org @ 2013-10-24  8:21 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #15 from Andreas Schwab <schwab@linux-m68k.org> ---
Annotations should not be added for personal branches.

<http://sourceware.org/ml/glibc-bugs/2013-10/msg00298.html>

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (14 preceding siblings ...)
  2013-10-24  8:21 ` schwab@linux-m68k.org
@ 2013-10-24 15:33 ` joseph at codesourcery dot com
  2013-10-24 16:46 ` carlos at redhat dot com
                   ` (6 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: joseph at codesourcery dot com @ 2013-10-24 15:33 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #16 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
That is, they should be added for commits to master or release/*, but not 
any other branch (I think personal branches and company / distribution 
ones should be considered the same).  But all branches should continue to 
get the mails to glibc-cvs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (15 preceding siblings ...)
  2013-10-24 15:33 ` joseph at codesourcery dot com
@ 2013-10-24 16:46 ` carlos at redhat dot com
  2013-10-24 19:30 ` tromey at redhat dot com
                   ` (5 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: carlos at redhat dot com @ 2013-10-24 16:46 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
           Assignee|tromey at redhat dot com           |carlos at redhat dot com

--- Comment #17 from Carlos O'Donell <carlos at redhat dot com> ---
I'm reopening to discuss the various tweaks we want to the auto-annotate.

* Wrong encoding
  - This is a valid issues that needs fixing.
  - Tom Tromey is aware of this and looking into it.

* Script handles push not commits
  - This results in very very large comments if the push is large.
  - See https://sourceware.org/bugzilla/show_bug.cgi?id=15698#c1
  - Script should split push into commits and post only the commit that
    made the change.
  - Carlos O'Donell is working on this.

* Script posts comments based on private branches.
  - This needs to go to libc-alpha for policy discussion.
  - Joseph could you please take this to libc-alpha to get consensus?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (16 preceding siblings ...)
  2013-10-24 16:46 ` carlos at redhat dot com
@ 2013-10-24 19:30 ` tromey at redhat dot com
  2013-10-25 15:15 ` joseph at codesourcery dot com
                   ` (4 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tromey at redhat dot com @ 2013-10-24 19:30 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #18 from Tom Tromey <tromey at redhat dot com> ---
(In reply to Andreas Schwab from comment #14)
> The mails are not properly encoded, see
> <http://sourceware.org/ml/glibc-bugs/2013-10/msg00238.html>.

Not really sure where the error creeps in.
It doesn't seem to be too likely to be the post-receive script.
Perhaps we need to emit a content-type header to say that
the text is utf-8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (17 preceding siblings ...)
  2013-10-24 19:30 ` tromey at redhat dot com
@ 2013-10-25 15:15 ` joseph at codesourcery dot com
  2013-10-25 21:05 ` tromey at redhat dot com
                   ` (3 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: joseph at codesourcery dot com @ 2013-10-25 15:15 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #19 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Thu, 24 Oct 2013, carlos at redhat dot com wrote:

> * Script posts comments based on private branches.
>   - This needs to go to libc-alpha for policy discussion.
>   - Joseph could you please take this to libc-alpha to get consensus?

My comment was simply a refinement of Andreas's.

I hope my more specific point that the comments need to identify the 
branch affected, which they don't at present, is obvious.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (18 preceding siblings ...)
  2013-10-25 15:15 ` joseph at codesourcery dot com
@ 2013-10-25 21:05 ` tromey at redhat dot com
  2014-02-16 18:25 ` jackie.rosen at hushmail dot com
                   ` (2 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tromey at redhat dot com @ 2013-10-25 21:05 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

--- Comment #20 from Tom Tromey <tromey at redhat dot com> ---
(In reply to Tom Tromey from comment #18)
> (In reply to Andreas Schwab from comment #14)
> > The mails are not properly encoded, see
> > <http://sourceware.org/ml/glibc-bugs/2013-10/msg00238.html>.
> 
> Not really sure where the error creeps in.
> It doesn't seem to be too likely to be the post-receive script.
> Perhaps we need to emit a content-type header to say that
> the text is utf-8.

I believe I've fixed this, see
https://sourceware.org/bugzilla/show_bug.cgi?id=15670

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (19 preceding siblings ...)
  2013-10-25 21:05 ` tromey at redhat dot com
@ 2014-02-16 18:25 ` jackie.rosen at hushmail dot com
  2014-05-28 19:43 ` schwab at sourceware dot org
  2014-06-26 15:15 ` fweimer at redhat dot com
  22 siblings, 0 replies; 24+ messages in thread
From: jackie.rosen at hushmail dot com @ 2014-02-16 18:25 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

Jackie Rosen <jackie.rosen at hushmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jackie.rosen at hushmail dot com

--- Comment #21 from Jackie Rosen <jackie.rosen at hushmail dot com> ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Page where seen: http://volichat.com/adult-chat-rooms
Marked for reference. Resolved as fixed @bugzilla.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (20 preceding siblings ...)
  2014-02-16 18:25 ` jackie.rosen at hushmail dot com
@ 2014-05-28 19:43 ` schwab at sourceware dot org
  2014-06-26 15:15 ` fweimer at redhat dot com
  22 siblings, 0 replies; 24+ messages in thread
From: schwab at sourceware dot org @ 2014-05-28 19:43 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

Andreas Schwab <schwab at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|jackie.rosen at hushmail dot com   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug admin/13746] auto-annotate bugzilla from git commits
  2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
                   ` (21 preceding siblings ...)
  2014-05-28 19:43 ` schwab at sourceware dot org
@ 2014-06-26 15:15 ` fweimer at redhat dot com
  22 siblings, 0 replies; 24+ messages in thread
From: fweimer at redhat dot com @ 2014-06-26 15:15 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=13746

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2014-06-26 15:15 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-24 18:01 [Bug admin/13746] New: auto-annotate bugzilla from git commits roland at gnu dot org
2012-06-21 17:16 ` [Bug admin/13746] " hjl.tools at gmail dot com
2013-03-20 12:25 ` jsm28 at gcc dot gnu.org
2013-03-20 14:51 ` carlos at redhat dot com
2013-03-21 22:58 ` carlos at redhat dot com
2013-08-12  9:04 ` tromey at redhat dot com
2013-10-15 13:38 ` tromey at redhat dot com
2013-10-15 13:50 ` carlos at redhat dot com
2013-10-15 14:00 ` tromey at redhat dot com
2013-10-15 15:01 ` carlos at redhat dot com
2013-10-15 15:27 ` joseph at codesourcery dot com
2013-10-15 15:35 ` tromey at redhat dot com
2013-10-18 15:56 ` tromey at redhat dot com
2013-10-18 16:27 ` carlos at redhat dot com
2013-10-20  8:45 ` schwab@linux-m68k.org
2013-10-24  8:21 ` schwab@linux-m68k.org
2013-10-24 15:33 ` joseph at codesourcery dot com
2013-10-24 16:46 ` carlos at redhat dot com
2013-10-24 19:30 ` tromey at redhat dot com
2013-10-25 15:15 ` joseph at codesourcery dot com
2013-10-25 21:05 ` tromey at redhat dot com
2014-02-16 18:25 ` jackie.rosen at hushmail dot com
2014-05-28 19:43 ` schwab at sourceware dot org
2014-06-26 15:15 ` fweimer at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).