[Bug libc/14132] New: Get rid of INTDEF/INTUSE and *_internal aliases

[Bug libc/14132] New: Get rid of INTDEF/INTUSE and *_internal aliases

[roland at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14132

             Bug #: 14132
           Summary: Get rid of INTDEF/INTUSE and *_internal aliases
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
        AssignedTo: unassigned@sourceware.org
        ReportedBy: roland@gnu.org
                CC: drepper.fsp@gmail.com
    Classification: Unclassified


The INTDEF and INTUSE macros and related *_internal function aliases are an old
mechanism that is superseded by the libc_hidden_proto stuff.  It's confusing to
have disparate mechanisms for addressing the same issue (PLT avoidance).
We should get rid of INTDEF/INTUSE entirely and just use libc_hidden_proto.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14132

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |polacek at redhat dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  620f462e88f6e7b59488a963b3c42d89035e4ba6 (commit)
      from  c763c5d27112be055920c46f3be8d05bc8b669da (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=620f462e88f6e7b59488a963b3c42d89035e4ba6

commit 620f462e88f6e7b59488a963b3c42d89035e4ba6
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Oct 8 23:19:32 2014 +0000

    Don't use INTUSE with __adjtimex (bug 14132).

    Bug 14132 is removal of the old INTDEF/INTUSE system of *_internal
    aliases as obsoleted by the hidden_proto / hidden_def system.  Various
    cases were cleaned up in 2012, but some remain.  This patch removes
    the use of this mechanism for __adjtimex.

    Tested for x86_64 that stripped installed shared libraries are
    unchanged by the patch.

        [BZ #14132]
        * sysdeps/unix/sysv/linux/include/sys/timex.h: New file.
        * sysdeps/unix/sysv/linux/adjtime.c [!ADJTIMEX] (ADJTIMEX): Do not
        use INTUSE.
        [!ADJTIMEX] (INTUSE(__adjtimex)): Remove declaration.
        * sysdeps/unix/sysv/linux/alpha/adjtime.c (__adjtimex_internal):
        Remove alias.
        (__adjtimex): Define using libc_hidden_ver.
        * sysdeps/unix/sysv/linux/ntp_gettime.c (INTUSE(__adjtimex)):
        Remove declaration.
        (ntp_gettime): Call __adjtimex directly.
        * sysdeps/unix/sysv/linux/ntp_gettimex.c (INTUSE(__adjtimex)):
        Remove declaration.
        (ntp_gettimex): Call __adjtimex directly.
        * sysdeps/unix/sysv/linux/syscalls.list (adjtimex): Remove
        __adjtimex_internal alias.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   19 +++++++++++++++++++
 sysdeps/unix/sysv/linux/adjtime.c                  |    3 +--
 sysdeps/unix/sysv/linux/alpha/adjtime.c            |    2 +-
 .../sysv/linux/include/sys/timex.h}                |   11 ++++++-----
 sysdeps/unix/sysv/linux/ntp_gettime.c              |    5 +----
 sysdeps/unix/sysv/linux/ntp_gettimex.c             |    5 +----
 sysdeps/unix/sysv/linux/syscalls.list              |    2 +-
 7 files changed, 30 insertions(+), 17 deletions(-)
 copy sysdeps/{powerpc/powerpc64/multiarch/bcopy-ppc64.c =>
unix/sysv/linux/include/sys/timex.h} (80%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5deeb190146967ac05828b1fa6821182668356aa (commit)
      from  454ac701e3639bfcb8919706319a685341536eda (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5deeb190146967ac05828b1fa6821182668356aa

commit 5deeb190146967ac05828b1fa6821182668356aa
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Oct 9 01:11:14 2014 +0000

    Remove stray *_internal aliases (bug 14132).

    This patch removes some stray (unused) *_internal aliases, and
    function prototypes with no corresponding definitions at all, at least
    some of which were missed in previous INTDEF / INTUSE removal.

    Not removed in this patch: __canonicalize_directory_name_internal,
    noticed in the course of preparing this patch, isn't an alias, but an
    actual function in sysdeps/mach/hurd/getcwd.c - apparently unused,
    however.

    Tested for x86_64 that installed stripped shared libraries are
    unchanged by this patch.

        [BZ #14132]
        * include/wctype.h [!_ISOMAC] (__iswalpha_l_internal): Remove
        declaration.
        [!_ISOMAC] (__iswdigit_l_internal): Likewise.
        [!_ISOMAC] (__iswspace_l_internal): Likewise.
        [!_ISOMAC] (__iswxdigit_l_internal): Likewise.
        [!_ISOMAC] (__iswctype_internal): Likewise.
        * stdio-common/siglist.c (_sys_siglist_internal): Remove alias.
        * sysdeps/unix/syscalls.list (chown): Remove __chown_internal
        alias.
        (fcntl): Remove __fcntl_internal alias.
        * sysdeps/unix/sysv/linux/hppa/syscalls.list (connect): Remove
        __connect_internal alias.
        * sysdeps/unix/sysv/linux/sparc/sparc64/syscalls.list (connect):
        Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   16 ++++++++++++++++
 include/wctype.h                                   |    9 ---------
 stdio-common/siglist.c                             |    1 -
 sysdeps/unix/syscalls.list                         |    4 ++--
 sysdeps/unix/sysv/linux/hppa/syscalls.list         |    2 +-
 .../unix/sysv/linux/sparc/sparc64/syscalls.list    |    2 +-
 6 files changed, 20 insertions(+), 14 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  cb8312455b85a4a6c998b4c4a892c28b74cc3c4d (commit)
      from  5deeb190146967ac05828b1fa6821182668356aa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=cb8312455b85a4a6c998b4c4a892c28b74cc3c4d

commit cb8312455b85a4a6c998b4c4a892c28b74cc3c4d
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Oct 9 11:22:33 2014 +0000

    Don't use INTDEF/INTUSE with __cxa_atexit (bug 14132).

    This patch removes use of the obsolete INTDEF/INTUSE mechanism for
    __cxa_atexit, replacing it with libc_hidden_def/libc_hidden_proto.

    Tested for x86_64 that installed stripped shared libraries are
    unchanged by the patch.

        [BZ #14132]
        * stdlib/cxa_atexit.c (__cxa_atexit): Use libc_hidden_def instead
        of INTDEF.
        * include/stdlib.h (__cxa_atexit_internal): Remove declaration.
        (__cxa_atexit): Use libc_hidden_proto.
        [!NOT_IN_libc] (__cxa_atexit): Remove macro definition.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog           |    7 +++++++
 include/stdlib.h    |    5 +----
 stdlib/cxa_atexit.c |    2 +-
 3 files changed, 9 insertions(+), 5 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  6bc6bd3b10e6c2fd4c656647aa643919b0519825 (commit)
      from  b8c80a7e0da28b6e94411ce7d589d2b09674b4b9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6bc6bd3b10e6c2fd4c656647aa643919b0519825

commit 6bc6bd3b10e6c2fd4c656647aa643919b0519825
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Oct 10 11:13:11 2014 +0000

    Don't use INTVARDEF/INTUSE with __libc_enable_secure (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTVARDEF / INTUSE
    mechanism, this patch replaces its use for __libc_enable_secure with
    the use of rtld_hidden_data_def and rtld_hidden_proto.

    Tested for x86_64 that installed stripped shared libraries are
    unchanged by the patch.

        [BZ #14132]
        * elf/dl-sysdep.c (__libc_enable_secure): Use rtld_hidden_data_def
        instead of INTVARDEF.
        (_dl_sysdep_start): Do not use INTUSE with __libc_enable_secure.
        * sysdeps/mach/hurd/dl-sysdep.c (__libc_enable_secure): Use
        rtld_hidden_data_def instead of INTVARDEF.
        (_dl_sysdep_start): Do not use INTUSE with __libc_enable_secure.
        * elf/dl-deps.c (expand_dst): Likewise.
        * elf/dl-load.c (_dl_dst_count): Likewise.
        (_dl_dst_substitute): Likewise.
        (decompose_rpath): Likewise.
        (_dl_init_paths): Likewise.
        (open_path): Likewise.
        (_dl_map_object): Likewise.
        * elf/rtld.c (dl_main): Likewise.
        (process_dl_audit): Likewise.
        (process_envvars): Likewise.
        * include/unistd.h [IS_IN_rtld] (__libc_enable_secure_internal):
        Remove declaration.
        (__libc_enable_secure): Use rtld_hidden_proto.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                     |   23 +++++++++++++++++++++++
 elf/dl-deps.c                 |    2 +-
 elf/dl-load.c                 |   14 +++++++-------
 elf/dl-sysdep.c               |    8 ++++----
 elf/rtld.c                    |   18 +++++++++---------
 include/unistd.h              |    5 +----
 sysdeps/mach/hurd/dl-sysdep.c |    6 +++---
 7 files changed, 48 insertions(+), 28 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  a13d0d745ca3ea5e80506db7de0498d74d44a5b7 (commit)
      from  f05e73f660d5cc3a72b46047c829ccf5e096c88b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a13d0d745ca3ea5e80506db7de0498d74d44a5b7

commit a13d0d745ca3ea5e80506db7de0498d74d44a5b7
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Oct 21 23:11:49 2014 +0000

    Don't use INTDEF with __ldexpf (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch removes the use of INTDEF for __ldexpf.  As far as I can tell,
    the resulting alias is completely unused.

    Tested for x86_64 that stripped installed shared libraries are
    unchanged by this patch.

        [BZ #14132]
        * math/s_ldexpf.c (__ldexpf): Do not use INTDEF.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog       |    5 +++++
 math/s_ldexpf.c |    1 -
 2 files changed, 5 insertions(+), 1 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  15f9c5dfaf999cfc53080b6ab2422935a6becf8e (commit)
      from  c6dfed243e0310bc3294c0fdf1816fceab024e9b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=15f9c5dfaf999cfc53080b6ab2422935a6becf8e

commit 15f9c5dfaf999cfc53080b6ab2422935a6becf8e
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Oct 23 21:43:41 2014 +0000

    Don't use INTDEF for powerpc32 compat symbols (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch removes the use of INTUSE to rename symbols in
    sysdeps/powerpc/powerpc32/libgcc-compat.S.  As the names in question
    are purely internal to this particular object and not used anywhere
    else, it doesn't matter at all whether __*_v_glibc20 or __*_internal
    is used, so this patch just removes the macros in question.

    Tested for powerpc32 that stripped installed shared libraries are
    unchanged by this patch.

        [BZ #14132]
        * sysdeps/powerpc/powerpc32/libgcc-compat.S (__ashldi3_v_glibc20):
        Remove macro definition.
        (__ashrdi3_v_glibc20): Likewise.
        (__lshrdi3_v_glibc20): Likewise.
        (__cmpdi2_v_glibc20): Likewise.
        (__ucmpdi2_v_glibc20): Likewise.
        [!_SOFT_FLOAT && !__NO_FPRS__] (__fixdfdi_v_glibc20): Likewise.
        [!_SOFT_FLOAT && !__NO_FPRS__] (__fixsfdi_v_glibc20): Likewise.
        [!_SOFT_FLOAT && !__NO_FPRS__] (__fixunsdfdi_v_glibc20): Likewise.
        [!_SOFT_FLOAT && !__NO_FPRS__] (__fixunssfdi_v_glibc20): Likewise.
        [!_SOFT_FLOAT && !__NO_FPRS__] (__floatdidf_v_glibc20): Likewise.
        [!_SOFT_FLOAT && !__NO_FPRS__] (__floatdisf_v_glibc20): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                 |   16 ++++++++++++++++
 sysdeps/powerpc/powerpc32/libgcc-compat.S |   14 --------------
 2 files changed, 16 insertions(+), 14 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  51e623f2419c9f33423fa8e36ed9a9ff0d05e17e (commit)
      from  03d41216fe09fc71a2750946af8fe2892bf4feb5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=51e623f2419c9f33423fa8e36ed9a9ff0d05e17e

commit 51e623f2419c9f33423fa8e36ed9a9ff0d05e17e
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Oct 28 17:12:57 2014 +0000

    Don't use INTDEF/INTUSE in unwind-dw2-fde.c (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch replaces its use in unwind-dw2-fde.c with hidden_def and
    hidden_proto.

    Tested for x86.  This patch does result in code generation differences
    (for some reason GCC decides to partition __register_frame_info_bases
    after the patch).

        [BZ #14132]
        * sysdeps/generic/unwind-dw2-fde.c
        (__register_frame_info_bases_internal): Do not declare.
        (__register_frame_info_table_bases_internal): Likewise.
        (__deregister_frame_info_bases_internal): Likewise.
        (__register_frame_info_bases): Declare and use hidden_proto before
        definition.  Use hidden_def instead of INTDEF.
        (__register_frame_info_table_bases): Likewise.
        (__deregister_frame_info_bases): Likewise.
        (__register_frame_info): Do not use INTUSE.
        (__register_frame): Likewise.
        (__register_frame_info_table): Likewise.
        (__register_frame_table): Likewise.
        (__deregister_frame_info): Likewise.
        (__deregister_frame): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                        |   18 ++++++++++++++++++
 sysdeps/generic/unwind-dw2-fde.c |   33 ++++++++++++++++++---------------
 2 files changed, 36 insertions(+), 15 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|fweimer at redhat dot com          |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  4243cbea6d30ce32b58abd8f1103156f8df617fa (commit)
      from  2004e7fb76bd6806253436d63ab3bda7e24c9cc1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4243cbea6d30ce32b58abd8f1103156f8df617fa

commit 4243cbea6d30ce32b58abd8f1103156f8df617fa
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Nov 4 17:39:39 2014 +0000

    Don't use INTDEF/INTUSE with _dl_argv (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch replaces its use for _dl_argv with rtld_hidden_data_def and
    rtld_hidden_proto.  Some places in .S files that previously used
    _dl_argv_internal or INTUSE(_dl_argv) now use __GI__dl_argv directly
    (there are plenty of existing examples of such direct use of __GI_*).

    A single place in rtld.c previously used _dl_argv without INTUSE,
    apparently accidentally, while the rtld_hidden_proto mechanism avoids
    such accidential omissions.  As a consequence, this patch *does*
    change the contents of stripped ld.so.  However, the installed
    stripped shared libraries are identical to those you get if instead of
    this patch you change that single _dl_argv use to use INTUSE, without
    any other changes.

    Tested for x86_64 (testsuite as well as comparison of installed
    stripped shared libraries as described above).

        [BZ #14132]
        * sysdeps/generic/ldsodefs.h (_dl_argv): Use rtld_hidden_proto.
        [IS_IN_rtld] (_dl_argv_internal): Do not declare.
        (rtld_progname): Make macro definition unconditional.
        * elf/rtld.c (_dl_argv): Use rtld_hidden_data_def instead of
        INTDEF.
        (dlmopen_doit): Do not use INTUSE with _dl_argv.
        (dl_main): Likewise.
        * elf/dl-sysdep.c (_dl_sysdep_start): Likewise.
        * sysdeps/alpha/dl-machine.h (RTLD_START): Use __GI__dl_argv
        instead of _dl_argv_internal.
        * sysdeps/powerpc/powerpc32/dl-start.S (_dl_start_user): Use
        __GI__dl_argv instead of INTUSE(_dl_argv).
        * sysdeps/powerpc/powerpc64/dl-machine.h (RTLD_START): Use
        __GI__dl_argv instead of _dl_argv_internal.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                              |   16 ++++++++++++
 elf/dl-sysdep.c                        |    2 +-
 elf/rtld.c                             |   40 ++++++++++++++++----------------
 sysdeps/alpha/dl-machine.h             |    6 ++--
 sysdeps/generic/ldsodefs.h             |   10 +------
 sysdeps/powerpc/powerpc32/dl-start.S   |    2 +-
 sysdeps/powerpc/powerpc64/dl-machine.h |    2 +-
 7 files changed, 44 insertions(+), 34 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c5684fdb2badfda3bd6e973e5f933272e39e9590 (commit)
      from  4243cbea6d30ce32b58abd8f1103156f8df617fa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c5684fdb2badfda3bd6e973e5f933272e39e9590

commit c5684fdb2badfda3bd6e973e5f933272e39e9590
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Nov 4 23:26:39 2014 +0000

    Don't use INTDEF/INTUSE with _dl_init (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch eliminates its use for _dl_init.  Since _dl_init was already
    declared with hidden visibility, creating a second hidden alias for it
    was completely pointless, so this patch replaces all uses of
    _dl_init_internal with plain _dl_init instead of using hidden_proto /
    hidden_def (which are only needed when you want a hidden alias for a
    non-hidden symbol; it's quite possible there are cases where they are
    used but don't need to be because the symbol in question is not part
    of the public ABI and is only used within a single library, so using
    attributes_hidden instead would suffice).

    Tested for x86_64 that installed stripped shared libraries are
    unchanged by the patch.

        [BZ #14132]
        * elf/dl-init.c (_dl_init): Don't use INTDEF.
        * sysdeps/aarch64/dl-machine.h (RTLD_START): Use _dl_init instead
        of _dl_init_internal.
        * sysdeps/alpha/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/arm/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/hppa/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/i386/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/ia64/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/m68k/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/microblaze/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/mips/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/powerpc/powerpc32/dl-start.S (_start): Likewise.
        * sysdeps/s390/s390-32/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/s390/s390-64/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/sh/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/sparc/sparc32/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/sparc/sparc64/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/tile/dl-start.S (_start): Likewise.
        * sysdeps/x86_64/dl-machine.h (RTLD_START): Likewise.
        * sysdeps/x86_64/x32/dl-machine.h (RTLD_START): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                            |   22 ++++++++++++++++++++++
 elf/dl-init.c                        |    1 -
 sysdeps/aarch64/dl-machine.h         |    2 +-
 sysdeps/alpha/dl-machine.h           |    2 +-
 sysdeps/arm/dl-machine.h             |    2 +-
 sysdeps/hppa/dl-machine.h            |    2 +-
 sysdeps/i386/dl-machine.h            |    2 +-
 sysdeps/ia64/dl-machine.h            |    2 +-
 sysdeps/m68k/dl-machine.h            |    2 +-
 sysdeps/microblaze/dl-machine.h      |    2 +-
 sysdeps/mips/dl-machine.h            |    8 ++++----
 sysdeps/powerpc/powerpc32/dl-start.S |    2 +-
 sysdeps/s390/s390-32/dl-machine.h    |    2 +-
 sysdeps/s390/s390-64/dl-machine.h    |    2 +-
 sysdeps/sh/dl-machine.h              |    2 +-
 sysdeps/sparc/sparc32/dl-machine.h   |    2 +-
 sysdeps/sparc/sparc64/dl-machine.h   |    2 +-
 sysdeps/tile/dl-start.S              |    2 +-
 sysdeps/x86_64/dl-machine.h          |    4 ++--
 sysdeps/x86_64/x32/dl-machine.h      |    4 ++--
 20 files changed, 45 insertions(+), 24 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  ab97ee8f1bf70b24b417e8f690ce50563d508243 (commit)
      from  c5684fdb2badfda3bd6e973e5f933272e39e9590 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ab97ee8f1bf70b24b417e8f690ce50563d508243

commit ab97ee8f1bf70b24b417e8f690ce50563d508243
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Nov 5 01:02:47 2014 +0000

    Don't use INTDEF/INTUSE with _dl_mcount (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch replaces its use for _dl_mcount with use of rtld_hidden_def /
    rtld_hidden_proto.

    Tested for x86_64 that installed stripped shared libraries are
    unchanged by the patch.

        [BZ #14132]
        * elf/dl-profile.c (_dl_mcount): Use rtld_hidden_def instead of
        INTDEF.
        * sysdeps/generic/ldsodefs.h (_dl_mcount_internal): Remove
        declaration.
        (_dl_mcount): Use rtld_hidden_proto.
        * elf/dl-runtime.c (_dl_profile_fixup): Don't use INTUSE with
        _dl_mcount.
        * elf/rtld.c (_rtld_global_ro): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                  |   10 ++++++++++
 elf/dl-profile.c           |    2 +-
 elf/dl-runtime.c           |    2 +-
 elf/rtld.c                 |    2 +-
 sysdeps/generic/ldsodefs.h |    3 +--
 5 files changed, 14 insertions(+), 5 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  9cf27b8d09aab26bd4693b10f281d64da779da83 (commit)
      from  af83568d3fdc84884378317504b4a2b76371bf8b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9cf27b8d09aab26bd4693b10f281d64da779da83

commit 9cf27b8d09aab26bd4693b10f281d64da779da83
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Nov 5 23:35:36 2014 +0000

    Remove INTDEF / INTUSE / INTVARDEF (bug 14132).

    Completing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch removes the final use - that for _dl_starting_up - replacing it
    by rtld_hidden_def / rtld_hidden_proto.  Having removed the last use,
    the mechanism itself is also removed.

    Tested for x86_64 that installed stripped shared libraries are
    unchanged by the patch.  (This is not much of a test since this
    variable is only defined and used in the !HAVE_INLINED_SYSCALLS case.)

        [BZ #14132]
        * include/libc-symbols.h (INTUSE): Remove macro.
        (INTDEF): Likewise.
        (INTVARDEF): Likewise.
        (_INTVARDEF): Likewise.
        (INTDEF2): Likewise.
        (INTVARDEF2): Likewise.
        * elf/rtld.c [!HAVE_INLINED_SYSCALLS] (_dl_starting_up): Use
        rtld_hidden_def instead of INTVARDEF.
        * sysdeps/generic/ldsodefs.h [IS_IN_rtld]
        (_dl_starting_up_internal): Remove declaration.
        (_dl_starting_up): Use rtld_hidden_proto.
        * elf/dl-init.c [!HAVE_INLINED_SYSCALLS] (_dl_starting_up): Remove
        declaration.
        [!HAVE_INLINED_SYSCALLS] (_dl_starting_up_internal): Likewise.
        (_dl_init) [!HAVE_INLINED_SYSCALLS]: Don't use INTUSE with
        _dl_starting_up.
        * elf/dl-writev.h (_dl_writev): Likewise.
        * sysdeps/powerpc/powerpc64/dl-machine.h [!HAVE_INLINED_SYSCALLS]
        (DL_STARTING_UP_DEF): Use __GI__dl_starting_up instead of
        _dl_starting_up_internal.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                              |   24 ++++++++++++++++++++++++
 NEWS                                   |    4 ++--
 elf/dl-init.c                          |    8 +-------
 elf/dl-writev.h                        |    2 +-
 elf/rtld.c                             |    4 ++--
 include/libc-symbols.h                 |   20 --------------------
 sysdeps/generic/ldsodefs.h             |    4 +---
 sysdeps/powerpc/powerpc64/dl-machine.h |    2 +-
 8 files changed, 32 insertions(+), 36 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.