[Bug manual/14347] New: LOG_MAKEPRI needs LOG_FAC, or should not shift

[Bug manual/14347] New: LOG_MAKEPRI needs LOG_FAC, or should not shift

[rasmus.villemoes at decode dot is]

http://sourceware.org/bugzilla/show_bug.cgi?id=14347

             Bug #: 14347
           Summary: LOG_MAKEPRI needs LOG_FAC, or should not shift
           Product: glibc
           Version: 2.16
            Status: NEW
          Severity: minor
          Priority: P2
         Component: manual
        AssignedTo: unassigned@sourceware.org
        ReportedBy: rasmus.villemoes@decode.is
                CC: mtk.manpages@gmail.com, roland@gnu.org
    Classification: Unclassified


The two examples of use of the LOG_MAKEPRI macro in the manual for 2.16 (and
earlier) are broken. The facility macros LOG_USER, ..., LOG_LOCAL1, ... already
contain a left-shift of 3, so to use these macros in LOG_MAKEPRI (which also
makes a shift), that shift has to be undone by using the LOG_FAC macro. The
example at the end of 18.2.2 would then be something like

    syslog (LOG_MAKEPRI(LOG_FAC(LOG_LOCAL1), LOG_ERROR),
            "Unable to make network connection to %s. Error=%m", host);

Alternatively, the documentation could drop mentioning the LOG_MAKEPRI macro at
all and simply instruct people to OR the facility and priority, resulting in
the much simpler

    syslog (LOG_LOCAL1 | LOG_ERROR,
            "Unable to make network connection to %s. Error=%m", host);

(Alternatively, this is a bug against the LOG_MAKEPRI macro, which should
simply do exactly this, but this would break code which uses the LOG_FAC
macro.)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14347] LOG_MAKEPRI needs LOG_FAC, or should not shift

[schwab@linux-m68k.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14347

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drepper.fsp at gmail dot
                   |                            |com
          Component|manual                      |libc
           Severity|minor                       |normal

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> 2012-07-10 16:55:17 UTC ---
This bug was fixed 15 years ago in BSD
<http://svnweb.freebsd.org/base?view=revision&revision=23252>, glibc should
follow.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14347] LOG_MAKEPRI needs LOG_FAC, or should not shift

[schwab@linux-m68k.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14347

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> 2012-07-10 20:41:21 UTC ---
Fixed in 2.17.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14347] LOG_MAKEPRI needs LOG_FAC, or should not shift

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14347

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/14347] LOG_MAKEPRI needs LOG_FAC, or should not shift

[echron at yahoo dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14347

Edward Chron <echron at yahoo dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |echron at yahoo dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.