public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug nptl/14569] New: libpthread.a isn't linked in properly
@ 2012-09-10 21:47 hjl.tools at gmail dot com
  2012-09-28  7:36 ` [Bug nptl/14569] " davem at davemloft dot net
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: hjl.tools at gmail dot com @ 2012-09-10 21:47 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=14569

             Bug #: 14569
           Summary: libpthread.a isn't linked in properly
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
        AssignedTo: unassigned@sourceware.org
        ReportedBy: hjl.tools@gmail.com
                CC: drepper.fsp@gmail.com
    Classification: Unclassified


[hjl@gnu-32 tmp]$  gcc tst-raise1-static.o -static -v -mx32 -pthread 
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.7.1/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla
--enable-bootstrap --enable-shared --enable-threads=posix
--enable-checking=release --disable-build-with-cxx
--disable-build-poststage1-with-cxx --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-gnu-unique-object
--enable-linker-build-id --with-linker-hash-style=gnu
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin
--enable-initfini-array --enable-java-awt=gtk --disable-dssi
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre
--enable-libgcj-multifile --enable-java-maintainer-mode
--with-ecj-jar=/usr/share/java/eclipse-ecj.jar --disable-libjava-multilib
--with-ppl --with-cloog --with-tune=generic --with-arch_32=i686
--with-multilib-list=m32,m64,mx32 --build=x86_64-redhat-linux
Thread model: posix
gcc version 4.7.1 20120629 (Red Hat 4.7.1-1) (GCC) 
COMPILER_PATH=/usr/libexec/gcc/x86_64-redhat-linux/4.7.1/:/usr/libexec/gcc/x86_64-redhat-linux/4.7.1/:/usr/libexec/gcc/x86_64-redhat-linux/:/usr/lib/gcc/x86_64-redhat-linux/4.7.1/:/usr/lib/gcc/x86_64-redhat-linux/
LIBRARY_PATH=/usr/lib/gcc/x86_64-redhat-linux/4.7.1/x32/:/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../../../libx32/:/lib/../libx32/:/usr/lib/../libx32/:/usr/lib/gcc/x86_64-redhat-linux/4.7.1/:/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../../:/lib/:/usr/lib/
COLLECT_GCC_OPTIONS='-static' '-v' '-mx32' '-pthread' '-mtune=generic'
'-march=x86-64'
 /usr/libexec/gcc/x86_64-redhat-linux/4.7.1/collect2 --build-id --no-add-needed
--hash-style=gnu -m elf32_x86_64 -static
/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../../../libx32/crt1.o
/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../../../libx32/crti.o
/usr/lib/gcc/x86_64-redhat-linux/4.7.1/x32/crtbeginT.o
-L/usr/lib/gcc/x86_64-redhat-linux/4.7.1/x32
-L/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../../../libx32 -L/lib/../libx32
-L/usr/lib/../libx32 -L/usr/lib/gcc/x86_64-redhat-linux/4.7.1
-L/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../.. tst-raise1-static.o
--start-group -lgcc -lgcc_eh -lpthread -lc --end-group
/usr/lib/gcc/x86_64-redhat-linux/4.7.1/x32/crtend.o
/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../../../libx32/crtn.o
/usr/lib/gcc/x86_64-redhat-linux/4.7.1/../../../../libx32/libpthread.a(libpthread.o):
In function `sem_open':
(.text+0x6988): warning: the use of `mktemp' is dangerous, better use `mkstemp'

-lpthread is placed in --start-group -lgcc -lgcc_eh -lpthread -lc --end-group.
glibc tests should do the same.  It is important to properly test
statically linked libpthread.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
@ 2012-09-28  7:36 ` davem at davemloft dot net
  2012-09-28  7:37 ` davem at davemloft dot net
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: davem at davemloft dot net @ 2012-09-28  7:36 UTC (permalink / raw)
  To: glibc-bugs


http://sourceware.org/bugzilla/show_bug.cgi?id=14569

David S. Miller <davem at davemloft dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |davem at davemloft dot net
         AssignedTo|unassigned at sourceware    |davem at davemloft dot net
                   |dot org                     |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
  2012-09-28  7:36 ` [Bug nptl/14569] " davem at davemloft dot net
@ 2012-09-28  7:37 ` davem at davemloft dot net
  2014-06-17  4:34 ` fweimer at redhat dot com
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: davem at davemloft dot net @ 2012-09-28  7:37 UTC (permalink / raw)
  To: glibc-bugs


http://sourceware.org/bugzilla/show_bug.cgi?id=14569

David S. Miller <davem at davemloft dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|davem at davemloft dot net  |unassigned at sourceware
                   |                            |dot org

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
  2012-09-28  7:36 ` [Bug nptl/14569] " davem at davemloft dot net
  2012-09-28  7:37 ` davem at davemloft dot net
@ 2014-06-17  4:34 ` fweimer at redhat dot com
  2015-09-15 15:37 ` cvs-commit at gcc dot gnu.org
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: fweimer at redhat dot com @ 2014-06-17  4:34 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (2 preceding siblings ...)
  2014-06-17  4:34 ` fweimer at redhat dot com
@ 2015-09-15 15:37 ` cvs-commit at gcc dot gnu.org
  2015-09-15 21:34 ` cvs-commit at gcc dot gnu.org
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-15 15:37 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.21 has been created
        at  8de7f5109fb22e8b53a52fe2fb6b50ff6deaba03 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8de7f5109fb22e8b53a52fe2fb6b50ff6deaba03

commit 8de7f5109fb22e8b53a52fe2fb6b50ff6deaba03
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c (pthread_attr_destroy): Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_attr_init_2_0): Likewise.
        (__pthread_attr_init_2_1): Likewise.
        (pthread_attr_getdetachstate): Likewise.
        (pthread_attr_setdetachstate): Likewise.
        (pthread_attr_getinheritsched): Likewise.
        (pthread_attr_setinheritsched): Likewise.
        (pthread_attr_getschedparam): Likewise.
        (pthread_attr_setschedparam): Likewise.
        (pthread_attr_getschedpolicy): Likewise.
        (pthread_attr_setschedpolicy): Likewise.
        (pthread_attr_getscope): Likewise.
        (pthread_attr_setscope): Likewise.
        (pthread_condattr_destroy): Likewise.
        (pthread_condattr_init): Likewise.
        (__pthread_cond_broadcast_2_0): Likewise.
        (__pthread_cond_broadcast): Likewise.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_destroy): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_init): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_signal): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        (__pthread_cond_wait): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_timedwait): Likewise.
        (pthread_equal): Likewise.
        (__pthread_exit): Likewise.
        (pthread_getschedparam): Likewise.
        (pthread_setschedparam): Likewise.
        (pthread_mutex_destroy): Likewise.
        (pthread_mutex_init): Likewise.
        (pthread_mutex_lock): Likewise.
        (pthread_mutex_unlock): Likewise.
        (pthread_self): Likewise.
        (pthread_setcancelstate): Likewise.
        (pthread_setcanceltype): Likewise.
        (__pthread_unwind): Likewise.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_attr_destroy.c: Likewise.
        * nptl/libc-pthread_attr_getdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_getinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_getschedparam.c: Likewise.
        * nptl/libc-pthread_attr_getschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_getscope.c: Likewise.
        * nptl/libc-pthread_attr_init.c: Likewise.
        * nptl/libc-pthread_attr_setdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_setinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_setschedparam.c: Likewise.
        * nptl/libc-pthread_attr_setschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_setscope.c: Likewise.
        * nptl/libc-pthread_cond_broadcast.c: Likewise.
        * nptl/libc-pthread_cond_destroy.c: Likewise.
        * nptl/libc-pthread_cond_init.c: Likewise.
        * nptl/libc-pthread_cond_signal.c: Likewise.
        * nptl/libc-pthread_cond_timedwait.c: Likewise.
        * nptl/libc-pthread_cond_wait.c: Likewise.
        * nptl/libc-pthread_condattr_destroy.c: Likewise.
        * nptl/libc-pthread_condattr_init.c: Likewise.
        * nptl/libc-pthread_equal.c: Likewise.
        * nptl/libc-pthread_exit.c: Likewise.
        * nptl/libc-pthread_getschedparam.c: Likewise.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_destroy.c: Likewise.
        * nptl/libc-pthread_mutex_init.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_self.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setcanceltype.c: Likewise.
        * nptl/libc-pthread_setschedparam.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-unwind.c: Likewise.
        * nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (pthread_setcancelstate): Likewise.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e5daf5a6ed7e88493ab4c79d8dc444451a7083b7

commit e5daf5a6ed7e88493ab4c79d8dc444451a7083b7
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d8f0433371731d83a754ad173215e6a38d712424

commit d8f0433371731d83a754ad173215e6a38d712424
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=af345c230d3f2d2b810cfec292188e26c3da5a48

commit af345c230d3f2d2b810cfec292188e26c3da5a48
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (3 preceding siblings ...)
  2015-09-15 15:37 ` cvs-commit at gcc dot gnu.org
@ 2015-09-15 21:34 ` cvs-commit at gcc dot gnu.org
  2015-09-16  0:12 ` cvs-commit at gcc dot gnu.org
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-15 21:34 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.22 has been created
        at  598a64f4fb1ae76533ff284ed1a3c7c30b519e58 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=598a64f4fb1ae76533ff284ed1a3c7c30b519e58

commit 598a64f4fb1ae76533ff284ed1a3c7c30b519e58
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 15 14:29:35 2015 -0700

    Fix __pthread_setcancelstate for i386

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=61fce3ec76a4ff5522d392c57583728396c8048c

commit 61fce3ec76a4ff5522d392c57583728396c8048c
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 15 12:53:55 2015 -0700

    Fix __pthread_setcancelstate for x86-64

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=76a88ed95fbccd008453ffb9544d575d1ea8310e

commit 76a88ed95fbccd008453ffb9544d575d1ea8310e
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c (pthread_attr_destroy): Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_attr_init_2_0): Likewise.
        (__pthread_attr_init_2_1): Likewise.
        (pthread_attr_getdetachstate): Likewise.
        (pthread_attr_setdetachstate): Likewise.
        (pthread_attr_getinheritsched): Likewise.
        (pthread_attr_setinheritsched): Likewise.
        (pthread_attr_getschedparam): Likewise.
        (pthread_attr_setschedparam): Likewise.
        (pthread_attr_getschedpolicy): Likewise.
        (pthread_attr_setschedpolicy): Likewise.
        (pthread_attr_getscope): Likewise.
        (pthread_attr_setscope): Likewise.
        (pthread_condattr_destroy): Likewise.
        (pthread_condattr_init): Likewise.
        (__pthread_cond_broadcast_2_0): Likewise.
        (__pthread_cond_broadcast): Likewise.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_destroy): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_init): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_signal): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        (__pthread_cond_wait): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_timedwait): Likewise.
        (pthread_equal): Likewise.
        (__pthread_exit): Likewise.
        (pthread_getschedparam): Likewise.
        (pthread_setschedparam): Likewise.
        (pthread_mutex_destroy): Likewise.
        (pthread_mutex_init): Likewise.
        (pthread_mutex_lock): Likewise.
        (pthread_mutex_unlock): Likewise.
        (pthread_self): Likewise.
        (pthread_setcancelstate): Likewise.
        (pthread_setcanceltype): Likewise.
        (__pthread_unwind): Likewise.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_attr_destroy.c: Likewise.
        * nptl/libc-pthread_attr_getdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_getinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_getschedparam.c: Likewise.
        * nptl/libc-pthread_attr_getschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_getscope.c: Likewise.
        * nptl/libc-pthread_attr_init.c: Likewise.
        * nptl/libc-pthread_attr_setdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_setinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_setschedparam.c: Likewise.
        * nptl/libc-pthread_attr_setschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_setscope.c: Likewise.
        * nptl/libc-pthread_cond_broadcast.c: Likewise.
        * nptl/libc-pthread_cond_destroy.c: Likewise.
        * nptl/libc-pthread_cond_init.c: Likewise.
        * nptl/libc-pthread_cond_signal.c: Likewise.
        * nptl/libc-pthread_cond_timedwait.c: Likewise.
        * nptl/libc-pthread_cond_wait.c: Likewise.
        * nptl/libc-pthread_condattr_destroy.c: Likewise.
        * nptl/libc-pthread_condattr_init.c: Likewise.
        * nptl/libc-pthread_equal.c: Likewise.
        * nptl/libc-pthread_exit.c: Likewise.
        * nptl/libc-pthread_getschedparam.c: Likewise.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_destroy.c: Likewise.
        * nptl/libc-pthread_mutex_init.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_self.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setcanceltype.c: Likewise.
        * nptl/libc-pthread_setschedparam.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-unwind.c: Likewise.
        * nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (pthread_setcancelstate): Likewise.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=24b5e9e60edca6be07cc729ebfde07a4044d8aeb

commit 24b5e9e60edca6be07cc729ebfde07a4044d8aeb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a638a9be6ccaa543607f1655f73806bd41b2140

commit 9a638a9be6ccaa543607f1655f73806bd41b2140
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ad0a4cef8d88a8985820228413afde66af1f52eb

commit ad0a4cef8d88a8985820228413afde66af1f52eb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1c810396a130fc4cc8ad0bb7d7438b58bbac6e78

commit 1c810396a130fc4cc8ad0bb7d7438b58bbac6e78
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Jun 30 12:53:04 2012 -0700

    Add STB_SECONDARY support to ld.so

    Enable STB_SECONDARY if it is supported by binutils.  Add 3 STB_SECONDARY
    tests.

        * config.h.in: Add HAVE_ASM_SECONDARY_DIRECTIVE.
        * config.make.in (have-secondary): New macro.
        * configure.in: Check if STB_SECONDARY is supported by as/ld.
        Define HAVE_ASM_SECONDARY_DIRECTIVE and set have-secondary to yes
        if the .secondary assembly directive works.
        * configure: Regenerated.
        * elf/Makefile (tests): Add tst-secondary1 tst-secondary2
        tst-secondary3 if STB_SECONDARY is supported by as/ld.
        (modules-names): Add tst-secondarymod tst-secondary1mod
        tst-secondary2mod tst-secondary3mod if STB_SECONDARY is supported
        by as/ld.
        (LDFLAGS-tst-secondarymod.so): New macro.
        ($(objpfx)tst-secondary1): New rule.
        ($(objpfx)tst-secondary2): Likewise.
        ($(objpfx)tst-secondary3): Likewise.
        * elf/dl-addr.c (determine_info): Also check STB_SECONDARY.
        * elf/dl-lookup.c (do_lookup_x): Handle STB_SECONDARY.
        (_dl_lookup_symbol_x): Likewise.
        * elf/sprof.c (read_symbols): Likewise.
        * elf/elf.h (STB_SECONDARY): New.
        (STB_NUM): Updated.
        * elf/tst-secondary.h: New file.
        * elf/tst-secondary1.c: Likewise.
        * elf/tst-secondary1mod.c: Likewise.
        * elf/tst-secondary2.c: Likewise.
        * elf/tst-secondary2mod.c: Likewise.
        * elf/tst-secondary3.c: Likewise.
        * elf/tst-secondary3mod.c: Likewise.
        * elf/tst-secondarymod.c: Likewise.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (4 preceding siblings ...)
  2015-09-15 21:34 ` cvs-commit at gcc dot gnu.org
@ 2015-09-16  0:12 ` cvs-commit at gcc dot gnu.org
  2015-09-16 12:47 ` cvs-commit at gcc dot gnu.org
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-16  0:12 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.22 has been created
        at  4701f9471b6639b6e5b6843e74543d2227cd188e (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4701f9471b6639b6e5b6843e74543d2227cd188e

commit 4701f9471b6639b6e5b6843e74543d2227cd188e
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * misc/error.c (error): Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        (error_at_line): Likewise.
        * posix/wordexp.c (parse_comm): Likewise.
        * stdlib/fmtmsg.c (fmtmsg): Likewise.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c (pthread_attr_destroy): Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_attr_init_2_0): Likewise.
        (__pthread_attr_init_2_1): Likewise.
        (pthread_attr_getdetachstate): Likewise.
        (pthread_attr_setdetachstate): Likewise.
        (pthread_attr_getinheritsched): Likewise.
        (pthread_attr_setinheritsched): Likewise.
        (pthread_attr_getschedparam): Likewise.
        (pthread_attr_setschedparam): Likewise.
        (pthread_attr_getschedpolicy): Likewise.
        (pthread_attr_setschedpolicy): Likewise.
        (pthread_attr_getscope): Likewise.
        (pthread_attr_setscope): Likewise.
        (pthread_condattr_destroy): Likewise.
        (pthread_condattr_init): Likewise.
        (__pthread_cond_broadcast_2_0): Likewise.
        (__pthread_cond_broadcast): Likewise.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_destroy): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_init): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_signal): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        (__pthread_cond_wait): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_timedwait): Likewise.
        (pthread_equal): Likewise.
        (__pthread_exit): Likewise.
        (pthread_getschedparam): Likewise.
        (pthread_setschedparam): Likewise.
        (pthread_mutex_destroy): Likewise.
        (pthread_mutex_init): Likewise.
        (pthread_mutex_lock): Likewise.
        (pthread_mutex_unlock): Likewise.
        (pthread_self): Likewise.
        (pthread_setcanceltype): Likewise.
        (__pthread_unwind): Likewise.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_attr_destroy.c: Likewise.
        * nptl/libc-pthread_attr_getdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_getinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_getschedparam.c: Likewise.
        * nptl/libc-pthread_attr_getschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_getscope.c: Likewise.
        * nptl/libc-pthread_attr_init.c: Likewise.
        * nptl/libc-pthread_attr_setdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_setinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_setschedparam.c: Likewise.
        * nptl/libc-pthread_attr_setschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_setscope.c: Likewise.
        * nptl/libc-pthread_cond_broadcast.c: Likewise.
        * nptl/libc-pthread_cond_destroy.c: Likewise.
        * nptl/libc-pthread_cond_init.c: Likewise.
        * nptl/libc-pthread_cond_signal.c: Likewise.
        * nptl/libc-pthread_cond_timedwait.c: Likewise.
        * nptl/libc-pthread_cond_wait.c: Likewise.
        * nptl/libc-pthread_condattr_destroy.c: Likewise.
        * nptl/libc-pthread_condattr_init.c: Likewise.
        * nptl/libc-pthread_equal.c: Likewise.
        * nptl/libc-pthread_exit.c: Likewise.
        * nptl/libc-pthread_getschedparam.c: Likewise.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_destroy.c: Likewise.
        * nptl/libc-pthread_mutex_init.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_self.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setcanceltype.c: Likewise.
        * nptl/libc-pthread_setschedparam.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-unwind.c: Likewise.
        * nptl/nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace ptr_pthread_setcancelstate with
        ptr___pthread_setcancelstate.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (__pthread_setcancelstate): New prototype.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=24b5e9e60edca6be07cc729ebfde07a4044d8aeb

commit 24b5e9e60edca6be07cc729ebfde07a4044d8aeb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a638a9be6ccaa543607f1655f73806bd41b2140

commit 9a638a9be6ccaa543607f1655f73806bd41b2140
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ad0a4cef8d88a8985820228413afde66af1f52eb

commit ad0a4cef8d88a8985820228413afde66af1f52eb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1c810396a130fc4cc8ad0bb7d7438b58bbac6e78

commit 1c810396a130fc4cc8ad0bb7d7438b58bbac6e78
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Jun 30 12:53:04 2012 -0700

    Add STB_SECONDARY support to ld.so

    Enable STB_SECONDARY if it is supported by binutils.  Add 3 STB_SECONDARY
    tests.

        * config.h.in: Add HAVE_ASM_SECONDARY_DIRECTIVE.
        * config.make.in (have-secondary): New macro.
        * configure.in: Check if STB_SECONDARY is supported by as/ld.
        Define HAVE_ASM_SECONDARY_DIRECTIVE and set have-secondary to yes
        if the .secondary assembly directive works.
        * configure: Regenerated.
        * elf/Makefile (tests): Add tst-secondary1 tst-secondary2
        tst-secondary3 if STB_SECONDARY is supported by as/ld.
        (modules-names): Add tst-secondarymod tst-secondary1mod
        tst-secondary2mod tst-secondary3mod if STB_SECONDARY is supported
        by as/ld.
        (LDFLAGS-tst-secondarymod.so): New macro.
        ($(objpfx)tst-secondary1): New rule.
        ($(objpfx)tst-secondary2): Likewise.
        ($(objpfx)tst-secondary3): Likewise.
        * elf/dl-addr.c (determine_info): Also check STB_SECONDARY.
        * elf/dl-lookup.c (do_lookup_x): Handle STB_SECONDARY.
        (_dl_lookup_symbol_x): Likewise.
        * elf/sprof.c (read_symbols): Likewise.
        * elf/elf.h (STB_SECONDARY): New.
        (STB_NUM): Updated.
        * elf/tst-secondary.h: New file.
        * elf/tst-secondary1.c: Likewise.
        * elf/tst-secondary1mod.c: Likewise.
        * elf/tst-secondary2.c: Likewise.
        * elf/tst-secondary2mod.c: Likewise.
        * elf/tst-secondary3.c: Likewise.
        * elf/tst-secondary3mod.c: Likewise.
        * elf/tst-secondarymod.c: Likewise.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (5 preceding siblings ...)
  2015-09-16  0:12 ` cvs-commit at gcc dot gnu.org
@ 2015-09-16 12:47 ` cvs-commit at gcc dot gnu.org
  2015-09-16 12:54 ` cvs-commit at gcc dot gnu.org
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-16 12:47 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.22 has been created
        at  2ce57852700eec0d4f12f5807ca503db1ff4e71a (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2ce57852700eec0d4f12f5807ca503db1ff4e71a

commit 2ce57852700eec0d4f12f5807ca503db1ff4e71a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * misc/error.c (error): Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        (error_at_line): Likewise.
        * posix/wordexp.c (parse_comm): Likewise.
        * stdlib/fmtmsg.c (fmtmsg): Likewise.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c (pthread_attr_destroy): Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_attr_init_2_0): Likewise.
        (__pthread_attr_init_2_1): Likewise.
        (pthread_attr_getdetachstate): Likewise.
        (pthread_attr_setdetachstate): Likewise.
        (pthread_attr_getinheritsched): Likewise.
        (pthread_attr_setinheritsched): Likewise.
        (pthread_attr_getschedparam): Likewise.
        (pthread_attr_setschedparam): Likewise.
        (pthread_attr_getschedpolicy): Likewise.
        (pthread_attr_setschedpolicy): Likewise.
        (pthread_attr_getscope): Likewise.
        (pthread_attr_setscope): Likewise.
        (pthread_condattr_destroy): Likewise.
        (pthread_condattr_init): Likewise.
        (__pthread_cond_broadcast_2_0): Likewise.
        (__pthread_cond_broadcast): Likewise.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_destroy): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_init): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_signal): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        (__pthread_cond_wait): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_timedwait): Likewise.
        (pthread_equal): Likewise.
        (__pthread_exit): Likewise.
        (pthread_getschedparam): Likewise.
        (pthread_setschedparam): Likewise.
        (pthread_mutex_destroy): Likewise.
        (pthread_mutex_init): Likewise.
        (pthread_mutex_lock): Likewise.
        (pthread_mutex_unlock): Likewise.
        (pthread_self): Likewise.
        (pthread_setcanceltype): Likewise.
        (__pthread_unwind): Likewise.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_attr_destroy.c: Likewise.
        * nptl/libc-pthread_attr_getdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_getinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_getschedparam.c: Likewise.
        * nptl/libc-pthread_attr_getschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_getscope.c: Likewise.
        * nptl/libc-pthread_attr_init.c: Likewise.
        * nptl/libc-pthread_attr_setdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_setinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_setschedparam.c: Likewise.
        * nptl/libc-pthread_attr_setschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_setscope.c: Likewise.
        * nptl/libc-pthread_cond_broadcast.c: Likewise.
        * nptl/libc-pthread_cond_destroy.c: Likewise.
        * nptl/libc-pthread_cond_init.c: Likewise.
        * nptl/libc-pthread_cond_signal.c: Likewise.
        * nptl/libc-pthread_cond_timedwait.c: Likewise.
        * nptl/libc-pthread_cond_wait.c: Likewise.
        * nptl/libc-pthread_condattr_destroy.c: Likewise.
        * nptl/libc-pthread_condattr_init.c: Likewise.
        * nptl/libc-pthread_equal.c: Likewise.
        * nptl/libc-pthread_exit.c: Likewise.
        * nptl/libc-pthread_getschedparam.c: Likewise.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_destroy.c: Likewise.
        * nptl/libc-pthread_mutex_init.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_self.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setcanceltype.c: Likewise.
        * nptl/libc-pthread_setschedparam.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-unwind.c: Likewise.
        * nptl/nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace ptr_pthread_setcancelstate with
        ptr___pthread_setcancelstate.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/x86_64/localplt.data: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (__pthread_setcancelstate): New prototype.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=24b5e9e60edca6be07cc729ebfde07a4044d8aeb

commit 24b5e9e60edca6be07cc729ebfde07a4044d8aeb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a638a9be6ccaa543607f1655f73806bd41b2140

commit 9a638a9be6ccaa543607f1655f73806bd41b2140
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ad0a4cef8d88a8985820228413afde66af1f52eb

commit ad0a4cef8d88a8985820228413afde66af1f52eb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1c810396a130fc4cc8ad0bb7d7438b58bbac6e78

commit 1c810396a130fc4cc8ad0bb7d7438b58bbac6e78
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Jun 30 12:53:04 2012 -0700

    Add STB_SECONDARY support to ld.so

    Enable STB_SECONDARY if it is supported by binutils.  Add 3 STB_SECONDARY
    tests.

        * config.h.in: Add HAVE_ASM_SECONDARY_DIRECTIVE.
        * config.make.in (have-secondary): New macro.
        * configure.in: Check if STB_SECONDARY is supported by as/ld.
        Define HAVE_ASM_SECONDARY_DIRECTIVE and set have-secondary to yes
        if the .secondary assembly directive works.
        * configure: Regenerated.
        * elf/Makefile (tests): Add tst-secondary1 tst-secondary2
        tst-secondary3 if STB_SECONDARY is supported by as/ld.
        (modules-names): Add tst-secondarymod tst-secondary1mod
        tst-secondary2mod tst-secondary3mod if STB_SECONDARY is supported
        by as/ld.
        (LDFLAGS-tst-secondarymod.so): New macro.
        ($(objpfx)tst-secondary1): New rule.
        ($(objpfx)tst-secondary2): Likewise.
        ($(objpfx)tst-secondary3): Likewise.
        * elf/dl-addr.c (determine_info): Also check STB_SECONDARY.
        * elf/dl-lookup.c (do_lookup_x): Handle STB_SECONDARY.
        (_dl_lookup_symbol_x): Likewise.
        * elf/sprof.c (read_symbols): Likewise.
        * elf/elf.h (STB_SECONDARY): New.
        (STB_NUM): Updated.
        * elf/tst-secondary.h: New file.
        * elf/tst-secondary1.c: Likewise.
        * elf/tst-secondary1mod.c: Likewise.
        * elf/tst-secondary2.c: Likewise.
        * elf/tst-secondary2mod.c: Likewise.
        * elf/tst-secondary3.c: Likewise.
        * elf/tst-secondary3mod.c: Likewise.
        * elf/tst-secondarymod.c: Likewise.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (6 preceding siblings ...)
  2015-09-16 12:47 ` cvs-commit at gcc dot gnu.org
@ 2015-09-16 12:54 ` cvs-commit at gcc dot gnu.org
  2015-09-16 18:17 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-16 12:54 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.21 has been created
        at  0d18c5202c8dbcbfd689a7a5e3a4ab477911352f (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0d18c5202c8dbcbfd689a7a5e3a4ab477911352f

commit 0d18c5202c8dbcbfd689a7a5e3a4ab477911352f
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * misc/error.c (error): Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        (error_at_line): Likewise.
        * posix/wordexp.c (parse_comm): Likewise.
        * stdlib/fmtmsg.c (fmtmsg): Likewise.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c (pthread_attr_destroy): Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_attr_init_2_0): Likewise.
        (__pthread_attr_init_2_1): Likewise.
        (pthread_attr_getdetachstate): Likewise.
        (pthread_attr_setdetachstate): Likewise.
        (pthread_attr_getinheritsched): Likewise.
        (pthread_attr_setinheritsched): Likewise.
        (pthread_attr_getschedparam): Likewise.
        (pthread_attr_setschedparam): Likewise.
        (pthread_attr_getschedpolicy): Likewise.
        (pthread_attr_setschedpolicy): Likewise.
        (pthread_attr_getscope): Likewise.
        (pthread_attr_setscope): Likewise.
        (pthread_condattr_destroy): Likewise.
        (pthread_condattr_init): Likewise.
        (__pthread_cond_broadcast_2_0): Likewise.
        (__pthread_cond_broadcast): Likewise.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_destroy): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_init): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_signal): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        (__pthread_cond_wait): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_timedwait): Likewise.
        (pthread_equal): Likewise.
        (__pthread_exit): Likewise.
        (pthread_getschedparam): Likewise.
        (pthread_setschedparam): Likewise.
        (pthread_mutex_destroy): Likewise.
        (pthread_mutex_init): Likewise.
        (pthread_mutex_lock): Likewise.
        (pthread_mutex_unlock): Likewise.
        (pthread_self): Likewise.
        (pthread_setcanceltype): Likewise.
        (__pthread_unwind): Likewise.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_attr_destroy.c: Likewise.
        * nptl/libc-pthread_attr_getdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_getinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_getschedparam.c: Likewise.
        * nptl/libc-pthread_attr_getschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_getscope.c: Likewise.
        * nptl/libc-pthread_attr_init.c: Likewise.
        * nptl/libc-pthread_attr_setdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_setinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_setschedparam.c: Likewise.
        * nptl/libc-pthread_attr_setschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_setscope.c: Likewise.
        * nptl/libc-pthread_cond_broadcast.c: Likewise.
        * nptl/libc-pthread_cond_destroy.c: Likewise.
        * nptl/libc-pthread_cond_init.c: Likewise.
        * nptl/libc-pthread_cond_signal.c: Likewise.
        * nptl/libc-pthread_cond_timedwait.c: Likewise.
        * nptl/libc-pthread_cond_wait.c: Likewise.
        * nptl/libc-pthread_condattr_destroy.c: Likewise.
        * nptl/libc-pthread_condattr_init.c: Likewise.
        * nptl/libc-pthread_equal.c: Likewise.
        * nptl/libc-pthread_exit.c: Likewise.
        * nptl/libc-pthread_getschedparam.c: Likewise.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_destroy.c: Likewise.
        * nptl/libc-pthread_mutex_init.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_self.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setcanceltype.c: Likewise.
        * nptl/libc-pthread_setschedparam.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-unwind.c: Likewise.
        * nptl/nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace ptr_pthread_setcancelstate with
        ptr___pthread_setcancelstate.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (__pthread_setcancelstate): New prototype.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e5daf5a6ed7e88493ab4c79d8dc444451a7083b7

commit e5daf5a6ed7e88493ab4c79d8dc444451a7083b7
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d8f0433371731d83a754ad173215e6a38d712424

commit d8f0433371731d83a754ad173215e6a38d712424
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=af345c230d3f2d2b810cfec292188e26c3da5a48

commit af345c230d3f2d2b810cfec292188e26c3da5a48
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (7 preceding siblings ...)
  2015-09-16 12:54 ` cvs-commit at gcc dot gnu.org
@ 2015-09-16 18:17 ` cvs-commit at gcc dot gnu.org
  2015-09-16 19:43 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-16 18:17 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.22 has been created
        at  30146aad39c5669d91644ff8ffb764856949e6ff (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=30146aad39c5669d91644ff8ffb764856949e6ff

commit 30146aad39c5669d91644ff8ffb764856949e6ff
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * misc/error.c (error): Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        (error_at_line): Likewise.
        * posix/wordexp.c (parse_comm): Likewise.
        * stdlib/fmtmsg.c (fmtmsg): Likewise.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c (pthread_attr_destroy): Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_attr_init_2_0): Likewise.
        (__pthread_attr_init_2_1): Likewise.
        (pthread_attr_getdetachstate): Likewise.
        (pthread_attr_setdetachstate): Likewise.
        (pthread_attr_getinheritsched): Likewise.
        (pthread_attr_setinheritsched): Likewise.
        (pthread_attr_getschedparam): Likewise.
        (pthread_attr_setschedparam): Likewise.
        (pthread_attr_getschedpolicy): Likewise.
        (pthread_attr_setschedpolicy): Likewise.
        (pthread_attr_getscope): Likewise.
        (pthread_attr_setscope): Likewise.
        (pthread_condattr_destroy): Likewise.
        (pthread_condattr_init): Likewise.
        (__pthread_cond_broadcast_2_0): Likewise.
        (__pthread_cond_broadcast): Likewise.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_destroy): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_init): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_signal): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        (__pthread_cond_wait): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_timedwait): Likewise.
        (pthread_equal): Likewise.
        (__pthread_exit): Likewise.
        (pthread_getschedparam): Likewise.
        (pthread_setschedparam): Likewise.
        (pthread_mutex_destroy): Likewise.
        (pthread_mutex_init): Likewise.
        (pthread_mutex_lock): Likewise.
        (pthread_mutex_unlock): Likewise.
        (pthread_self): Likewise.
        (pthread_setcanceltype): Likewise.
        (__pthread_unwind): Likewise.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_attr_destroy.c: Likewise.
        * nptl/libc-pthread_attr_getdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_getinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_getschedparam.c: Likewise.
        * nptl/libc-pthread_attr_getschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_getscope.c: Likewise.
        * nptl/libc-pthread_attr_init.c: Likewise.
        * nptl/libc-pthread_attr_setdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_setinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_setschedparam.c: Likewise.
        * nptl/libc-pthread_attr_setschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_setscope.c: Likewise.
        * nptl/libc-pthread_cond_broadcast.c: Likewise.
        * nptl/libc-pthread_cond_destroy.c: Likewise.
        * nptl/libc-pthread_cond_init.c: Likewise.
        * nptl/libc-pthread_cond_signal.c: Likewise.
        * nptl/libc-pthread_cond_timedwait.c: Likewise.
        * nptl/libc-pthread_cond_wait.c: Likewise.
        * nptl/libc-pthread_condattr_destroy.c: Likewise.
        * nptl/libc-pthread_condattr_init.c: Likewise.
        * nptl/libc-pthread_equal.c: Likewise.
        * nptl/libc-pthread_exit.c: Likewise.
        * nptl/libc-pthread_getschedparam.c: Likewise.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_destroy.c: Likewise.
        * nptl/libc-pthread_mutex_init.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_self.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setcanceltype.c: Likewise.
        * nptl/libc-pthread_setschedparam.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-unwind.c: Likewise.
        * nptl/nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace ptr_pthread_setcancelstate with
        ptr___pthread_setcancelstate.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/x86_64/localplt.data: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (__pthread_setcancelstate): New prototype.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6e1ae9bae180f0cf43d73ee2ee395252d1e22e17

commit 6e1ae9bae180f0cf43d73ee2ee395252d1e22e17
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a638a9be6ccaa543607f1655f73806bd41b2140

commit 9a638a9be6ccaa543607f1655f73806bd41b2140
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ad0a4cef8d88a8985820228413afde66af1f52eb

commit ad0a4cef8d88a8985820228413afde66af1f52eb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1c810396a130fc4cc8ad0bb7d7438b58bbac6e78

commit 1c810396a130fc4cc8ad0bb7d7438b58bbac6e78
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Jun 30 12:53:04 2012 -0700

    Add STB_SECONDARY support to ld.so

    Enable STB_SECONDARY if it is supported by binutils.  Add 3 STB_SECONDARY
    tests.

        * config.h.in: Add HAVE_ASM_SECONDARY_DIRECTIVE.
        * config.make.in (have-secondary): New macro.
        * configure.in: Check if STB_SECONDARY is supported by as/ld.
        Define HAVE_ASM_SECONDARY_DIRECTIVE and set have-secondary to yes
        if the .secondary assembly directive works.
        * configure: Regenerated.
        * elf/Makefile (tests): Add tst-secondary1 tst-secondary2
        tst-secondary3 if STB_SECONDARY is supported by as/ld.
        (modules-names): Add tst-secondarymod tst-secondary1mod
        tst-secondary2mod tst-secondary3mod if STB_SECONDARY is supported
        by as/ld.
        (LDFLAGS-tst-secondarymod.so): New macro.
        ($(objpfx)tst-secondary1): New rule.
        ($(objpfx)tst-secondary2): Likewise.
        ($(objpfx)tst-secondary3): Likewise.
        * elf/dl-addr.c (determine_info): Also check STB_SECONDARY.
        * elf/dl-lookup.c (do_lookup_x): Handle STB_SECONDARY.
        (_dl_lookup_symbol_x): Likewise.
        * elf/sprof.c (read_symbols): Likewise.
        * elf/elf.h (STB_SECONDARY): New.
        (STB_NUM): Updated.
        * elf/tst-secondary.h: New file.
        * elf/tst-secondary1.c: Likewise.
        * elf/tst-secondary1mod.c: Likewise.
        * elf/tst-secondary2.c: Likewise.
        * elf/tst-secondary2mod.c: Likewise.
        * elf/tst-secondary3.c: Likewise.
        * elf/tst-secondary3mod.c: Likewise.
        * elf/tst-secondarymod.c: Likewise.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (8 preceding siblings ...)
  2015-09-16 18:17 ` cvs-commit at gcc dot gnu.org
@ 2015-09-16 19:43 ` cvs-commit at gcc dot gnu.org
  2015-09-16 20:01 ` cvs-commit at gcc dot gnu.org
  2015-09-24 15:52 ` cvs-commit at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-16 19:43 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.22 has been created
        at  7abd6b3b2c40abf643244eff386a069410d5dac2 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7abd6b3b2c40abf643244eff386a069410d5dac2

commit 7abd6b3b2c40abf643244eff386a069410d5dac2
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * misc/error.c (error): Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        (error_at_line): Likewise.
        * posix/wordexp.c (parse_comm): Likewise.
        * stdlib/fmtmsg.c (fmtmsg): Likewise.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-pthread_unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c [HAVE_ASM_SECONDARY_DIRECTIVE] (FORWARD2): New.
        (FORWARD_NORETURN): Likewise.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't define if
        (__pthread_unwind): Don't define if HAVE_ASM_SECONDARY_DIRECTIVE
        is defined.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_rwlock_wrlock.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-pthread_unwind.c: Likewise.
        * nptl/nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace ptr_pthread_setcancelstate with
        ptr___pthread_setcancelstate.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/x86_64/localplt.data: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (__pthread_setcancelstate): New prototype.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6e1ae9bae180f0cf43d73ee2ee395252d1e22e17

commit 6e1ae9bae180f0cf43d73ee2ee395252d1e22e17
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a638a9be6ccaa543607f1655f73806bd41b2140

commit 9a638a9be6ccaa543607f1655f73806bd41b2140
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ad0a4cef8d88a8985820228413afde66af1f52eb

commit ad0a4cef8d88a8985820228413afde66af1f52eb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1c810396a130fc4cc8ad0bb7d7438b58bbac6e78

commit 1c810396a130fc4cc8ad0bb7d7438b58bbac6e78
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Jun 30 12:53:04 2012 -0700

    Add STB_SECONDARY support to ld.so

    Enable STB_SECONDARY if it is supported by binutils.  Add 3 STB_SECONDARY
    tests.

        * config.h.in: Add HAVE_ASM_SECONDARY_DIRECTIVE.
        * config.make.in (have-secondary): New macro.
        * configure.in: Check if STB_SECONDARY is supported by as/ld.
        Define HAVE_ASM_SECONDARY_DIRECTIVE and set have-secondary to yes
        if the .secondary assembly directive works.
        * configure: Regenerated.
        * elf/Makefile (tests): Add tst-secondary1 tst-secondary2
        tst-secondary3 if STB_SECONDARY is supported by as/ld.
        (modules-names): Add tst-secondarymod tst-secondary1mod
        tst-secondary2mod tst-secondary3mod if STB_SECONDARY is supported
        by as/ld.
        (LDFLAGS-tst-secondarymod.so): New macro.
        ($(objpfx)tst-secondary1): New rule.
        ($(objpfx)tst-secondary2): Likewise.
        ($(objpfx)tst-secondary3): Likewise.
        * elf/dl-addr.c (determine_info): Also check STB_SECONDARY.
        * elf/dl-lookup.c (do_lookup_x): Handle STB_SECONDARY.
        (_dl_lookup_symbol_x): Likewise.
        * elf/sprof.c (read_symbols): Likewise.
        * elf/elf.h (STB_SECONDARY): New.
        (STB_NUM): Updated.
        * elf/tst-secondary.h: New file.
        * elf/tst-secondary1.c: Likewise.
        * elf/tst-secondary1mod.c: Likewise.
        * elf/tst-secondary2.c: Likewise.
        * elf/tst-secondary2mod.c: Likewise.
        * elf/tst-secondary3.c: Likewise.
        * elf/tst-secondary3mod.c: Likewise.
        * elf/tst-secondarymod.c: Likewise.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (9 preceding siblings ...)
  2015-09-16 19:43 ` cvs-commit at gcc dot gnu.org
@ 2015-09-16 20:01 ` cvs-commit at gcc dot gnu.org
  2015-09-24 15:52 ` cvs-commit at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-16 20:01 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.21 has been created
        at  a574db341f6583a625f529493ec423ab436f69c9 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a574db341f6583a625f529493ec423ab436f69c9

commit a574db341f6583a625f529493ec423ab436f69c9
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * misc/error.c (error): Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        (error_at_line): Likewise.
        * posix/wordexp.c (parse_comm): Likewise.
        * stdlib/fmtmsg.c (fmtmsg): Likewise.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-pthread_unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c [HAVE_ASM_SECONDARY_DIRECTIVE] (FORWARD2): New.
        (FORWARD_NORETURN): Likewise.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't define if
        (__pthread_unwind): Don't define if HAVE_ASM_SECONDARY_DIRECTIVE
        is defined.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_rwlock_wrlock.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-pthread_unwind.c: Likewise.
        * nptl/nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace ptr_pthread_setcancelstate with
        ptr___pthread_setcancelstate.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (__pthread_setcancelstate): New prototype.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5c0fcf5e6abb72f16fc5a260218a3dc4d16a977f

commit 5c0fcf5e6abb72f16fc5a260218a3dc4d16a977f
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d8f0433371731d83a754ad173215e6a38d712424

commit d8f0433371731d83a754ad173215e6a38d712424
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=af345c230d3f2d2b810cfec292188e26c3da5a48

commit af345c230d3f2d2b810cfec292188e26c3da5a48
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug nptl/14569] libpthread.a isn't linked in properly
  2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
                   ` (10 preceding siblings ...)
  2015-09-16 20:01 ` cvs-commit at gcc dot gnu.org
@ 2015-09-24 15:52 ` cvs-commit at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-24 15:52 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.22 has been created
        at  7c846b63a8321c6822a6b5ad82b1134ff8d1d18b (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7c846b63a8321c6822a6b5ad82b1134ff8d1d18b

commit 7c846b63a8321c6822a6b5ad82b1134ff8d1d18b
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * misc/error.c (error): Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        (error_at_line): Likewise.
        * posix/wordexp.c (parse_comm): Likewise.
        * stdlib/fmtmsg.c (fmtmsg): Likewise.
        * nptl/Makefile:
        (routines): Add libc-pthread-secondary.
        (CFLAGS-libc-pthread-secondary.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add pthread_once.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, __pthread_mutex_lock,
        __pthread_mutex_unlock, __pthread_once,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock,
        __pthread_rwlock_unlock and __pthread_unwind.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE):
        Likewise.
        * cleanup_defer_compat.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        _pthread_cleanup_pop_restore and _pthread_cleanup_push_defer.
        * nptl/forward.c [HAVE_ASM_SECONDARY_DIRECTIVE] (FORWARD2): New.
        (FORWARD_NORETURN): Likewise.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.
        (pthread_setcancelstate): Add an alias.
        * nptl/libc-pthread-secondary.c: New file.
        * nptl/nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace ptr_pthread_setcancelstate with
        ptr___pthread_setcancelstate.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthread_getspecific.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_getspecific.
        * nptl/pthread_key_create.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_key_create.
        * nptl/pthread_mutex_lock.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_mutex_lock.
        * nptl/pthread_mutex_unlock.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_mutex_unlock.
        * nptl/pthread_once.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_once.
        * nptl/pthread_rwlock_rdlock.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_rwlock_rdlock.
        * nptl/pthread_rwlock_unlock.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_rwlock_unlock.
        * nptl/pthread_rwlock_wrlock.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_rwlock_wrlock.
        * nptl/pthread_setspecific.c: Include <shlib-compat.h>.
        Add GLIBC_2_0 and GLIBC_PRIVATE versions for
        __pthread_setspecific.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Add __pthread_getspecific,
        __pthread_key_create, __pthread_once, __pthread_rwlock_rdlock,
        __pthread_rwlock_wrlock, __pthread_rwlock_unlock,
        __pthread_setcancelstate, __pthread_setspecific,
        __pthread_unwind.  _pthread_cleanup_pop_restore and
        _pthread_cleanup_push_defer.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/x86_64/localplt.data: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (__pthread_setcancelstate): New prototype.
        (pthread_setcancelstate): Renamed to ...
        (__pthread_setcancelstate): This.  Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * sysdeps/nptl/jmp-unwind.c: Include <bits/libc-lock.h>
        instead of <nptl/pthreadP.h>.
        (__pthread_cleanup_upto): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (_longjmp_unwind): Use __libc_ptf_call.
        * sysdeps/unix/sysv/linux/s390/jmp-unwind.c: Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.  Replace pthread_setcancelstate with
        __pthread_setcancelstate.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Add pthread_once.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Don't mark it weak if HAVE_ASM_SECONDARY_DIRECTIVE is defined.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6e1ae9bae180f0cf43d73ee2ee395252d1e22e17

commit 6e1ae9bae180f0cf43d73ee2ee395252d1e22e17
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a638a9be6ccaa543607f1655f73806bd41b2140

commit 9a638a9be6ccaa543607f1655f73806bd41b2140
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ad0a4cef8d88a8985820228413afde66af1f52eb

commit ad0a4cef8d88a8985820228413afde66af1f52eb
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1c810396a130fc4cc8ad0bb7d7438b58bbac6e78

commit 1c810396a130fc4cc8ad0bb7d7438b58bbac6e78
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Jun 30 12:53:04 2012 -0700

    Add STB_SECONDARY support to ld.so

    Enable STB_SECONDARY if it is supported by binutils.  Add 3 STB_SECONDARY
    tests.

        * config.h.in: Add HAVE_ASM_SECONDARY_DIRECTIVE.
        * config.make.in (have-secondary): New macro.
        * configure.in: Check if STB_SECONDARY is supported by as/ld.
        Define HAVE_ASM_SECONDARY_DIRECTIVE and set have-secondary to yes
        if the .secondary assembly directive works.
        * configure: Regenerated.
        * elf/Makefile (tests): Add tst-secondary1 tst-secondary2
        tst-secondary3 if STB_SECONDARY is supported by as/ld.
        (modules-names): Add tst-secondarymod tst-secondary1mod
        tst-secondary2mod tst-secondary3mod if STB_SECONDARY is supported
        by as/ld.
        (LDFLAGS-tst-secondarymod.so): New macro.
        ($(objpfx)tst-secondary1): New rule.
        ($(objpfx)tst-secondary2): Likewise.
        ($(objpfx)tst-secondary3): Likewise.
        * elf/dl-addr.c (determine_info): Also check STB_SECONDARY.
        * elf/dl-lookup.c (do_lookup_x): Handle STB_SECONDARY.
        (_dl_lookup_symbol_x): Likewise.
        * elf/sprof.c (read_symbols): Likewise.
        * elf/elf.h (STB_SECONDARY): New.
        (STB_NUM): Updated.
        * elf/tst-secondary.h: New file.
        * elf/tst-secondary1.c: Likewise.
        * elf/tst-secondary1mod.c: Likewise.
        * elf/tst-secondary2.c: Likewise.
        * elf/tst-secondary2mod.c: Likewise.
        * elf/tst-secondary3.c: Likewise.
        * elf/tst-secondary3mod.c: Likewise.
        * elf/tst-secondarymod.c: Likewise.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2015-09-24 15:52 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-10 21:47 [Bug nptl/14569] New: libpthread.a isn't linked in properly hjl.tools at gmail dot com
2012-09-28  7:36 ` [Bug nptl/14569] " davem at davemloft dot net
2012-09-28  7:37 ` davem at davemloft dot net
2014-06-17  4:34 ` fweimer at redhat dot com
2015-09-15 15:37 ` cvs-commit at gcc dot gnu.org
2015-09-15 21:34 ` cvs-commit at gcc dot gnu.org
2015-09-16  0:12 ` cvs-commit at gcc dot gnu.org
2015-09-16 12:47 ` cvs-commit at gcc dot gnu.org
2015-09-16 12:54 ` cvs-commit at gcc dot gnu.org
2015-09-16 18:17 ` cvs-commit at gcc dot gnu.org
2015-09-16 19:43 ` cvs-commit at gcc dot gnu.org
2015-09-16 20:01 ` cvs-commit at gcc dot gnu.org
2015-09-24 15:52 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).