[Bug libc/15722] New: Verify that all internal sockets opened with SOCK_CLOEXEC

[Bug libc/15722] New: Verify that all internal sockets opened with SOCK_CLOEXEC

[thiago at kde dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15722

            Bug ID: 15722
           Summary: Verify that all internal sockets opened with
                    SOCK_CLOEXEC
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: thiago at kde dot org
                CC: drepper.fsp at gmail dot com

As the Summary says.

glibc has many internal sockets that it opens for internal operations and
doesn't use SOCK_CLOEXEC on. Some of those sockets are used only for a short
time (for ioctl or netlink), but some may be for a long time. Anyway, however
short the time it stays open, there's still a chance that it may leak by
another thread doing a simultaneous fork().

I've found socket openings without SOCK_CLOEXEC in:

 * __opensock (socket/opensock.c), though the override in
sysdeps/unix/sysv/linux/opensock.c uses SOCK_CLOEXEC
 * getifaddrs (sysdeps/gnu/ifaddrs.c and sysdeps/unix/sysv/linux/ifaddrs.c)
 * getaddrinfo (sysdeps/posix/getaddrinfo.c)
 * __check_native (sysdeps/unix/sysv/linux/check_native.c)
 * __check_pf (sysdeps/unix/sysv/linux/check_pf.c)
 * multiple in resolv/res_send.c

There could be more.

Maybe it would be useful to have an internal function that opens always a
socket with O_CLOEXEC semantics.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[neleai at seznam dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722

Ondrej Bilka <neleai at seznam dot cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |neleai at seznam dot cz

--- Comment #1 from Ondrej Bilka <neleai at seznam dot cz> ---
Could you prepare a patch that fixes these?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[thiago at kde dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722

--- Comment #2 from Thiago Macieira <thiago at kde dot org> ---
I'm sorry, I'm not qualified to do that under glibc coding style. I don't even
understand how the buildsystem works, so I can't tell which files are relevant
or not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[neleai at seznam dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722

Ondrej Bilka <neleai at seznam dot cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #3 from Ondrej Bilka <neleai at seznam dot cz> ---
A most work here is clasifying which files are internal and which not. A sample
list could be generated by:

git grep ' open (' | grep '\.c' | grep -v '\(tst\|bug\)'
git grep ' fopen (' | grep '\.c' | grep -v '\(tst\|bug\)'

But somebody needs to go througth this and filter entries with clockexec or
these passed to user code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|security-                   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[thiago at kde dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722

--- Comment #4 from Thiago Macieira <thiago at kde dot org> ---
I respectfully submit that glibc opening files without FD_CLOEXEC is a bug, as
it makes quite a few of the functions thread-unsafe. This issue should be
changed from "enhancement" to "normal".

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libc                        |network

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug network/15722] Verify that all internal sockets opened with SOCK_CLOEXEC

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15722
Bug 15722 depends on bug 19695, which changed state.

Bug 19695 Summary: libresolv needs to set O_CLOEXEC on its sockets
https://sourceware.org/bugzilla/show_bug.cgi?id=19695

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.