[Bug dynamic-link/16194] New: x86-64 dynamic linker should preserve zmm registers

[Bug dynamic-link/16194] New: x86-64 dynamic linker should preserve zmm registers

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

            Bug ID: 16194
           Summary: x86-64 dynamic linker should preserve zmm registers
           Product: glibc
           Version: 2.19
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com

Intel AVX-512 introduced 512-bit zmm registers. x86-64
ld.so should preserve zmm0-zmm8.  There is also a propsal
to preserve [xyz]mm8-[xyz]mm15:

https://groups.google.com/forum/?hl=en#!topic/x86-64-abi/ko37wGo7eF4

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Host|                            |i?86-*-* x86_64-*-*
            Summary|x86-64 dynamic linker       |[i386/x86_64] x86-64
                   |should preserve zmm         |dynamic linker should
                   |registers                   |preserve zmm registers

--- Comment #1 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Presumably the x86 dynamic linker should preserve any used for argument passing
of vector types as well?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.20

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed by

commit 2d63a517e4084ec80403cd9f278690fa8b676cc4
Author: Igor Zamyatin <igor.zamyatin@intel.com>
Date:   Thu Mar 13 11:10:22 2014 -0700

    Save and restore AVX-512 zmm registers to x86-64 ld.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |carlos at redhat dot com
         Resolution|FIXED                       |---

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> ---
I'm considering this fix incomplete because it doesn't enhance tst-xmmymm.sh to
include checking for zmm register usage within the dynamic linker itself. This
script is used to ensure we don't have any arbitrary paths in ld.so that might
itself clobber zmm.

H.J., could you please work with Igore to enhance the script to add that extra
level of sanity checking that will make sure we don't have any mistakes here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.19                        |2.20
   Target Milestone|2.20                        |2.21

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> ---
Siddhesh posted patch:
https://sourceware.org/ml/libc-alpha/2014-09/msg00228.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5379aebddd0a35c052e7149fb4ff88b49676516e (commit)
      from  8c0ab919f63dc03a420751172602a52d2bea59a8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5379aebddd0a35c052e7149fb4ff88b49676516e

commit 5379aebddd0a35c052e7149fb4ff88b49676516e
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Fri Sep 12 12:31:05 2014 +0530

    Enhance tst-xmmymm.sh to detect zmm register usage in ld.so (BZ #16194)

    2d63a517e4084ec80403cd9f278690fa8b676cc4 added support to save and
    restore zmm register in the dynamic linker, but did not enhance
    test-xmmymm.sh to detect accidental usage of these registers.  The
    patch below adds that check.

    The script has also been renamed to tst-ld-sse-use.sh.  To see the
    minimal changes, run `git show -M`.

        [BZ #16194]
        * sysdeps/x86/tst-xmmymm.sh: Rename file to...
        * sysdeps/x86/tst-ld-sse-use.sh: ... this.  Check for zmm
        register usage.
        * sysdeps/x86/Makefile: Adjust.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                        |    8 ++++++++
 sysdeps/x86/Makefile                             |    4 ++--
 sysdeps/x86/{tst-xmmymm.sh => tst-ld-sse-use.sh} |    8 ++++----
 3 files changed, 14 insertions(+), 6 deletions(-)
 rename sysdeps/x86/{tst-xmmymm.sh => tst-ld-sse-use.sh} (90%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/16194] [i386/x86_64] x86-64 dynamic linker should preserve zmm registers

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16194

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |siddhesh at redhat dot com
         Resolution|---                         |FIXED

--- Comment #6 from Siddhesh Poyarekar <siddhesh at redhat dot com> ---
Test updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.