[Bug libc/16430] New: PowerPC: ftime gettimeofday internal call returning bogus data

[Bug libc/16430] New: PowerPC: ftime gettimeofday internal call returning bogus data

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

            Bug ID: 16430
           Summary: PowerPC: ftime gettimeofday internal call returning
                    bogus data
           Product: glibc
           Version: 2.19
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: azanella at linux dot vnet.ibm.com
                CC: drepper.fsp at gmail dot com

The testcase:

#include <stdlib.h>
#include <stdio.h>
#include <sys/types.h>
#include <sys/time.h>
#include <sys/timeb.h>

int
main ()
{
  struct timeval tv;
  struct timeb s, slast;
  int c = 0;

  ftime (&slast);
  while (c < 10)
    {
      ftime (&s);
      if (s.time < slast.time
          || (s.time == slast.time && s.millitm < slast.millitm))
        exit (1);
      if (s.time != slast.time)
        ++c;
      slast.time = s.time;
      slast.millitm = s.millitm;
    }
  exit (0);
}

Is failing for PPC32 after ef26eece6331a1f6d959818e37c438cc7ce68e53 (PowerPC:
gettimeofday optimization by using IFUNC). This is due the fact linker is not
setting the gettimeofday call from ftime through a PLT, as PPC64; and thus
calling __gettimeofday ifunc resolver directly.

A possible fix would be detect a PPC32 build and set the internal symbol
'__GI___gettimeofday' to a different implementation than the ifunc resolver.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |azanella at linux dot vnet.ibm.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[adconrad at 0c3 dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Adam Conrad <adconrad at 0c3 dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adconrad at 0c3 dot net

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |azanella at linux dot vnet.ibm.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |CoreyMutter at eaton dot com

--- Comment #1 from Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> ---
*** Bug 16257 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> ---
Fixed upstream by 736c304a1ab4cee36a2f3343f1698bc0abae4608. I will keep the bug
report open to remind me to add a similar testcase when 2.20 opens.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at redhat dot com

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> ---
Does this need backporting to other branches say 2.18 or 2.17?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[adconrad at 0c3 dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

--- Comment #4 from Adam Conrad <adconrad at 0c3 dot net> ---
This seemed to regress with ef26eece6331a1f6d959818e37c438cc7ce68e53, so if
there was any backporting to be done, it would only be to 2.18.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[CoreyMutter at eaton dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

--- Comment #5 from Corey Mutter <CoreyMutter at eaton dot com> ---
The problem definitely applies in 2.18, see 16257. Definitely not in 2.15, and
I haven't used intermediate versions :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] PowerPC: ftime gettimeofday internal call returning bogus data

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.19                        |2.20

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] [powerpc] PowerPC: ftime gettimeofday internal call returning bogus data

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Host|                            |powerpc*-*-*
            Summary|PowerPC: ftime gettimeofday |[powerpc] PowerPC: ftime
                   |internal call returning     |gettimeofday internal call
                   |bogus data                  |returning bogus data

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] [powerpc] PowerPC: ftime gettimeofday internal call returning bogus data

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16430] [powerpc] PowerPC: ftime gettimeofday internal call returning bogus data

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

--- Comment #6 from Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> ---
It is being fixed and GLIBC 2.20 added a test for internal gettimeofday usage
(through ftime) in commit fe1cc35abb6e968d0b12d7ff3ef78cf821a5f48d.  Do we
intend to backport the fix and testcase for 2.18? If not I think we should
close the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug time/16430] [powerpc] PowerPC: ftime gettimeofday internal call returning bogus data

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16430

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libc                        |time

-- 
You are receiving this mail because:
You are on the CC list for the bug.