[Bug libc/16850] New: [aarch64] MINSIGSTKSZ is (much) too small

[Bug libc/16850] New: [aarch64] MINSIGSTKSZ is (much) too small

[michael.hudson at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

            Bug ID: 16850
           Summary: [aarch64] MINSIGSTKSZ is (much) too small
           Product: glibc
           Version: 2.19
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: michael.hudson at linaro dot org
                CC: drepper.fsp at gmail dot com

MINSIGSTKSZ is only 2048 but when you as SA_SIGINFO, the kernel pushes (IIRC)
4704 bytes onto the stack.  Which is more than 2048:

ubuntu@ms01a:~/mwhudson$ cat u.c 
#include <string.h>
#include <stdlib.h>
#include <signal.h>
#include <stdio.h>

char* buf;

void handler(int signo, siginfo_t *info, void *context)
{
//    char i;
//    printf("hi %p %ld\n", &i, &i - buf);
    return;
}

int main (int argc, char** argv)
{
    stack_t ss;
    int i;
    struct sigaction sa;

    buf = malloc(5*MINSIGSTKSZ);
    if (!buf) abort();

    memset(buf, 0, 5*MINSIGSTKSZ);

    ss.ss_sp = buf + 2*MINSIGSTKSZ;
    ss.ss_size = MINSIGSTKSZ;
    ss.ss_flags = 0;
    if (sigaltstack(&ss, NULL) == -1)
        abort();

    sa.sa_sigaction = handler;
    sa.sa_flags = SA_SIGINFO|SA_ONSTACK;
    sigemptyset(&sa.sa_mask);
    sigaction(SIGHUP, &sa, NULL);

    kill(getpid(), SIGHUP);

    for (i = 0; i < 2*MINSIGSTKSZ; i++) {
        if (buf[i]) printf("%d\n", i);    
    }

    for (i = 3*MINSIGSTKSZ; i < 5*MINSIGSTKSZ; i++) {
        if (buf[i]) printf("%d\n", i);    
    }

}
ubuntu@ms01a:~/mwhudson$ gcc u.c -o u && ./u
1416
1417
1418
1419
1424
1425
1426
....

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[michael.hudson at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Michael Hudson-Doyle <michael.hudson at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hudson at linaro dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcus.shawcroft at arm dot com

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
Even SIGSTKSZ is very tight, it can barely handle a single signal frame.  Sparc
is using 4096/16384, which would be much more reasonable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> ---
Of course, 4096 is still too small.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

--- Comment #3 from Andreas Schwab <schwab@linux-m68k.org> ---
This is causing a python3 test to fail.

http://bugs.python.org/issue22503

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcus.shawcroft at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[marcus.shawcroft at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Marcus Shawcroft <marcus.shawcroft at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |marcus.shawcroft at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[renlin.li at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Renlin Li <renlin.li at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |renlin.li at arm dot com

--- Comment #4 from Renlin Li <renlin.li at arm dot com> ---
I am working on this

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|fweimer at redhat dot com          |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  b763f6ae859ecea70a5dacb8ad45c71d5f667e2e (commit)
      from  c26efef9798914e208329c0e8c3c73bb1135d9e3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e

commit b763f6ae859ecea70a5dacb8ad45c71d5f667e2e
Author: Andreas Schwab <schwab@suse.de>
Date:   Tue Sep 30 12:41:11 2014 +0200

    aarch64: Increase MINSIGSTKSZ and SIGSTKSZ (bug 16850)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |    5 +++++
 NEWS                                               |   12 ++++++------
 .../linux/{powerpc => aarch64}/bits/sigstack.h     |    4 ++--
 3 files changed, 13 insertions(+), 8 deletions(-)
 copy sysdeps/unix/sysv/linux/{powerpc => aarch64}/bits/sigstack.h (94%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/16850] [aarch64] MINSIGSTKSZ is (much) too small

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.22

--- Comment #6 from Andreas Schwab <schwab@linux-m68k.org> ---
Fixed in 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.