[Bug stdio/17370] New: memory leak in libio/wfileops.c do_ftell_wide

[Bug stdio/17370] New: memory leak in libio/wfileops.c do_ftell_wide

[tim.lammens at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17370

            Bug ID: 17370
           Summary: memory leak in libio/wfileops.c do_ftell_wide
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: critical
          Priority: P2
         Component: stdio
          Assignee: unassigned at sourceware dot org
          Reporter: tim.lammens at gmail dot com

The only malloc in libio/wfileops.c is unmatched with a free.

Here is an extract from a valgrind session, it mentions libc-2.17 but in
reality it is a patched version which matches the source code of the following
commit:
https://sourceware.org/git/?p=glibc.git;a=blobdiff;f=libio/wfileops.c;h=7f4c92399faf741af41cd61305b0e3bb401592f8;hp=9cebe771263e228f8c69e2f734730503f2c3fe99;hb=000232b9bcbf194f1e5fd0ff380000f341505405;hpb=116f4d1ad64a061488b29ef89f1a60f5e8c5963b

==2965== 410,460 bytes in 50 blocks are definitely lost in loss record 48 of 49
==2965==    at 0x4C2541D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==2965==    by 0x53B5BC5: _IO_wfile_seekoff (in /lib64/libc-2.17.so)
==2965==    by 0x53B02F5: ftell (in /lib64/libc-2.17.so)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/17370] memory leak in libio/wfileops.c do_ftell_wide

[tim.lammens at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17370

Tim <tim.lammens at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tim.lammens at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/17370] memory leak in libio/wfileops.c do_ftell_wide

[tim.lammens at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17370

--- Comment #1 from Tim <tim.lammens at gmail dot com> ---
Created attachment 7775
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7775&action=edit
patch to fix memory leak.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/17370] memory leak in libio/wfileops.c do_ftell_wide

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17370

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  984c0ea97f649c869130a1ff099098e2b6f70aad (commit)
      from  3daee1076b3703b01235949e2dcc8e29eb028aad (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=984c0ea97f649c869130a1ff099098e2b6f70aad

commit 984c0ea97f649c869130a1ff099098e2b6f70aad
Author: Tim Lammens <tim.lammens@gmail.com>
Date:   Thu Sep 11 10:35:54 2014 +0530

    Fix memory leak in libio/wfileops.c do_ftell_wide [BZ #17370]

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |    5 +++++
 NEWS             |    2 +-
 libio/wfileops.c |    1 +
 3 files changed, 7 insertions(+), 1 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/17370] memory leak in libio/wfileops.c do_ftell_wide

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17370

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |siddhesh at redhat dot com
         Resolution|---                         |FIXED

--- Comment #3 from Siddhesh Poyarekar <siddhesh at redhat dot com> ---
Fixed in master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/17370] memory leak in libio/wfileops.c do_ftell_wide

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17370

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  545583d664b64ff234b99aca0d85e99c8a55808f (commit)
      from  f0416165a5d0aba7c63d2870894b716db8f76319 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=545583d664b64ff234b99aca0d85e99c8a55808f

commit 545583d664b64ff234b99aca0d85e99c8a55808f
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Tue Sep 16 14:20:45 2014 +0530

    Fix memory leak in error path of do_ftell_wide (BZ #17370)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |    5 +++++
 libio/wfileops.c |    5 ++++-
 2 files changed, 9 insertions(+), 1 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug stdio/17370] memory leak in libio/wfileops.c do_ftell_wide

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17370

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, release/2.20/master has been updated
       via  4adf2992ac7ebf6720d8d56589eb297f5215730c (commit)
       via  d2c37d028d48337d00200248340de0e4a893456b (commit)
      from  979add9f87577c10c629af82586e48b686672134 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4adf2992ac7ebf6720d8d56589eb297f5215730c

commit 4adf2992ac7ebf6720d8d56589eb297f5215730c
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Tue Sep 16 14:20:45 2014 +0530

    Fix memory leak in error path of do_ftell_wide (BZ #17370)

    (cherry picked from commit 545583d664b64ff234b99aca0d85e99c8a55808f)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d2c37d028d48337d00200248340de0e4a893456b

commit d2c37d028d48337d00200248340de0e4a893456b
Author: Tim Lammens <tim.lammens@gmail.com>
Date:   Thu Sep 11 10:35:54 2014 +0530

    Fix memory leak in libio/wfileops.c do_ftell_wide [BZ #17370]

    (cherry picked from commit 984c0ea97f649c869130a1ff099098e2b6f70aad)

    Conflicts:
        NEWS

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |   10 ++++++++++
 NEWS             |    2 +-
 libio/wfileops.c |    6 +++++-
 3 files changed, 16 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.